CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-02-13 09:12:52 +00:00
Code Issues Packages Projects Releases Wiki Activity
11,245 Commits 2 Branches 0 Tags
34fcd01f98f5ff5563ea752e06a480d420cbff98
Commit Graph

2742 Commits

Author SHA1 Message Date
Quincy Morgan
34fcd01f98 Add validation warning for unsquare buildings 2019-04-23 15:50:52 -07:00
Bryan Housel
a37ce90af7 Move "Fix All" from bottom of list to top 2019-04-23 17:42:14 -04:00
Quincy Morgan
4948474118 Set the default validation filters to be My Edits / Everywhere (re: #6223) 2019-04-23 10:34:10 -07:00
Bryan Housel
7e04175559 Add Enable All / Disable All validation rules links 
(closes #5986)
 2019-04-23 13:01:15 -04:00
Bryan Housel
1d4770a3c6 Merge pull request #6211 from AndreasHae/feature/split-multiple-tags 
Handle multiple tags when splitting up in tag editor
 2019-04-23 11:05:03 -04:00
Bryan Housel
bd2a33d845 Merge branch 'validation_and_change_perf' 2019-04-23 01:30:26 -04:00
Bryan Housel
a3bc164c43 Redraw entity editor fields on addition, deletion too 
This is important to make the turn restriction editor work
 2019-04-23 01:07:38 -04:00
Bryan Housel
7dce4bb161 Avoid asking DOM if layers are classed disabled in map.editable 
`map.editable` is hot code because it's called frequently by the `isHiddenX`
tests in `features.js`.  It's much more efficient to just ask the osm layer
whether it is enabled, than to use D3 to find that layer in the DOM and check
whether it's classed `disabled`
 2019-04-22 22:12:42 -04:00
Bryan Housel
61da61d7fd Add missing button arg to modeDrawLine, ensure using current entities 2019-04-22 20:00:53 -04:00
Bryan Housel
3fe9d75f35 Fix issues with issue cache for entities that no longer exist 2019-04-22 19:35:23 -04:00
Quincy Morgan
e04d860f62 Convert "Detach" operation into "Extract" operation that also works on areas (close #6203) 2019-04-22 14:46:01 -07:00
Andreas Hässler
e49fdce215 Add missing semicolons 2019-04-22 23:43:55 +02:00
Andreas Hässler
2596b97dbc Do not use ES6 features 2019-04-22 16:38:33 +02:00
Andreas Hässler
faa178797d Handle multiple tags when splitting up 2019-04-22 16:22:59 +02:00
Bryan Housel
e4fc821eb0 Just use reduce 2019-04-22 09:49:17 -04:00
Bryan Housel
3557e3c711 Don't allow disconnecting a way if parts extend to undownloaded tiles 
(re: #2248, #4245)
 2019-04-20 00:02:46 -04:00
Bryan Housel
bbf4495f5c pacify eslint 2019-04-19 23:44:49 -04:00
Bryan Housel
7c85cc997e Merge branch 'master' into validation_and_change_perf 2019-04-19 22:44:04 -04:00
Quincy Morgan
b566ef05b5 Add Option+W shortcut to toggle the OSM data layer (close #6104) 2019-04-19 14:51:53 -07:00
Quincy Morgan
a892114351 Fix disconnection code test (close #4245) 2019-04-19 13:26:16 -07:00
Bryan Housel
51c1088c1b Merge branch 'master' into validation_and_change_perf 2019-04-19 15:18:23 -04:00
Quincy Morgan
130e9909f6 Allow disconnecting an entire way from other ways at once (close #4245) 2019-04-19 11:54:13 -07:00
Bryan Housel
b5c5a00abc Get rid of the many_deletions validation 🔪 
It just doesn't fit in with all of the other validations that work on
entities, and it's not an actionable warning anyway.
https://github.com/openstreetmap/iD/pull/6140#issuecomment-483014618
 2019-04-19 13:33:29 -04:00
Bryan Housel
2ebbb68604 Restore tooltips on rule checkboxes, separate 'tip' and 'reference' 
Reference will show on clicking info button, and can contain more
useful information than a tooltip can.
 2019-04-19 13:24:55 -04:00
Bryan Housel
4d66cacb27 Nodes needs Array.length not Set.size 2019-04-19 11:04:41 -04:00
Bryan Housel
1092ddb125 Make sure to update the save count when restoring changes too 2019-04-19 10:56:00 -04:00
Bryan Housel
ae06e28f9b Try to avoid style recalculation when typing on the comment box 
I think this doesn't completely work.. It reduces the amount
of unnecessary DOM changes, but there are still some more.
 2019-04-19 10:02:25 -04:00
Bryan Housel
ca02f7ed06 Must use context.graph to validate entities instead of validatedgraph 
This is because all the validators use it, and it's the right thing to do.
As entites load from the OSM or are restored from history, the most
updated version of them will be in context.graph, not validatedGraph
 2019-04-19 10:00:38 -04:00
Bryan Housel
c4209515a5 Only consider hiding features matched to a rule 
(Fixes accidental hiding of vertices)
 2019-04-18 19:26:17 -04:00
Bryan Housel
a56c1af725 pacify eslint 2019-04-18 19:26:05 -04:00
Bryan Housel
a55b4387fe Make sure the notification badge starts out hidden 2019-04-18 19:06:23 -04:00
Bryan Housel
0eed80e1d2 Persist disabled rules in localStorage 2019-04-18 17:30:55 -04:00
Quincy Morgan
2f695a9747 Add link to the PeWu history viewer to the History panel (close #6202) 2019-04-18 14:06:48 -07:00
Bryan Housel
7c8a6eac9d Reintroduce disabled rules 
- They still run, but results are excluded from lists
- Also make sure to revalidate/dispatch/update when toggling rules
 2019-04-18 17:05:33 -04:00
Quincy Morgan
a30051fd9c Restore full screen ability 2019-04-18 10:37:22 -07:00
Bryan Housel
9c4881cade Change autofix to accept arguments to perform, implement "fix all" 2019-04-17 17:51:29 -04:00
Bryan Housel
d6327aec56 Make reference function optional 
Now it shows the "No documentation available" message if there is not one
 2019-04-17 09:05:05 -04:00
Bryan Housel
0d70f0670d Better test for whether untagged entities can be deleted 
Now entities can always be deleted if the user created them in the first
place.. We skip asking `operationDelete.disabled()` because there are reasons
why this may return true.

A thing that could happen before:
- User creates an untagged entity
- Quits browser and restarts iD
- Restores history
- The entity happens to be in a part of the map that hasn't been loaded yet,
  so `operationDelete.disabled()` returns true, and the issue ends up
  as a 'warning' instead of an 'error'
 2019-04-16 22:56:43 -04:00
Quincy Morgan
2967d2d020 Add support for icons from the noun project (close #5691) 2019-04-16 18:06:05 -07:00
Quincy Morgan
84b7e08bf8 Don't select the previously-edited node when undoing/redoing (re: #5831) 2019-04-16 14:21:15 -07:00
Bryan Housel
01d2e3eaf3 Replace validator tooltip with reference function, add tag diff 2019-04-16 17:07:53 -04:00
Quincy Morgan
3a2757576b Add Monorail Route, Turnstile, and Transit Stop Area Group presets (close #5757) 2019-04-16 11:41:56 -07:00
Quincy Morgan
72266af1e5 Show case-sensitive taginfo results for Manufacturer field 2019-04-16 09:59:00 -07:00
Bryan Housel
8afd8887cf Restyle much of the issues and entity issues - avoid tooltips 2019-04-16 12:33:48 -04:00
Bryan Housel
294ce00211 substitute 'info' for 'data' (so I can use 'info' for an info drawer) 2019-04-15 16:56:21 -04:00
Quincy Morgan
80a6e1806f Don't remove wikidata tag when clearing the wikipedia field value (close #4322) 2019-04-15 13:39:30 -07:00
Quincy Morgan
6bdf6c5127 Fix minimap position (close #6167) 
Flexbox panes and info panels to prevent overlap (close #4733)
 2019-04-15 11:50:54 -07:00
Bryan Housel
f6708fd84c Hide feature if _all_ rules hidden (was: if _any_ rule hidden) 
This matters as we start to match more rules for hybrid features like rail
platforms, which now match both path and rail.  We want to show them unless the
user has hidden all the rules that they match.

Also this changes the test code slightly to actually test rule matching.
Before it was really just testing hiding.
 2019-04-15 10:20:58 -04:00
Bryan Housel
15e73d2836 Trying out simpler outdated_tags code, with tag diff 2019-04-14 17:25:51 -04:00
Bryan Housel
5a0f21fa7a Add ability for a fix to be auto, and add auto fix buttons 
This also changes some of the list items that were previously buttons to divs,
since we can't nest buttons.
 2019-04-13 10:50:47 -04:00