Commit Graph

4965 Commits

Author SHA1 Message Date
Kyℓe Hensel
38d2ccd866 isHighwayIntersection only applies to nodes, so remove from osmEntity (#10831) 2025-03-04 11:29:29 +01:00
Martin Raifer
4d78e80ea1 fix scrolling glitch in Firefox on Windows and Linux/Xorg
For some elements, Firefox reports wheel deltas measured in lines (see https://developer.mozilla.org/en-US/docs/Web/API/WheelEvent/deltaMode), which we need to convert to pixels. The previous routine hugely overestimated the conversion factor if the deltaY as slightly bigger (not sure where the exp function came from originally, it does not make much sense IMO).
The lines-to-pixels factor does not seem to be quite consistent between different Firefox builds, but this compromise factor should be good enough, I hope.

PS: Firefox on Mac OS does not report deltas as lines anymore it seems.

closes #10825
2025-03-03 21:06:24 +01:00
Marwin Hochfelsner
a5b9479429 Change zoomToNote to moveToNote (#10819) 2025-02-28 09:57:13 +01:00
Martin Raifer
671e9f0069 use aqueduct as default value for tunnel tag in waterway structure field
(prerequisite for https://github.com/openstreetmap/id-tagging-schema/pull/1273)
2025-02-26 11:50:44 +01:00
Martin Raifer
813f9ef8cd hide carret when options exhausted also for comboboxes w/ static values 2025-02-25 18:30:49 +01:00
Martin Raifer
ab007dbbb8 restore highlighting of empty changeset comment field
restores behaviour from #4624/#4624, but switch to a neutral emphasis instead of the red color (which might be misinterpreted that the user already made a mistake)
2025-02-25 17:55:21 +01:00
Martin Raifer
ca7ae603c9 make sure combobox dropdown is removed when input field is removed
fixes #10319: when a relation membership role is edited, the change will trigger a redraw of the combobox (via D3 exit/enter). In this case, the `blur` event is never called, because the input element is immediately removed from the DOM. This is solved by cleaning up the dropdown when the combobox is about to be removed from the page.
2025-02-25 13:07:58 +01:00
Martin Raifer
f4d4a9e3b0 treat indoormark=* as indoor features, closes #10808
and don't classify `indoor=no` as indoor features
2025-02-24 18:21:39 +01:00
Martin Raifer
fa501696e5 fix false-positive missing translation, for street+place subfield
closes #10812
2025-02-24 15:33:43 +01:00
Martin Raifer
2b8ea8fc6a de-duplicate mapilio sequence linestrings
fixes poor performance
closes #10532
2025-02-22 10:53:36 +01:00
Kyℓe Hensel
147c785594 fix the turn restriction editor not supporting bidirectional roads (#10800) 2025-02-22 10:01:26 +01:00
Kyℓe Hensel
8659416af2 Fix duplicate values in the source field on the changeset page (#10799) 2025-02-22 09:57:18 +01:00
Martin Raifer
f2615f8a70 replace https workaround with uriScheme API param
See https://learn.microsoft.com/en-us/bingmaps/rest-services/imagery/get-imagery-metadata#template-parameters

Addendum to #10798
2025-02-22 09:51:16 +01:00
Kyℓe Hensel
fb1bce5a8a Always use HTTPS to load Bing Streetside images (#10798) 2025-02-22 09:42:04 +01:00
Martin Raifer
fb22f01b30 allow # (full width number sign) as alternative # sign for hashtags
this appears to be somewhat common in some asian scripts, resulting in unrecognized hashtags or superfluous "#" in `hashtags` changeset tag (e.g. https://stats.now.ohsome.org/dashboard#hashtag=%25EF%25BC%2583missingmaps&start=2007-02-20T23:00:00Z&end=2025-02-21T22:59:59Z&interval=P1M&countries=&topics=).
2025-02-21 18:48:42 +01:00
Martin Raifer
918126e5f8 revalidate entities with changed relation memberships 2025-02-18 13:19:32 +01:00
Marwin Hochfelsner
0a6cbf3ebc Sort tiles by zoom (#9504)
to make sure that low zoom tiles don't hide higher resolution tiles. This can be relevant in case of tile loading errors or around the coverage border of a tile service.
2025-02-18 12:00:36 +01:00
Marwin Hochfelsner
6026d69672 Replace setTimeout with ontransitionend for easier customizability (#10785) 2025-02-18 10:52:58 +01:00
Martin Raifer
31345c073a correctly detect Locale:* results when there are more than one langCodes
fixes a false positive console warning, e.g. reported in #9045

> Occasionally, it also gives a message which is not an error: "Unexpected title Locale:nl"
2025-02-17 21:17:59 +01:00
Mateusz Konieczny
2ff01beba3 Better describe culvert in fix for waterway-road intersection warnings (#10783) 2025-02-17 18:59:29 +01:00
Justin Tracey
d6ee1bb4cd add crossing:markings tag when connecting crossing (#9586) 2025-02-17 12:57:25 +01:00
Kyℓe Hensel
ef88e1c7ca fix destination_sign relations not updated when splitting a way (#10646) 2025-02-17 11:46:42 +01:00
Kyℓe Hensel
8f9d7e01bf validate suspicious names using the user's language (#9522) 2025-02-17 11:42:04 +01:00
Kyℓe Hensel
f513ccd03d enable intellisense for the main classes (#10618) 2025-02-17 11:35:50 +01:00
Kyℓe Hensel
083d6d04fe remove noexit=yes and fixme=continue when you continue a line (#9634) 2025-02-17 11:18:53 +01:00
Kyℓe Hensel
0fc978de45 remove leading semicolon from changeset source (#9887) 2025-02-17 11:13:52 +01:00
Martin Raifer
9b7b0cde9e fix walkthrough from not correctly registering deleted ways
fixes #10776, this was a regression in 7559dea
2025-02-16 11:37:25 +01:00
andrewpmk
a7038955ca Revalidate disconnected_way and impossible_oneway errors on change (#8911) 2025-02-15 18:45:32 +01:00
Martin Raifer
9f2b00f8c4 Merge branch 'develop' into way-reverse-dont-change-red-turn-direction 2025-02-13 11:00:58 +01:00
Martin Raifer
918522442b minor refactoring / renaming 2025-02-13 10:55:31 +01:00
Kyℓe Hensel
c1ca888b72 linkify keys & tags in the preset docs from the wiki (#10763) 2025-02-12 15:42:29 +01:00
Kyℓe Hensel
33c68064a6 Enable autofill for the source tag in the changeset panel (#10764) 2025-02-12 15:22:50 +01:00
Kyℓe Hensel
bd85d31b73 fix relation membership list using a non-deterministic order (#10648) 2025-02-12 15:16:54 +01:00
Kyℓe Hensel
6388a6a2ba allow broken (unclosed) areas to be continued (#9635) 2025-02-12 15:13:26 +01:00
Kyℓe Hensel
4747ae253c refactor isOneWay to properly support bidirectional ways (#10730) 2025-02-12 14:22:09 +01:00
Kyℓe Hensel
6328776df1 Fix + symbol appearing in changeset comments from external tools (#10766) 2025-02-12 14:13:15 +01:00
Martin Raifer
f3a985f78b ways with more than 2000 nodes: prevent lockup and provide validator-fix (#8808)
* add validation & fix for way vertices limit imposed by OSM API (try to choose splitting locations at existing intersection vertices if possible)
* fix splitting of closed ways at two or more nodes:
  this bug resulted sometimes in one extra split point in the result, or one of the split  vertices to be left unsplit
2025-02-11 20:08:38 +01:00
Martin Raifer
121f3e2fb8 don't reauthenticate on HTTP 400 errors
since these are likely unrelated to authentication issues, but rather have to do with generic API errors or outages
2025-02-11 16:29:01 +01:00
Deeptanshu Sankhwar
f7fc707159 Show both lat/lon and lon/lat when searching coordinates (#10725) 2025-02-11 12:50:07 +01:00
Martin Raifer
9e110cfda4 make background map tile edges opaque
Replaces the workaround of the tile rendering issues on Chrome at odd zoom levels.

The svg filter `#alpha-slope5` alters the alpha channel of background tiles such that everything but (almost) transparent pixels are rendered fully opaque.

closes #10747
2025-02-10 13:50:23 +01:00
Martin Raifer
ac3fe661d0 preserve imagery offset during tile layer transition, fixes #10748 2025-02-09 19:40:06 +01:00
dragoon
6575296a85 Use distinct placeholder text for feature type search box (#10734) 2025-02-05 15:31:41 +01:00
Kyle Hensel
f244e63661 validate crossing aeroways (#9315) 2025-02-05 14:42:32 +01:00
Kyℓe Hensel
a2e347ac97 prevent degenerate ways caused by deleting a corner of a triangle (#10003) 2025-02-05 14:38:03 +01:00
Youssef Ahmed Hassan Elzedy
afd6b83edf change icon to "X" for the exit button of feature type selection panel (#10733) 2025-02-05 14:19:18 +01:00
burrscurr
55f5a96a42 handle key values that should not be reversed together 2025-02-05 12:57:29 +01:00
burrscurr
841991055c don't change direction of red_turn when way is reversed
Fixes #10736
2025-02-05 12:57:00 +01:00
Kyℓe Hensel
2c0f8a4b5f handle cycleway:both=* (#9587)
this works for any `directionalCombo` field, including `sidewalk:both`
2025-02-05 10:41:48 +01:00
Avan2021
f44702e0b5 add oneway to list of attribute-only tag (#10706) 2025-02-04 11:00:51 +01:00
Martin Raifer
51ee85f6f5 refresh text-mode raw tag editor also when no tags are changed
e.g. when duplicate tag keys are entered or the text input contained empty or invalid lines that need to be cleaned up
2025-01-31 17:34:42 +01:00