Thomas Hervey
4038c8200e
added note section to help docs
2018-07-22 00:05:15 -04:00
Bryan Housel
8811933009
Split up loadTiles and loadNotes code
...
Code is similar but different enough that I'd rather have 2 separate
functions rather than a single function with a bunch of ifs
2018-07-21 22:31:04 -04:00
Bryan Housel
7be9439c35
Use geoScaleToZoom to calculate zoom in Mapillary, OpenStreetCam
2018-07-21 21:59:35 -04:00
Bryan Housel
c0b77d8226
remove unneeded dimensions argument (projection clipExtent has it)
2018-07-21 21:44:14 -04:00
Bryan Housel
cd3d576276
rename geoTile -> tiler
2018-07-21 21:27:44 -04:00
Bryan Housel
292347b28a
Use utilTiler's Null Island filter for overlay sources
2018-07-21 18:53:19 -04:00
Bryan Housel
f6e41a1cb8
Remove unused zoomDelta parameter
2018-07-21 18:52:54 -04:00
Bryan Housel
02713e48fb
Move cache management out of tiler, it's responsibilty of service
...
Also remove some unused code and eslint warnings
2018-07-21 11:11:39 -04:00
Bryan Housel
ff64455370
rename the file too
2018-07-21 10:12:11 -04:00
Bryan Housel
d1fe81b905
rename utilTile -> utilTiler
2018-07-21 10:07:56 -04:00
Bryan Housel
e4d829ec06
Have the tiler return filtered results - re: skipNullIsland
2018-07-21 10:03:40 -04:00
Bryan Housel
3f10b15ee8
Merge pull request #5148 from openstreetmap/refactor-loadTiles
...
moved getTiles and filtering to utils
2018-07-19 21:24:46 -04:00
Thomas Hervey
386d375b7a
fix excessive note tiling and network request
2018-07-19 10:51:39 -04:00
Bryan Housel
1b7493081e
Show linkified text in notes, hide scrollbars when hovering
...
(closes #5151 )
2018-07-18 16:16:34 -04:00
Thomas Hervey
c563abaf7a
pass dimensions to tile
2018-07-18 15:49:04 -04:00
Thomas Hervey
60f66b73e9
fixed missing declarations. TODO: fix tests
2018-07-18 15:16:52 -04:00
Thomas Hervey
5bf3f7ed3e
Merge branch 'master' into refactor-loadTiles
2018-07-18 07:26:56 -04:00
Bryan Housel
ae4c742851
Merge pull request #5155 from openstreetmap/fix-note-date
...
fix browser-specific Date() issues in notes
2018-07-17 22:43:31 -04:00
Bryan Housel
7737c571aa
Shrink the photo viewer if the map has been resized to be smaller
2018-07-17 17:47:05 -04:00
Bryan Housel
e221dcae58
Dispatch new dimensions with photoview resize, resize all layers
...
-Adds ability to resize OpenStreetCam and Bing Streetside layers
-Also slightly increases the width of the resize handles
-Also limits max resize so it won't go larger than the map
2018-07-17 17:06:59 -04:00
Thomas Hervey
b0ba681538
fix browser-specific Date() issues in notes
2018-07-17 16:07:47 -04:00
Bryan Housel
b9a6996048
Merge branch 'feat-photoviewer-resize' of https://github.com/mapillary/iD into mapillary-feat-photoviewer-resize
2018-07-17 12:38:52 -04:00
Bryan Housel
fa6e195c2d
Add user info, require authentication to edit a note
2018-07-17 00:55:43 -04:00
Bryan Housel
73d0f30453
Merge branch 'notes'
2018-07-16 16:59:35 -04:00
Bryan Housel
694cc60893
Add thread dots to note header icon, disable comments on closed nodes
2018-07-16 16:53:45 -04:00
Bryan Housel
70f87632c7
Cleaner note icon rendering
...
Before: We drew 2 fontawesome comment icons, on on top of the other
After: Moved icon into iD spritesheet and gave it an actual `stroke` property that can be styled
2018-07-16 13:18:38 -04:00
Thomas Hervey
7ad765d408
added simple tests for loading and retrieving notes
2018-07-16 10:54:40 -04:00
Thomas Hervey
d4b1622667
moved getTiles and filtering to utils
2018-07-14 19:15:25 -04:00
Thomas Hervey
7fb42ac9d6
added note reporting and margin to save buttons
2018-07-13 17:09:51 -04:00
Bryan Housel
1a106f5253
Make uiViewOnOSM work for notes too, add it to note_editor footer
2018-07-13 15:55:58 -04:00
Bryan Housel
33ef9a4357
Wrap callbacks with common checks for connection id and auth failure
...
This eliminates a lot of the copy-paste code in every callback.
2018-07-13 15:14:20 -04:00
Thomas Hervey
bd1586500e
added tests for notes service
2018-07-13 15:01:43 -04:00
Matias Volpe
0ea0749135
Add minimum resize height/width
2018-07-13 09:16:36 -03:00
Bryan Housel
f825845b79
Can't skip seen on the userDetails call
...
This call really does need for a result to be passed to the callback
2018-07-13 00:31:04 -04:00
Bryan Housel
8a1079c3c6
Update notes on status change
2018-07-13 00:15:30 -04:00
Bryan Housel
775b47272d
Remove from inflight cache before doing anything in done
2018-07-12 23:56:03 -04:00
Bryan Housel
57da729837
Implement note save button code
2018-07-12 23:50:29 -04:00
Bryan Housel
645cc790a3
Add docs about OSM API, finish implementing postNoteUpdate
...
`postNoteUpdate` can hangle status changes and comment additions
(I named it that to be like `putChangeset`)
Also renamed `user` to `loadUser` to be consistent with other calls
2018-07-12 23:46:07 -04:00
Matias Volpe
b617695ad1
Remove OSM iD custom photo attribution to show MJS photo attribution
2018-07-12 17:59:56 -03:00
Bryan Housel
19560ebc90
Properly save and restore caches when entering/leaving the walkthrough
2018-07-12 15:39:04 -04:00
Matias Volpe
836517a9fe
Add ability to resize to PhotoViewer
2018-07-12 09:41:10 -03:00
Bryan Housel
fe7086f753
Add header close 'X' button, add grey hover styling
2018-07-12 02:51:49 -04:00
Bryan Housel
5e5601f555
Store the unsaved comment in the note itself
2018-07-12 02:09:24 -04:00
Bryan Housel
91add0c33e
WIP on buttons, simplify, remove some event dispatch
...
- I made the buttons work like GitHub comment-on-issue buttons
before typing: "Close Note" / "Comment" (disabled)
after typing: "Close and Comment" / "Comment" (enabled)
- I removed a bunch of the event dispatches. These are useful for sending
events to listeners/observers outside of the module. In this case I think
we can handle most of the things from within the uiNoteEditor. We can still
dispatch an 'update' event so that modeSelectNote can reselect and redraw
the note after some change happens to it.
TODO - make the buttons work / check the OSM API stuff.
2018-07-11 23:10:01 -04:00
Bryan Housel
3454753bf6
Drop more/less toggle and just use a scrollbar for long comments
2018-07-11 16:00:54 -04:00
Bryan Housel
e9e2f9ba8f
Style note header
2018-07-11 15:41:43 -04:00
Bryan Housel
f52f24b517
Add noteOptions, default to 10k note limit and 7 days closed
...
Also bump note tile zoom to z12. There just aren't that many notes,
so this reduces API calls.
2018-07-10 23:28:37 -04:00
Bryan Housel
7423d192d4
Implement multi-fetch get for users from OSM API
...
Eagerly load user details after loading notes
(re: openstreetmap/openstreetmap-website#1921 )
2018-07-10 23:02:37 -04:00
Bryan Housel
0d7c292c23
Refactor out uiNoteHeader and uiNoteComments into separate modules
...
uiNoteEditor was getting big!
2018-07-10 21:45:02 -04:00
Bryan Housel
369877bcb2
Refine css for footway=crossing and other special paths
...
(closes #5126 )
2018-07-10 15:47:07 -04:00
