CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-02-14 01:33:03 +00:00
Code Issues Packages Projects Releases Wiki Activity
10,195 Commits 2 Branches 0 Tags
45ce4e4c5783a5290a2a7c92d1c26128720249cb
Commit Graph

10195 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
SilentSpike
45ce4e4c57 Move turn restriction error position slightly 2019-02-01 22:51:02 +00:00
SilentSpike
ee5f9f3bf2 Use consistent short service name 2019-02-01 22:51:02 +00:00
SilentSpike
54e02ec28d Introduce new container icon for errors 
As per my last commit, this icon differentiates errors from points and
still allows us to specifiy icons for errors to differentiate them amongst
eachother.

I learned quite a bit about SVGs and using them in HTML while
implementing this 😝Had some issues getting the icon to center in the
header so resorted to using a flexbox instead of absolute positioning
being used elsewhere.
 2019-02-01 22:51:02 +00:00
SilentSpike
5d907c1e16 Render errors like points with icons 
This allows more diverse representation of the error subject at a glance
than relying on colour alone.

However, it would be good to have a generic error icon that can contain
icons which is differentiated from the point icon for clarity.

Sidebar header currently still uses the bolt icon until I figure out
how to deal with that. Also the font awesome icons don't seem to work,
perhaps there's additional code needed for those that I've missed.
 2019-02-01 22:51:01 +00:00
SilentSpike
4a166d7a5b Use more descriptive key names 2019-02-01 22:51:01 +00:00
SilentSpike
88a59cb15f Stop hijacking the inflight cache 
This could result in error updates getting aborted when new errors are
loaded as their individual ids are never going to match tile IDs (see
`abortUnwantedRequests` function).
 2019-02-01 22:51:01 +00:00
SilentSpike
f6746a28ff Match error red to road sign red 2019-02-01 22:51:00 +00:00
SilentSpike
6483c54ca4 Update ImproveOSM error colouring 
Fix similar orange colours by using the same zoomed in colours as
ImproveOSM for missing geometry (i.e. pink for roads).

This frees up red for turn restrictions (as they are typically signed in
red) and therefore blue for one-ways (as they tend to be signed blue or
black).
 2019-02-01 22:51:00 +00:00
SilentSpike
fe73b3df5a Improve error icon position and appearance 2019-02-01 22:51:00 +00:00
SilentSpike
5030346257 Update data layers test 2019-02-01 22:51:00 +00:00
SilentSpike
3334abf776 Remove some unnecessary code 2019-02-01 22:51:00 +00:00
SilentSpike
31091f1159 Add direction of travel to oneway errors 2019-02-01 22:50:59 +00:00
SilentSpike
6bdd0cfa89 Fix missing semicolons 2019-02-01 22:50:58 +00:00
SilentSpike
3174db76b7 Fix north direction in some error descriptions 2019-02-01 22:50:58 +00:00
SilentSpike
9d2792836f Add ImproveOSM error resolution 2019-02-01 22:50:58 +00:00
SilentSpike
ac4cec1429 Add sidebar preview for ImproveOSM errors 2019-02-01 22:50:57 +00:00
SilentSpike
214cf41019 Use more generic classes for errors 2019-02-01 22:50:57 +00:00
SilentSpike
39880e559b Add direction of travel to turn restriction errors 2019-02-01 22:50:56 +00:00
SilentSpike
9600d67fc6 Differentiate missing geometry errors by colour 2019-02-01 22:50:56 +00:00
SilentSpike
bea6f4dcfd Use point averages for locations 2019-02-01 22:50:56 +00:00
SilentSpike
ca290b5101 Add details to error messages 2019-02-01 22:50:55 +00:00
SilentSpike
23a4d71410 Handle turn restriction errors 2019-02-01 22:50:55 +00:00
SilentSpike
4f2646d567 Add basic title + description UI 2019-02-01 22:50:54 +00:00
SilentSpike
4d89810721 Add ImproveOSM service 
Only processing one-way errors for now
 2019-02-01 22:50:54 +00:00
Bryan Housel
9d8a0b7843 Merge pull request #5836 from openstreetmap/5829 
do not close image viewer if street level imagery layers are still rendered
 2019-02-01 16:42:31 -05:00
Bryan Housel
491ec40435 Ditch the separate linear platform presets for public transport 
(closes #5837)
 2019-02-01 16:42:52 -05:00
Bryan Housel
e50b82d2ad Ditch the separate linear platform presets for public transport 
(closes #5837)
 2019-02-01 16:38:33 -05:00
Bryan Housel
f79d3d1d9f Change color of groyne, breakwater, dam, weir 
(closes #5759)

Now rendered in grey instead of blue waterway color
 2019-02-01 14:28:31 -05:00
Bryan Housel
df093b25fe Only add the documentation bottom padding when expanded 2019-02-01 14:02:36 -05:00
Max Grossman
7f837c7e0c no need to generate service variable 
ref #5929
 2019-02-01 14:01:17 -05:00
Max Grossman
ec1a42ad39 clean up & remove hideViewer for openstreetcam 
ref #5829
 2019-02-01 13:59:04 -05:00
Max Grossman
d894521143 just don't close viewer... 
ref #5829
 2019-02-01 13:55:10 -05:00
Bryan Housel
b75b7c567d Increase padding slightly between tag refrence and following element 2019-02-01 13:35:37 -05:00
Max Grossman
ce8d16a220 initial commit...hide parts, not entire viewer 
ref #5829
 2019-02-01 11:49:30 -05:00
Bryan Housel
d1fca87d79 Replace Edit Documentation link with pencil icon 
(closes #5753)
 2019-02-01 11:49:03 -05:00
Bryan Housel
bde55bd7ee Update presets for new community index 2019-02-01 11:02:42 -05:00
Bryan Housel
fc7fcd1e29 Merge pull request #5834 from SilentSpike/editorconfig 
Add .editorconfig file
 2019-01-30 17:25:45 -05:00
SilentSpike
9efcb60960 Add .json to .editorconfig 2019-01-30 22:22:17 +00:00
SilentSpike
1a66435b35 Add .editorconfig file 2019-01-30 21:47:17 +00:00
Bryan Housel
09f7f9189f Fix field tests to run with minimal set of presets 2019-01-30 16:29:27 -05:00
Bryan Housel
71b2d2c6b7 Upgrade legacy symbols in tests 
- iD.Context -> iD.coreContext
- iD.Graph -> iD.coreGraph
- iD.Node -> iD.osmNode
- iD.Way -> iD.osmWay
- iD.Relation -> iD.osmRelation
 2019-01-30 15:43:02 -05:00
Bryan Housel
7138acc652 Properly export areaKeys, fix preset and maprules tests 2019-01-30 15:29:37 -05:00
Bryan Housel
15c0b82eb2 First attempt to run tests with minimal preset config 2019-01-30 10:25:40 -05:00
Bryan Housel
17bbc3d5a2 Slightly improve suggestion placement, preset search performance 
- avoid lodash _filter when native filter is ok for arrays
- for suggestions use `originalName` instead of adding/removing the en-dash
- bump up importance of leading suggestions, but do a strict leading search

more on that last point:
For normal presets, we count a string as leading if it follows a space.
e.g. "office" will match "Law Office"
We don't really want this for suggestion presets though
e.g. "bell" should not match "Taco Bell"
 2019-01-29 21:56:23 -05:00
Bryan Housel
a4eab24117 Merge pull request #5744 from SilentSpike/javascript-eol 
Update .gitattributes to use lf eol for .js files
 2019-01-29 15:14:20 -05:00
Bryan Housel
7e3f08b31a Restore missing paths_intersect string needed for #5745 2019-01-29 15:09:49 -05:00
Bryan Housel
7aea67fcfe Merge pull request #5745 from jguthrie100/stop_merge_overlapping_self 
Add check to stop joining ways if resulting way intersects itself
 2019-01-29 14:07:34 -05:00
Bryan Housel
0f41913b04 pacify eslint 2019-01-29 14:04:36 -05:00
Bryan Housel
a2212a732b Merge pull request #5816 from SilentSpike/mapillary-icon 
Fix street imagery hover and selection behaviour
 2019-01-29 13:59:28 -05:00
Bryan Housel
ad3f491116 Replace maki "M" museum icon 
(closes #5751)
 2019-01-29 13:51:34 -05:00