Commit Graph

1658 Commits

Author SHA1 Message Date
Bryan Housel 8a1079c3c6 Update notes on status change 2018-07-13 00:15:30 -04:00
Bryan Housel 775b47272d Remove from inflight cache before doing anything in done 2018-07-12 23:56:03 -04:00
Bryan Housel 57da729837 Implement note save button code 2018-07-12 23:50:29 -04:00
Bryan Housel 645cc790a3 Add docs about OSM API, finish implementing postNoteUpdate
`postNoteUpdate` can hangle status changes and comment additions
(I named it that to be like `putChangeset`)

Also renamed `user` to `loadUser` to be consistent with other calls
2018-07-12 23:46:07 -04:00
Matias Volpe b617695ad1 Remove OSM iD custom photo attribution to show MJS photo attribution 2018-07-12 17:59:56 -03:00
Bryan Housel 19560ebc90 Properly save and restore caches when entering/leaving the walkthrough 2018-07-12 15:39:04 -04:00
Matias Volpe 836517a9fe Add ability to resize to PhotoViewer 2018-07-12 09:41:10 -03:00
Bryan Housel fe7086f753 Add header close 'X' button, add grey hover styling 2018-07-12 02:51:49 -04:00
Bryan Housel 5e5601f555 Store the unsaved comment in the note itself 2018-07-12 02:09:24 -04:00
Bryan Housel 91add0c33e WIP on buttons, simplify, remove some event dispatch
- I made the buttons work like GitHub comment-on-issue buttons
before typing:  "Close Note" / "Comment" (disabled)
after typing:   "Close and Comment" / "Comment" (enabled)

- I removed a bunch of the event dispatches.  These are useful for sending
events to listeners/observers outside of the module.  In this case I think
we can handle most of the things from within the uiNoteEditor.  We can still
dispatch an 'update' event so that modeSelectNote can reselect and redraw
the note after some change happens to it.

TODO - make the buttons work / check the OSM API stuff.
2018-07-11 23:10:01 -04:00
Bryan Housel 3454753bf6 Drop more/less toggle and just use a scrollbar for long comments 2018-07-11 16:00:54 -04:00
Bryan Housel e9e2f9ba8f Style note header 2018-07-11 15:41:43 -04:00
Bryan Housel f52f24b517 Add noteOptions, default to 10k note limit and 7 days closed
Also bump note tile zoom to z12. There just aren't that many notes,
so this reduces API calls.
2018-07-10 23:28:37 -04:00
Bryan Housel 7423d192d4 Implement multi-fetch get for users from OSM API
Eagerly load user details after loading notes
(re: openstreetmap/openstreetmap-website#1921)
2018-07-10 23:02:37 -04:00
Bryan Housel 0d7c292c23 Refactor out uiNoteHeader and uiNoteComments into separate modules
uiNoteEditor was getting big!
2018-07-10 21:45:02 -04:00
Bryan Housel 369877bcb2 Refine css for footway=crossing and other special paths
(closes #5126)
2018-07-10 15:47:07 -04:00
Thomas Hervey eafae6c58c WIP: update service calls; todo: note update event handling 2018-07-10 13:50:36 -04:00
Bryan Housel cd7cdd95e9 Add "View on Bing Maps" link, cleanup css
(closes #5125)
2018-07-10 02:04:39 -04:00
Bryan Housel 696895fb98 Add forward/backward controls to Streetside viewer
re: #5125

There is some cleverness here to search for the best nearby bubble
instead of just relying on the next and previous sequence keys.
2018-07-10 01:10:18 -04:00
Bryan Housel cf3fc95b06 A few changes to make it easier to render arbitrary geojson 2018-07-10 01:10:17 -04:00
Bryan Housel 1395e029d9 Add guard code for if Mapillary viewer could not be initialized 2018-07-09 16:17:09 -04:00
Bryan Housel 9c275d58b5 Comment out .mvt data layer for now 2018-07-09 14:36:16 -04:00
Bryan Housel 69e83099a5 Fix icon names in map_data panel 2018-07-09 14:31:20 -04:00
Bryan Housel 99e7366fc2 swap d3_fetch for d3_request (for backward compatability with IE11) 2018-07-09 14:30:51 -04:00
Bryan Housel a52eeb9733 Fix failing tests, lint errors, merge conflicts 2018-07-09 11:17:57 -04:00
Thomas Hervey c460c03da5 fixed typo 2018-07-09 10:11:50 -04:00
Bryan Housel 4fda478f57 Merge branch 'check' of https://github.com/vershwal/iD into vershwal-check 2018-07-09 09:32:15 -04:00
Thomas Hervey 14356cefe2 WIP: toggle note status 2018-07-08 12:50:02 -05:00
Thomas Hervey 0f49514fbb updated: removed centering when clicking a note 2018-07-08 10:27:44 -05:00
Bryan Housel de12396654 Fix projection so the map is where the point is
Also remove gj redundancy
2018-07-08 00:50:26 -04:00
Bryan Housel 7b42743513 pacify some eslint warnings 2018-07-07 23:00:48 -04:00
Bryan Housel 3eb3eefabd Combine Osm and Notes layers into the same ul 2018-07-07 22:54:27 -04:00
Bryan Housel d137aa0046 Add "More/Less" toggle for too long comments (curr limit 600 chars) 2018-07-07 00:25:42 -04:00
Jon D 3bad09d497 Merge Work-In-Progress 4320 to 4320 2018-07-06 22:20:19 +01:00
Bryan Housel 01b33e3fb7 Linkify the usernames 2018-07-06 11:28:01 -04:00
Bryan Housel 263ec9e36a Add code to swap in avatar images for users that have them 2018-07-05 18:42:42 -04:00
Bryan Housel 416ae66f71 Support more direction tags for reversal in Reverse action
(closes #5121)

This commit also refactors some of the logic to make it simpler and more efficient
(removes lodash _transform too) and updates the comment that was out of date.
2018-07-05 14:47:56 -04:00
Tom Hughes 3819fd6498 Use XHR to access wikidata API instead of JSONP 2018-07-04 17:05:39 +01:00
Tom Hughes 1ab7cf790e Use XHR to access wikipedia API instead of JSONP 2018-07-04 17:05:26 +01:00
Tom Hughes 4cc080b034 Use XHR to fetch imagery metadata instead of JSONP 2018-07-04 17:00:45 +01:00
Bryan Housel 6f1dc12f99 Add user method to osm service, _userCache, user parser 2018-07-04 03:20:16 -04:00
Thomas Hervey 73ee5c2fc9 fixed select_note mode, cleaned note_editor, TODO: enable note save 2018-07-03 22:45:51 -04:00
Bryan Housel bf499d9438 Restore modeSelect, and make a new modeSelectNote just for the notes 2018-07-03 18:11:59 -04:00
Bryan Housel b14d1b5061 resolve conflicts, fix a few minor bugs prob caused by merging:
- don't insert multiple times into the rtree in `services/osm.js`
- use `d.id` instead of `d.key` as the key in `svg/notes.js`
2018-07-03 16:40:07 -04:00
Thomas Hervey 8121f585d5 added checks for multiclick and click on notes 2018-07-03 15:39:22 -04:00
Thomas Hervey 61ae541cfc updated: notes save buttons 2018-07-03 10:57:53 -04:00
Bryan Housel ab8e793a72 Playing with note styling, add avatars and more metadata 2018-07-03 02:41:47 -04:00
Bryan Housel e0cc6260f5 Switch innerHtml to textContent, which properly unescapes xml
This commit also fixes a linter error, and switches some
lodash _forEach to normal for loops.
2018-07-02 23:22:00 -04:00
Bryan Housel 2d2845e5d4 If notes are coincident, move them apart slightly 2018-07-02 16:56:05 -04:00
Thomas Hervey bd8705bf85 updated: reintroduced hovering on notes 2018-07-02 16:32:17 -04:00