Commit Graph

221 Commits

Author SHA1 Message Date
Bryan Housel
2e6799ac60 Don't reverse cardinal direction roles on relations anymore
re: https://github.com/openstreetmap/iD/pull/2004#issuecomment-407995998

Per thread https://twitter.com/bhousel/status/1025805098063208448
JOSM has stopped doing this too
2018-08-04 21:55:14 -04:00
Bryan Housel
119792fd22 Cleanups to Detach Node feature
This commit includes a bunch of minor things:
- change keyboard shortcut to 'E' to not conflict with anything
- move `disabled` check from operation into action and simplify
- use `actionMoveNode` to place the detached node at the mouse cursor
- disable the operation if the node is connected to hidden features
- lots of code simplification
- make the icon more centered
2018-07-23 13:36:34 -04:00
Bryan Housel
94b0affe8c Merge branch '4320' of https://github.com/Psigio/iD into Psigio-4320 2018-07-23 08:44:19 -04:00
Jon D
90bc0b8537 Update to prevent detachment of node when either a via or
location_hint role in a turn restriction.
Update to move any other relation to new node.
2018-07-22 19:35:29 +01:00
Jon D
3bad09d497 Merge Work-In-Progress 4320 to 4320 2018-07-06 22:20:19 +01:00
Bryan Housel
416ae66f71 Support more direction tags for reversal in Reverse action
(closes #5121)

This commit also refactors some of the logic to make it simpler and more efficient
(removes lodash _transform too) and updates the comment that was out of date.
2018-07-05 14:47:56 -04:00
Bryan Housel
6ed20d7762 actionMergeNodes can just use actionConnect 2018-04-25 22:26:34 -04:00
Bryan Housel
2909162158 Rename merge_way_nodes to merge_nodes, update tests 2018-04-25 20:57:40 -04:00
Bryan Housel
9bf4799b56 Merge branch 'merge-way-nodes-feature' of https://github.com/ferdibiflator/iD into ferdibiflator-merge-way-nodes-feature 2018-04-25 16:19:32 -04:00
Bryan Housel
00e5e8efa0 Avoid reversing osmWays in order to "prefer a forward path"
(closes #4872, related #4859)
2018-04-18 23:43:19 -04:00
Bryan Housel
ce77538185 Allow connecting FROM nodes to TO nodes if it's a u-turn 2018-04-16 08:00:44 -04:00
Bryan Housel
b2df343f2d Allow connecting to nodes in the turn restriction from outside 2018-04-14 23:12:19 -04:00
Bryan Housel
87841fc403 Stricter checks to prevent turn restriction breakage when dragging
(re: #4921)
2018-04-13 22:50:51 -04:00
Bryan Housel
8fb083578f Prevent drag/connect which could damage relations
(closes #4921)
2018-04-12 17:32:16 -04:00
Bryan Housel
b09c712fc5 When connecting nodes, prefer to keep an existing (not new) node
(closes #4974, closes #4674)
2018-04-09 14:20:40 -04:00
Bryan Housel
734957f283 Handle variants of 'stop' and 'platform' when identifying PTv2 members
(closes #4946)
2018-03-27 21:52:52 -04:00
Bryan Housel
f8bbb995ac Properly split ways which are members of a via way turn restriction
(closes #4861)
2018-03-10 15:20:20 -05:00
Bryan Housel
aa1565baf8 Avoid reordering stops and platforms in PTv2 routes
(closes #4864)
2018-03-10 00:12:46 -05:00
Bryan Housel
4b1f8a8f61 Merge pull request #4768 from openstreetmap/advanced_intersection
Add support for complex intersection and via way restrictions
2018-03-01 01:46:30 -05:00
Bryan Housel
241159b547 Cleanup docs and tests for actionRestrictTurn / actionUnrestrictTurn
- actionRestrictTurn will no longer "infer" the turn type
- restrictionType *must* be passed in - this is ok because the only code
  we use this action (restrictions.js) already has inferred the type
- this simplifies what the action actually does
- moved the tests from restrict_turn.js that were really just testing
  the restriction type inferrence over to intersection.js
  (and added a few more tests for iD.osmInferRestriction)
2018-02-28 23:55:59 -05:00
Bryan Housel
0cbff57dc9 Cycle through only_ turn restriction states
(re: #2622)
2018-02-07 19:04:28 -05:00
Bryan Housel
dac753c4ea Speedup hot code in actionDiscardTags
(re: #4611)
2018-02-04 14:57:26 -05:00
Bryan Housel
c1378a141f Add support for complex intersection and via way restrictions 2018-02-02 19:58:09 -05:00
Bryan Housel
7c918ba161 Allow Relation.replaceMember to optionally preserve duplicates
(closes #4696)
2018-01-18 16:52:23 -05:00
Bryan Housel
be9bbd9271 Add tests for member ordering: node, way, relation 2018-01-18 15:21:38 -05:00
Bryan Housel
d6afd399fc Revised and expanded actionSplit tests to cover route splitting 2018-01-18 14:34:34 -05:00
Bryan Housel
3be577d8db However we fix actionAddMember, it needs to work for incomplete relations 2018-01-16 21:37:43 -05:00
Bryan Housel
be46e85ec0 Move insert way pairing code from osmJoinWays to actionAddMember
(tests for actionAddMember now passing!)
2018-01-16 17:41:14 -05:00
Bryan Housel
221158e918 WIP: Add insertHint to actionAddMember, actionSplit 2018-01-15 23:13:59 -05:00
Bryan Housel
03fa6e7be9 Add tryInsert option to osmJoinWays 2018-01-15 22:02:43 -05:00
Bryan Housel
075b85c81d Apply reversal actions in actionJoin
(closes #4688)
2018-01-14 14:49:57 -05:00
Bryan Housel
8f6cb207fc Much expanded tests for osmJoinWays 2018-01-11 21:42:29 -05:00
Bryan Housel
07262fa711 Add tests for #4589 2018-01-09 23:57:44 -05:00
Bryan Housel
748abdb950 Code formatting 2018-01-09 17:46:15 -05:00
Nikita Mashukov
92451e7b4b Merge branch 'master' into merge-way-nodes-feature 2018-01-01 22:09:54 +07:00
Bryan Housel
96afbbd785 Refactor vector math functions from geo.js to vector.js 2017-12-28 01:08:11 -05:00
Bryan Housel
117ad7d6b6 Transitionable actionMoveNode 2017-12-22 16:57:27 -05:00
Bryan Housel
6cfe7a2e71 When reversing a way, reverse traffic_signals:direction on child nodes
(closes #4595)
2017-12-06 20:48:21 -05:00
Nikita Mashukov
92374f7af9 tests for merge_way_nodes action 2017-10-30 22:32:48 +07:00
Bryan Housel
b3842d97f4 Remove lodash from the test suite
(closes #4378)
2017-10-18 14:37:39 -04:00
Bryan Housel
01bfc67ea5 After splitting a way, update all matching relation members
(closes #4140)
2017-07-10 18:35:30 -04:00
Bryan Housel
8ce6b9e185 Merge branch 'transitioned-actions' 2017-01-04 17:26:22 -05:00
Bryan Housel
c2713c3a3f For node-way merge, preserve original node if possible
(closes #3683)
2016-12-31 02:01:13 -05:00
Bryan Housel
ef96fde38a Add tests for transitioned orthogonalize action 2016-12-23 16:37:17 -05:00
Bryan Housel
5dde5aeded Add tests for transitioned circularize action 2016-12-23 16:14:49 -05:00
Bryan Housel
f9c09c0648 Add tests for transitioned reflect action 2016-12-23 15:05:51 -05:00
Bryan Housel
723f0ca43a Add tests for transitioned straighten action 2016-12-23 14:58:18 -05:00
Bryan Housel
37534aed0e More cleanup of operations and post-paste behavior
* Support move, rotate, reflect, delete post paste on multiselection
* Improve text and error msgs for singular vs multi selections
* Move `disabled` checks from actions to operations
* Reproject center of rotation (closes #3667)
* Cleanup tests
2016-12-21 23:58:13 -05:00
Bryan Housel
2267035dfb Support both reflect long axis and reflect short axis operations 2016-12-16 13:59:33 -05:00
Bryan Housel
5a6045fd3d Merge branch 'master' into Psigio-3375 2016-12-14 11:30:53 -05:00