Commit Graph

9897 Commits

Author SHA1 Message Date
Bryan Housel 48cc06fdbb Adjust distance from KeepRight marker and underlying geometry
Makes it easier to select the point/vertex that the error is about.
2019-01-04 21:28:35 -05:00
Bryan Housel fadd8e2e8a Switch KeepRight markers to use touch targets
This makes it easier to select the KeepRight issue and avoid selecting
the OSM geometry underneath them
2019-01-04 21:17:38 -05:00
Bryan Housel 0582faff1d Convert KeepRight error 73 to regex
(re: https://github.com/openstreetmap/iD/pull/5201#discussion_r245349395 )
2019-01-04 20:27:22 -05:00
Bryan Housel cd9203975d Use touch targets for notes, fix a few bugs with note dragging
(closes #5213)
2019-01-04 15:48:39 -05:00
Bryan Housel 67403a2141 Style missing tracktype like missing maxspeed 2019-01-03 21:39:16 -05:00
Bryan Housel 10ece546f4 Give missing maxspeed its own marker color style
There are a lot of these
2019-01-03 18:45:21 -05:00
Bryan Housel d0343c9fa7 Reintroduce some error localization, fix some nagging parse issues 2019-01-03 18:16:28 -05:00
Bryan Housel 35f8078f98 Reduce number of marker colors, increase contrast, tweak language 2019-01-03 15:30:36 -05:00
Bryan Housel 46ebce2d6f Fix error reporting urls and make sure sidebar not showing stale data 2019-01-03 11:37:14 -05:00
Bryan Housel 0256ad7f0d Remove redundant CSS 2019-01-03 10:04:53 -05:00
Bryan Housel 9e6497b549 Update or remove the error after POSTing changes to server 2019-01-03 01:39:40 -05:00
Bryan Housel 69ce5ee964 Remove user details and auth and adjust button texts for commenting
The user details and auth are not needed
because KeepRight accepts only anonymous updating
2019-01-03 00:07:55 -05:00
Bryan Housel ee92758801 KeepRight only allows one anonymous comment per issue - simplify 2019-01-02 16:15:21 -05:00
Bryan Housel 4494c3ab9c Fix comment box style, remove unused vars for eslint 2019-01-02 15:46:25 -05:00
Bryan Housel 9557c0204a Relax some more regex for tag parsing, (to support 'key=*')
Also implement parsing error 231 - layer conflict
2019-01-02 13:39:21 -05:00
Bryan Housel 2ec02f369f Simplify regex matching - goal is to have fewer, simpler rules 2019-01-02 11:46:13 -05:00
Bryan Housel d54d5bfd89 Move title into keepright error header 2018-12-29 17:55:40 -05:00
Bryan Housel 192b4da9e6 Fix the strings I broke in 3785ffb15 2018-12-29 17:30:35 -05:00
Bryan Housel 3785ffb154 Simplify translation strings 2018-12-22 12:12:28 -05:00
Bryan Housel f7150004c0 Refactor things out of util with limited use, move more to service 2018-12-21 11:56:55 -05:00
Bryan Housel 4eb0e4b3a4 Remove more duplicate strings 2018-12-20 16:09:18 -05:00
Bryan Housel 6e1d6bcfda Drop legacy translation keys 2018-12-20 15:38:04 -05:00
Bryan Housel 177537f0ce Move coincident markers away from related geometry and from each other 2018-12-20 15:23:53 -05:00
Bryan Housel 7f669d292f Simplify KeepRight tile fetching code 2018-12-20 14:40:14 -05:00
Bryan Housel ca2d4e2c34 Fix layer test 2018-12-19 17:31:55 -05:00
Bryan Housel 2deadd5d6c Fix merge issues 2018-12-19 17:12:06 -05:00
Thomas Hervey c501c44f60 updated: KeepRight description text 2018-12-19 13:45:35 -05:00
Thomas Hervey f4e71812ca added: help documentation 2018-12-19 13:45:35 -05:00
Thomas Hervey cedf6955b5 added: notes and todos for keepRight 2018-12-19 13:45:34 -05:00
Thomas Hervey ee00635cc4 updated: some error colors; fixed: error 320, 220 2018-12-19 13:45:15 -05:00
SilentSpike 1f7455fdad Add missing error types 73, 74 and 75 2018-12-19 13:45:15 -05:00
SilentSpike 9bd772748a Convert warnings to regex
These aren't shown in the layer currently, but for future use this
should work
2018-12-19 13:45:15 -05:00
SilentSpike da23bf79a8 Fix parsing of error type 294 2018-12-19 13:45:15 -05:00
SilentSpike 005927dae3 Fix parsing of error type 211 2018-12-19 13:45:15 -05:00
SilentSpike 2b1e37ab78 Handle simple error descriptions explicitly
This adds a flag to the error schema to explicitly say whether to parse
the description with regex or not. Prevents us from having to escape
special characters in fixed strings and is a minor optimisation.
2018-12-19 13:45:15 -05:00
SilentSpike e77d779173 Adhere to style guide for variables 2018-12-19 13:45:15 -05:00
SilentSpike e0e48b7505 Fix parsing of error type 231 2018-12-19 13:45:15 -05:00
SilentSpike a2fe431637 Add support for arbitrary number of details 2018-12-19 13:45:15 -05:00
SilentSpike d054e9cf6b Convert all error message schema to regex 2018-12-19 13:45:15 -05:00
SilentSpike 1527bbb043 Fix missing and unnecessary semicolons 2018-12-19 13:45:15 -05:00
SilentSpike 424bebf099 Convert preliminary amount of errors to regex
This focuses on converting error types I found on the map for testing
(can confirm the code is working!) as well as the more problematic cases
from the old code to show that this approach can handle them easily.
2018-12-19 13:45:15 -05:00
SilentSpike bb89827ee7 Use regex group capture to extract error details 2018-12-19 13:45:15 -05:00
Thomas Hervey fbe3c94b01 updated: punctuation, some specialized QA error parsing 2018-12-19 13:45:14 -05:00
Thomas Hervey 84895834f7 updated: punctuation and missing descriptions 2018-12-19 13:45:14 -05:00
Thomas Hervey 187d1add49 added: outline for KeepRight icon 2018-12-19 13:44:38 -05:00
Thomas Hervey d125c62c78 updated: variable and function names, html regex 2018-12-19 13:43:48 -05:00
Thomas Hervey ed34d522ff updated: check entity type from second word as well 2018-12-19 13:43:48 -05:00
Thomas Hervey e0d5391f1b added: entity links within descriptions 2018-12-19 13:43:48 -05:00
Thomas Hervey d095de08fe updated comment UI, added stub for POST; TODO: finish links & POST 2018-12-19 13:43:48 -05:00
Thomas Hervey b5a316df48 fixed: svg icon placement 2018-12-19 13:43:08 -05:00