Martin Raifer
fc75d5f2a1
fix another regression (in b72f3aa), add tests
2022-11-24 19:12:23 +01:00
Martin Raifer
21e54f956d
don't preserve preset's field tags if presets are sub-presets of each other
...
fixes #0372
2022-11-14 18:58:37 +01:00
Thomas Petillon
3ff06f9045
Fix relation handling on way split
...
Depending on which way is the longest, the new way is inserted into the
relation before the existing one. This case must be explicitly handled
for the relation to remain correct.
2021-12-06 21:25:23 +01:00
Thomas Petillon
21f171863c
Keep the oldest IDs alive when merging nodes into a way
2021-12-06 21:25:22 +01:00
Thomas Petillon
23b3bc27b6
Keep the oldest ID alive when merging polygons
2021-12-06 21:23:38 +01:00
Thomas Petillon
87ca2b09cc
Keep the oldest interesting ID alive when merging nodes
2021-12-06 21:23:38 +01:00
Thomas Petillon
e9c7436289
Use utilOldestID() when joining ways
2021-12-06 21:23:38 +01:00
Milos Brzakovic (E-Search)
68b5445689
testing infra improvement - disable silent errors
...
actions/join test fixed
2021-10-21 14:44:04 +02:00
Kyle Hensel
3f12dd5107
keep the oldest Way when merging
2021-10-01 10:31:21 +13:00
John Firebaugh
1457759994
Add support for connectivity relations
2021-09-08 20:30:38 -07:00
John Firebaugh
a14cf49710
Disable merge operation when it would damage relations
...
The operation is disabled when attempting to join ways which don't belong to identical sets of relations. Restriction relations are excluded, because they are already handled with slightly different logic.
Fixes #8674
Fixes #8645
Fixes #3825
Fixes #1512
2021-09-04 15:42:07 -07:00
Quincy Morgan
3f9ac9105b
Enable no-undef-init eslint rule
2020-10-23 11:33:47 -04:00
Quincy Morgan
4ddd4a358b
Deprecate vending=parcel_mail_in;parcel_pickup -> vending=parcel_pickup;parcel_mail_in ( close #7988 )
...
Enable upgrading of entire semicolon-delimited values
2020-09-28 16:07:11 -04:00
Quincy Morgan
5ddcfb0ced
Add parameter to specify which way should keep the history when splitting ways (re: #7795 )
...
Fix code tests
2020-09-14 11:27:20 -04:00
Peter Newman
4205ca1d07
Fix the seemingly safe spellings found by codespell
...
Untested, only checked by inspection.
(cherry picked from commit 2c47a11008 )
2020-08-10 17:32:37 +01:00
Bryan Housel
4d0ef1bafc
Export only the d3 functions we use in tests
...
(re: #4379 )
This trims a bit more off the iD bundle size
2020-02-22 15:07:09 -05:00
Bryan Housel
919687d2cf
Replace legacy names still used in tests, remove the legacy exports
2020-02-21 23:12:25 -05:00
Bryan Housel
3608659d21
Restore field inheritance
2020-02-10 16:22:13 -05:00
Bryan Housel
a333a341ec
Don't require areaKeys to be setup for actionSplit tests to pass
2020-02-04 15:45:11 -05:00
Bryan Housel
e19bcb77d5
Require init() call before coreContext starts doing things
...
(closes #7304 )
2020-01-29 19:27:12 -05:00
Bryan Housel
567eeac587
Make several data external instead of bundled:
...
Also dist/data/* contains minified files now
These are now external and will fetch as needed:
-export { dataAddressFormats } from './address-formats.json';
-export { dataDeprecated } from './deprecated.json';
-export { dataDiscarded } from './discarded.json';
-export { dataLanguages } from './languages.json';
-export { dataPhoneFormats } from './phone-formats.json';
-export { dataShortcuts } from './shortcuts.json';
-export { dataTerritoryLanguages } from './territory-languages.json';
2020-01-28 22:21:31 -05:00
Quincy Morgan
95a14ea722
Add unit test for single-member multipolygon collapse behavior exception for conflicting tags in actionJoin (re: f7d8c51bd3)
2019-11-21 12:54:59 -05:00
Quincy Morgan
4297b0d95b
Add unit test for single-member multipolygon collapse behavior in actionJoin (re: f7d8c51bd3)
2019-11-21 11:20:56 -05:00
Katarzyna Król
48ccc7900e
improve checking circularity and unit tests
2019-10-29 22:51:05 +01:00
Quincy Morgan
516570739c
Fix node reverse code test
...
Add more code tests for reversing nodes
2019-09-18 13:13:44 -04:00
Quincy Morgan
c229326aad
Allow using the Reverse operation on directional nodes ( close #6850 )
2019-09-17 10:57:55 -04:00
Quincy Morgan
14c0809426
Fix issue where cuisine -> diet upgrades could overwrite existing values ( close #6462 )
2019-05-31 08:25:29 -04:00
Quincy Morgan
0dfd0612b1
For ice rinks, prefer the "sport" values "ice_hockey" and "ice_skating" instead of "hockey" and "skating" since that latter are ambiguous
...
Don't remove other values when upgrading a tag value within a semicolon-delimited list
2019-05-23 15:39:15 -04:00
Bryan Housel
a72865e4d8
Treat anything with a from/via/to like a restriction
...
(closes #6221 )
Applies to actions like splitting, connecting, extracting a via node, etc
2019-04-29 21:58:10 -04:00
Bryan Housel
bd2490a965
Reverse internal left/right/forward/backward keyparts
...
(closes #6235 )
Previously only trailing keyparts would reverse:
`cycleway:left` ⟺ `cycleway:right`
Now it can do internal keyparts too:
`cycleway:left:surface` ⟺ `cycleway:right:surface`
2019-04-29 21:13:18 -04:00
Bryan Housel
05949608aa
Support straightening of points
...
(closes #6217 )
- Split `actionStraighten` into `actionStraightenWay` and `actionStraightenNodes`
- Now `operationStraighten` chooses the correct action depending on selected entities
- Also move `getSmallestSurroundingRectangle` from `actionReflect` to `geo.js`
2019-04-24 01:55:43 -04:00
Quincy Morgan
e04d860f62
Convert "Detach" operation into "Extract" operation that also works on areas ( close #6203 )
2019-04-22 14:46:01 -07:00
J Guthrie
bd44cec2e8
Fix broken testcase!
2019-04-08 16:48:27 +01:00
J Guthrie
57a0358061
Add test cases
2019-04-08 15:19:21 +01:00
J Guthrie
470d6c257d
Update to work on ways going in opposite directions
2019-03-22 15:29:48 -04:00
J Guthrie
5aecfcabc9
Update tests
2019-03-22 15:29:47 -04:00
Bryan Housel
c7e375cbd7
Preserve directionality of sided way when joining to non-sided ways
...
(closes #6033 )
2019-03-21 22:19:05 -04:00
Quincy Morgan
93df5d42d9
Flag and upgrade deprecated tags in a semicolon-delimited tag value ( close #6038 )
2019-03-11 10:22:28 -04:00
Bryan Housel
3f8911c149
Merge pull request #5999 from openstreetmap/squarish
...
Improve orthogonalization action
2019-03-01 23:28:23 -05:00
Bryan Housel
fab6bd1d33
Support orthogonalizing a single vertex, add tests
...
(closes #2205 )
2019-03-01 23:20:50 -05:00
Bryan Housel
e64693eea5
Upgrade tests from legacy iD.Difference to iD.coreDifference
2019-03-01 16:03:21 -05:00
Bryan Housel
cb51c16c8f
Expand actionOrthogonalize tests, fix abs issue in canOrthogonalize
2019-03-01 13:45:00 -05:00
Quincy Morgan
1f21b029fd
Move tag upgrade fix to an action and add unit tests
2019-02-26 10:42:12 -05:00
Bryan Housel
71b2d2c6b7
Upgrade legacy symbols in tests
...
- iD.Context -> iD.coreContext
- iD.Graph -> iD.coreGraph
- iD.Node -> iD.osmNode
- iD.Way -> iD.osmWay
- iD.Relation -> iD.osmRelation
2019-01-30 15:43:02 -05:00
J Guthrie
631ace27d5
Add check to stop joining ways if resulting way intersects itself
...
- Includes new test case
2019-01-22 03:07:38 +00:00
ockendenjo
cec442012a
Add test for route going round loop in other direction
2018-12-18 22:09:20 +00:00
ockendenjo
8aaa387d4e
Add tests for hat route splitting #4876
2018-12-18 21:39:35 +00:00
Bryan Housel
1ffca3ce85
Switch crossing presets to "marked"/"unmarked", retain "zebra" as unsearchable
2018-10-02 17:01:04 -04:00
Bryan Housel
2e6799ac60
Don't reverse cardinal direction roles on relations anymore
...
re: https://github.com/openstreetmap/iD/pull/2004#issuecomment-407995998
Per thread https://twitter.com/bhousel/status/1025805098063208448
JOSM has stopped doing this too
2018-08-04 21:55:14 -04:00
Bryan Housel
119792fd22
Cleanups to Detach Node feature
...
This commit includes a bunch of minor things:
- change keyboard shortcut to 'E' to not conflict with anything
- move `disabled` check from operation into action and simplify
- use `actionMoveNode` to place the detached node at the mouse cursor
- disable the operation if the node is connected to hidden features
- lots of code simplification
- make the icon more centered
2018-07-23 13:36:34 -04:00