Commit Graph

140 Commits

Author SHA1 Message Date
Ansis Brammanis
4e305ea773 don't permalink negative IDs (fixes #1374) 2013-04-25 11:16:56 -04:00
John Firebaugh
c50c3121d8 Make Graph#entity strict
Use Graph#hasEntity for the previous behavior.
2013-04-24 09:27:37 -07:00
John Firebaugh
71dda769f2 FF can't focus an SVG element 2013-04-12 11:24:25 -04:00
John Firebaugh
5dda54ea52 Refine focus behavior for inspector (fixes #1277)
Auto-focus the search field only right after finishing drawing.
At that point, the radial menu isn't shown anyway. So then the
flow for correcting geometry before assigning a preset is:

 1. Draw.
 2. Finish drawing. The search field is focused, and no
    radial menu is open.
 3. Click again to reselect the feature and show menu.
    Now the search field is blurred.

In other words: when the menu is shown, search should not be
focused. When search is focused, the menu should not be shown.
2013-04-12 10:08:44 -04:00
Ansis Brammanis
a8cf59e21c simplify 2013-04-05 13:31:08 -04:00
Ansis Brammanis
d7cc24b935 shadows for multipolygons 2013-04-05 12:11:23 -04:00
Ansis Brammanis
3ad94406cb fix multi-select regression 2013-04-02 16:54:08 -04:00
Ansis Brammanis
a4d7b20027 Don't try to select non-multipolygon relations 2013-04-02 16:23:40 -04:00
Ansis Brammanis
d573d42ebe Revert "don't try to select relations"
This reverts commit 5c15a180a3.
2013-04-02 16:00:39 -04:00
Ansis Brammanis
5c15a180a3 don't try to select relations 2013-04-02 15:42:35 -04:00
Ansis Brammanis
0c5424aa3f re-add 'selected' class after each redraw
Performance seems to be fine, but we could move this into
svg/* and only run it on entering elements.

fix #1236
2013-04-02 13:51:32 -04:00
John Firebaugh
b1daf85cfd Tooltips for disabled operations (fixes #573) 2013-03-29 12:29:07 -07:00
John Firebaugh
fdcb96e8d6 Move more inspector logic to Inspector 2013-03-17 20:07:44 -07:00
John Firebaugh
13b5cc4c4d Move inspector logic to Inspector 2013-03-17 19:54:47 -07:00
John Firebaugh
cb12b184c0 Pass entity explicitly 2013-03-17 19:38:38 -07:00
Tom MacWright
4b68f8f7ef Refactor preset grid, add fancier transition for inspector enter 2013-03-15 15:28:32 -04:00
John Firebaugh
66e1bdb47d Show tag editor for untagged entities that aren't new
Fixes #991.
2013-03-14 15:59:56 -07:00
John Firebaugh
9f5ba8342d Convert DragNode to a mode
This makes the CSS more consistent and makes fixing #953
easier. Also, dragging now clears the selection and closes
any operations menu, which is good.

There's still a minor Chrome bug: it doesn't refresh the
cursor when the .behavior-hover class is removed.
2013-03-11 15:45:27 -07:00
Ansis Brammanis
8406b7de80 use capture for esc in select mode
so that the mode can be escaped even if
a text input is focused
2013-03-10 21:27:49 -04:00
John Firebaugh
988bfeb767 Support both delete and backspace (fixes #887)
Also show correct key in operation tooltip.
2013-03-04 17:12:44 -08:00
Ansis Brammanis
44079759a6 untie showing grid and showing radial menu 2013-03-04 00:42:02 -05:00
John Firebaugh
b09bc8cfa2 Extract selection reference 2013-03-01 10:30:12 -08:00
John Firebaugh
8b5b13fbc4 Delete commented out code 2013-03-01 10:30:12 -08:00
John Firebaugh
1f28e1441e Camel case identifiers 2013-03-01 10:30:12 -08:00
Ansis Brammanis
40e133c130 Tagless entities trigger initial 2013-02-28 19:30:48 -05:00
John Firebaugh
c02531fe21 Put presetData in context 2013-02-28 16:05:04 -08:00
John Firebaugh
b7894ceaf0 Calculate participating ways in AddMidpoint
Due to differenced redraw, midpoint.ways was getting stale,
so sometimes dragging a midpoint didn't add the new node to
all ways. Better to calculate participating ways when needed.
This also simplifies the code for adding a midpoint via double
click. It does make filtering midpoints on redraw a bit more
expensive, but a cursory profile didn't show it being a problem.

Fixes #763.
2013-02-27 20:41:38 -08:00
John Firebaugh
89ee4244ff Pass context directly 2013-02-26 17:22:16 -08:00
Ansis Brammanis
c00f4a8e2d Fix updating preset ui when undoing, address ui 2013-02-23 16:54:51 -05:00
Ansis Brammanis
559d1b9420 Fix tabbing through taglist 2013-02-21 17:05:05 -05:00
Ansis Brammanis
49e5eb8317 Fix name input saving and updating 2013-02-20 17:35:50 -05:00
Ansis Brammanis
bf3a635da5 Extract tag editor ui 2013-02-15 15:58:05 -05:00
Ansis Brammanis
0bb805f557 Merge remote-tracking branch 'systemed/master' into presets
Conflicts:
	css/app.css
	index.html
	js/id/connection.js
	js/id/modes/select.js
	js/id/ui/inspector.js
	js/id/util.js
	test/spec/modes/add_point.js
2013-02-14 11:38:18 -05:00
John Firebaugh
c0b8cd74de Reopen radial menu when clicking on selected entity (fixes #758) 2013-02-13 16:23:58 -08:00
Tom MacWright
8538339b44 Fix zooming to validated features. Fixes #748 2013-02-13 17:21:21 -05:00
John Firebaugh
1e60b0b7fa iD constructors are camel case 2013-02-12 16:51:25 -08:00
John Firebaugh
6bebb9197c 200ms 2013-02-12 15:00:58 -08:00
John Firebaugh
89fe4bff09 Only add vertex when double-clicking the selected entity
Previously double-clicking would add a vertex to any way,
as long as anything was selected.
2013-02-12 14:54:39 -08:00
John Firebaugh
419aa088e3 RadialMenu#center 2013-02-12 14:54:39 -08:00
John Firebaugh
3f19a293aa Make selection less laggy 2013-02-12 14:54:39 -08:00
Ansis Brammanis
fc6cb352d8 use compatible mouse position properties 2013-02-11 12:12:18 -05:00
Ansis Brammanis
ba47d3183d Fix lasso and add it to select 2013-02-08 17:46:37 -05:00
John Firebaugh
5cad057212 Clear selection on esc (fixes #643) 2013-02-07 13:36:19 -08:00
Ansis Brammanis
a4bf7c689f Merge DragNode and DragMidpoint
Adds shared behaviors such as snapping to DragMidpoint
2013-02-06 10:49:58 -05:00
John Firebaugh
5eb0644242 Improve multipolygon rendering
Multipolygon relations report their geometry as 'area' and are rendered
as such. However, they do not render a stroke. The stroke rendering
will come from the individual lines, which are given the tag
classes of their parent relations, allowing them to have a stroke
style matching the style of simple areas with the same tags.

Untagged circular ways are no longer considered areas. This prevents
an untagged inner way of a multipolygon from rendering as an area and
is consistent with how P2 and JOSM treat them.

In the CSS, it's no longer necessary to deal with multipolygons
explicitly in selectors. But keep in mind that area boundaries can
now be rendered either as lines or as area strokes. In most cases
the selector should be `path.stroke.tag-_____`, i.e. an explicit
`.area` or `.line` classes should not be included.

Finally, the parent ways of selected multipolygons are given the 'selected'
class.
2013-02-05 15:20:11 -08:00
Ansis Brammanis
bc6238c2be Use AddMidpoint when doubleclicking on way 2013-02-05 14:52:05 -05:00
Ansis Brammanis
2d4f477265 dblclick a shared way adds vertex to all ways 2013-02-05 14:11:03 -05:00
Tom MacWright
db7f42145e Continue removing any non-scoped selectors. Refs #595
Last hits will be combobox and layerswitcher.
2013-02-05 12:00:10 -05:00
Ansis Brammanis
3576a99eb5 Always have delete as first op 2013-02-05 11:00:13 -05:00
Tom MacWright
3d8f2ffb84 Consistify syntax 2013-02-04 16:08:34 -05:00