Martin Raifer
7d546a8f60
refactor further modules to not rely on html injection
2022-06-24 19:31:41 +02:00
Martin Raifer
8bb1d39431
refactor validation modules to not inject html
2022-06-24 13:25:56 +02:00
Bryan Housel
9e3df2c4aa
Create an issue key property that changes when data needs refresh
...
(closes #8655 )
2021-08-27 17:13:36 -04:00
Bryan Housel
857b9c9adf
Exclude 'fixme'/'help_request' warnings from changeset tags.
...
They still appear in the issue list and in the entity editor.
(closes #8603 )
2021-08-02 14:34:18 -04:00
Quincy Morgan
99689f65b2
Update missed d3 v6 endpoints (re: #8056 )
2020-10-21 19:02:38 -04:00
Quincy Morgan
5435082d9c
Revert t function to returning the plain string by default
...
Add `t.html` function for getting the string with the `lang` attribute
2020-09-22 12:03:29 -04:00
Quincy Morgan
a3549f9a76
Merge branch 'develop' into lang-attributes
...
# Conflicts:
# modules/ui/commit_warnings.js
# modules/ui/field.js
# modules/ui/fields/wikidata.js
# modules/ui/fields/wikipedia.js
# modules/ui/full_screen.js
# modules/ui/panels/history.js
# modules/ui/sections/entity_issues.js
# modules/ui/sections/map_features.js
# modules/ui/sections/raw_member_editor.js
# modules/ui/sections/validation_rules.js
# modules/ui/tag_reference.js
2020-09-22 10:55:07 -04:00
Quincy Morgan
28dd2c4507
Make the errors, warnings, and changes lists in the commit sidebar keyboard-navigable (re: #8004 )
2020-09-18 13:58:41 -04:00
Quincy Morgan
32f8274929
Make t function return a span element with a lang attribute unless html: false is specified in the options (re: #7963 )
...
Update `text` functions to `html` to support inserting the `span` elements
Specify `html: false` for various instances where a `span` is not desired, e.g. `placeholder` and `title` attributes
2020-09-15 21:56:22 -04:00
Quincy Morgan
a1af118f0e
Ensure locales and presets are loaded before the UI loads ( close #7406 )
...
Consolidate localization behavior and init to a coreLocalizer function and singleton
Explicitly support `en-US` locale
Rename coreData to coreFileFetcher and export a singleton rather than using a property of coreContext
Add `apiConnections` property of coreContext to simplify adding a source switcher
Replace some init functions with re-callable, promise-supporting `ensureLoaded` functions
Make coreContext itself load the UI if a container has been specified at init time
Fix code tests
2020-03-31 12:23:31 -07:00
Quincy Morgan
d62a62cba8
Make popover and tooltip part of the UI module instead of utils
2020-03-24 17:32:09 -07:00
Quincy Morgan
1ed73b6531
Convert validation rules to validate against a specific graph, not always the current graph (re: #6459 )
2019-06-06 16:27:31 -04:00
Quincy Morgan
1bbd496dfe
When selecting an issue in the Issues pane, highlight the issue after selecting the feature
...
Use the same behavior when selecting an issue in the commit sidebar as in the issues pane
2019-05-10 10:18:46 -04:00
Quincy Morgan
3d9f7244f0
Update issue messages after merge instead of by invalidating issues
2019-05-07 16:38:08 -04:00
Quincy Morgan
97cb90b562
Make issue messages dynamic ( close #6331 )
2019-05-07 14:48:30 -04:00
Quincy Morgan
5160754dcc
Display issues for disabled rules in the commit UI
...
Allow errors for disabled rules to block upload
Include warnings for disabled rules in the changeset tags (re: #6325 )
2019-05-07 13:07:31 -04:00
Quincy Morgan
375779882d
Add ability to ignore warnings
...
Replace issue's array of entities with array of entity IDs
Improve issue ID hashing
2019-04-29 17:52:32 -07:00
Quincy Morgan
d01bb78707
Reduce circular dependencies caused by importing from indexes, the location of the validation models, and the location of areaKeys ( close #6237 )
2019-04-24 13:45:59 -07:00
Bryan Housel
35049ab40a
Replace getErrors/getWarnings with getIssues/getIssuesBySeverity
...
The idea here is that the validator will now hold onto lots of issues,
but the calling code will only want some small subset of them
(edited/everything) (inview/everywhere) and can pass these as options
so that we don't need filtering code spread throughtout the app.
2019-04-11 14:48:23 -04:00
Quincy Morgan
ee6c06d1d5
Fix an issue where the commit sidebar would not show all warning and errors
...
Remove use of lodash from commit_warnings.js
2019-02-21 15:33:14 -05:00
Quincy Morgan
46f3cea33a
Reorganize validation code
...
Rename IssueManager to coreValidator
Rename disconnected highway to disconnected way
Rename highway almost junction to almost junction
Rename mapcss checks to maprules
Rename deprecated tags to deprecated tag
2019-02-01 11:20:51 -05:00
Quincy Morgan
11b2102761
Merge branch 'master' into validation
...
# Conflicts:
# data/core.yaml
# dist/locales/en.json
# modules/ui/commit_warnings.js
# modules/ui/entity_editor.js
# modules/util/index.js
# modules/util/util.js
# modules/validations/index.js
# modules/validations/many_deletions.js
# modules/validations/missing_tag.js
2019-01-14 10:13:56 -05:00
Bryan Housel
5f20218f1f
Add validation warning for generic names
...
(closes #5590 )
2019-01-08 02:15:28 -05:00
Quincy Morgan
59b0252b0e
Fixed several linting errors
2018-12-19 13:22:48 -05:00
Quincy Morgan
ff95e6a337
Merge branch 'validationIssueDataModel' into validation
2018-12-19 10:59:45 -05:00
Quincy Morgan
903cb63efe
Renamed validations to issues in relevant places
...
Made the issue pane get the issues from the issue manager rather than validating itself
2018-12-19 10:41:58 -05:00
Xiaoming Gao
07a53fe6ea
Extend data model for validation issues
...
Add the Issues pane
1. Add a class to represent the validation issue
2. Extend the data model for an validation issue to
(1) add a severity level field (useful for identify save-blocking issues later)
(2) replace single entity with an array of entities (useful for issues involving multiple entities)
(3) add a coordinates field for highlighting the location of the issue on the map
(4) add a fixes field for possible automatic fixes
3. Update existing validation modules to use the new data model
2018-12-19 10:37:32 -05:00
Andrew Wong
30f25c6e8d
added IssueManager
...
- IssueManager performs validation on the current graph and also
stores the issues and notifies listeners when the issues changed
2018-12-18 17:52:23 -05:00
Max Grossman
6ba8bacb75
use severity in test
2018-12-18 10:27:15 -05:00
Max Grossman
3a0f8ddd09
infer geometries
...
ref #remote-presets
2018-08-08 13:21:35 -04:00
Max Grossman
b93444de75
working on isArea-ish equivalent for mapcss selector objects
...
ref #remote-presets
2018-08-02 18:03:13 -04:00
Bryan Housel
470835b38f
Extract all graphics from iD sprite, reassemble with svg-sprite
...
All iD sprite graphics are now prefixed with `iD-`
Also includes support for sending the preset logos to taginfo
2018-06-08 16:06:46 -04:00
Bryan Housel
ba3f823141
Split out commitWarnings and commitChanges sections into smaller modules
2017-08-15 01:50:52 -04:00
