Commit Graph

368 Commits

Author SHA1 Message Date
Bryan Housel
76e0d13729 Remove lodash every and filter
(re: #6087)
2019-03-23 01:22:56 -04:00
Bryan Housel
7a6c63fcc5 Remove lodash extend (re: #6087) 2019-03-23 00:38:39 -04:00
Bryan Housel
7e6f68a1b2 Remove lodash some
(re: #6087)
2019-03-23 00:07:52 -04:00
Bryan Housel
0e90167513 Remove lodash clone
(re: #6087)
2019-03-22 23:18:25 -04:00
Bryan Housel
ff4f8f005f Remove lodash find and findIndex
(re: #6087)
2019-03-22 17:31:41 -04:00
Bryan Housel
11bfeaabfc Add browser-polyfills, remove lodash assign, compact, values
(re: #6087)
2019-03-22 17:14:41 -04:00
Quincy Morgan
7d0080a642 Persist the photo overlay layers via the URL query string (re: #5813) 2019-03-14 16:48:08 -04:00
Quincy Morgan
c65a4d038e Add photo overlay filter options for hiding flat and pano photos (close #5433) 2019-03-14 14:24:21 -04:00
SilentSpike
5bd13dc590 Use https for ImproveOSM requests 2019-02-20 23:11:09 +00:00
Quincy Morgan
a928621681 Fix issue where mapillary sign colors were not shown 2019-02-20 11:09:57 -05:00
Quincy Morgan
db319e8ff5 Merge branch 'master' into validation 2019-02-11 07:59:29 -05:00
Bryan Housel
d055f34be8 Add sitelinks to result from wikidata getDocs 2019-02-09 15:18:32 -05:00
Bryan Housel
29ce6cb30c Use proper errbacks
(re: #5823)
2019-02-09 14:51:37 -05:00
SilentSpike
24022416cb Fix negative number of trips in ImproveOSM issues
See https://github.com/openstreetmap/iD/pull/5739#issuecomment-460786055
2019-02-09 16:31:37 +00:00
Bryan Housel
a2b140e92b Remove unnecessary ternary 2019-02-08 16:38:40 -05:00
Bryan Housel
fbe584c7ec Lookup docs for some presets on wikidata, not wikibase
(re: #5823)

Now `uiTagReference` can accept a `qid` param for presets where we want this
(such as brands)
2019-02-08 16:27:33 -05:00
Bryan Housel
2a7fec46fe Fetch somewhat higher resolution images
(100x100 was really too small)
2019-02-08 13:36:39 -05:00
Bryan Housel
32c42073c6 Add support for Relation type documentation lookups from wikibase
(closes #5860)
2019-02-08 13:24:58 -05:00
Quincy Morgan
ff6860693a Merge branch 'master' into validation 2019-02-08 13:21:46 -05:00
Bryan Housel
e0459279bb Move implementation details from uiTagReference to wikibase service 2019-02-08 12:08:36 -05:00
Quincy Morgan
1564f73de6 Merge branch 'master' into validation 2019-02-07 20:51:21 -05:00
Bryan Housel
bb0a47b255 Remove kr and keepRight for styles used generically
(it was weird to see these classes in improveOSM components)
2019-02-07 10:35:50 -05:00
SilentSpike
0346d8060f Retrieve ImproveOSM comments only once
This additionally fixes the comment box not clearing on submission as I
wasn't updating the error in the cache (to remove the newComment
property).
2019-02-05 21:46:17 +00:00
SilentSpike
fa87ed75ae Display ImproveOSM comments oldest to newest 2019-02-05 19:57:22 +00:00
SilentSpike
2c7b689b47 Add comments display to ImproveOSM issues 2019-02-05 19:52:44 +00:00
SilentSpike
28bb12b7ae Add function to retrieve ImproveOSM comments
Just need to have the UI make this call and use the data next.
2019-02-05 19:31:30 +00:00
SilentSpike
448119324f Add ability to comment on ImproveOSM issues 2019-02-05 17:11:37 +00:00
Quincy Morgan
8771a33716 Merge branch 'master' into validation 2019-02-05 11:30:24 -05:00
SilentSpike
3ed13e9a4a Convert KeepRight to use generic error type 2019-02-04 16:54:07 +00:00
SilentSpike
20ed8b50c9 Add generic QA error
I've converted the improveOSM errors to use this new generic QA error
structure which should allow for more general code to be used in
behaviour and UI.

Sidebar preview is currently broken, but will be fixed shortly.
2019-02-04 16:53:59 +00:00
Quincy Morgan
8c51411ad6 Merge branch 'master' into validation 2019-02-04 08:58:10 -05:00
Bryan Housel
e4e0d9d13a Add oneway icon for ImproveOSM oneway markers 2019-02-03 23:55:16 -05:00
SilentSpike
9403f71140 Track closed ImproveOSM errors via coordinates 2019-02-01 23:31:08 +00:00
SilentSpike
c9e249ee6c Send only relevant query parameters 2019-02-01 23:14:54 +00:00
SilentSpike
e9397aa14f Fix incorrect usage of osm.userDetails callback
Javascript is not my usual domain so still getting used to how scope
works and working with callbacks. Believe this code is now written as
intended.

As a bonus a response status to the error update request which isn't the
expected 200 now returns before visibly removing the error and adding it
to the closed cache.
2019-02-01 22:51:05 +00:00
SilentSpike
21824e6377 Fix coincident errors
Potential for multiple missing turn restrictions on one node and I've
also seen a case of missing one-way along the same stretch of road in
opposite directions!

Missing geometry is tile based so can't really be coincident, but
doesn't hurt to check in case they happen to land on a one-way or turn
restriction.
2019-02-01 22:51:04 +00:00
SilentSpike
183dda5999 Pacify eslint 2019-02-01 22:51:04 +00:00
SilentSpike
d82757c392 Include node in turn restriction description
Clarifies some cases where geometry could be unclear with previous
message.
2019-02-01 22:51:04 +00:00
SilentSpike
60128b0402 Fix one-way error positioning and description
The direction of travel in the description was misleading as the way
segment wasn't necessary linear and so the direction could change as you
travel along the way. This is more explicit as it specifies the detected
start/end nodes (also useful to show that it's not the whole way that
might be one-way).

The position is now taken as the central node in the `feature.points`
list (or the average of the central two when there are an even number of
points).
2019-02-01 22:51:03 +00:00
SilentSpike
45ce4e4c57 Move turn restriction error position slightly 2019-02-01 22:51:02 +00:00
SilentSpike
ee5f9f3bf2 Use consistent short service name 2019-02-01 22:51:02 +00:00
SilentSpike
5d907c1e16 Render errors like points with icons
This allows more diverse representation of the error subject at a glance
than relying on colour alone.

However, it would be good to have a generic error icon that can contain
icons which is differentiated from the point icon for clarity.

Sidebar header currently still uses the bolt icon until I figure out
how to deal with that. Also the font awesome icons don't seem to work,
perhaps there's additional code needed for those that I've missed.
2019-02-01 22:51:01 +00:00
SilentSpike
4a166d7a5b Use more descriptive key names 2019-02-01 22:51:01 +00:00
SilentSpike
88a59cb15f Stop hijacking the inflight cache
This could result in error updates getting aborted when new errors are
loaded as their individual ids are never going to match tile IDs (see
`abortUnwantedRequests` function).
2019-02-01 22:51:01 +00:00
SilentSpike
3334abf776 Remove some unnecessary code 2019-02-01 22:51:00 +00:00
SilentSpike
31091f1159 Add direction of travel to oneway errors 2019-02-01 22:50:59 +00:00
SilentSpike
6bdd0cfa89 Fix missing semicolons 2019-02-01 22:50:58 +00:00
SilentSpike
3174db76b7 Fix north direction in some error descriptions 2019-02-01 22:50:58 +00:00
SilentSpike
9d2792836f Add ImproveOSM error resolution 2019-02-01 22:50:58 +00:00
SilentSpike
214cf41019 Use more generic classes for errors 2019-02-01 22:50:57 +00:00