Commit Graph

3072 Commits

Author SHA1 Message Date
Quincy Morgan
71bfeb5a9f Fix lint warnings 2019-11-07 20:16:05 +01:00
Quincy Morgan
9d367d133f Cherry pick preset image error fallback 2019-11-07 20:12:18 +01:00
Quincy Morgan
f45670a9a7 Don't suggest brands from incompatible countries in the Name field (close #6479) 2019-11-07 19:21:00 +01:00
Quincy Morgan
538829d171 Don't flag nonstandard brands from incompatible countries (close #6513) 2019-11-07 19:08:50 +01:00
Quincy Morgan
d89996e52c Update country-coder to 2.0.0 (close #7029)
Localize address field in walkthrough without overwriting country coder function
2019-11-07 18:45:46 +01:00
Bryan Housel
6dfdec06ad Ignore junction in areaKeys code and remove the unsearchable presets
(closes #6933)

We should not be adding unsearchable junction presets for every kind of
junction as a hacky workaround to let `junction=yes` be an area.

This should remove the special treatment of junction tag.
* `junction=*` will not be treated as an area by default
* `junction=*` will not trigger validator warnings that they should be closed
* `junction=yes` mapped as an area _will_ need an `area=yes` now, which iD will add
(afaik this is the only junction tag that should be treated as an area)
2019-11-04 10:53:36 -05:00
Quincy Morgan
8c0740191f Replace remaining nominatim countryCode calls with country-coder calls (close #6941) 2019-11-01 18:15:35 +01:00
Quincy Morgan
51dbdb4f27 Add country-coder as a dependency
Use country-coder to code addresses (re: #6941)
2019-11-01 17:03:51 +01:00
Katarzyna Król
48ccc7900e improve checking circularity and unit tests 2019-10-29 22:51:05 +01:00
Katarzyna Król
3feb20c764 disable circularize if object is already circular 2019-10-29 01:56:49 +01:00
hack.ily
b40d4ac893 Fix lint 2019-10-28 10:20:40 -04:00
hack.ily
b5fac6396e fix(mode/rotate): polygonHull sometimes returns array of length 2 which polygonCentroid cannot handle 2019-10-28 10:20:26 -04:00
Bryan Housel
3886f2dad8 Merge branch '2.15-building-crossing-layers' into 2.x 2019-10-24 15:15:06 -04:00
Bryan Housel
dbe016a399 v2.16.0 2019-10-23 23:34:00 -04:00
Quincy Morgan
2576f58b14 Show uppercase suggestions in the Draft Beers field and update changelog 2019-10-21 11:15:08 +02:00
Quincy Morgan
9c637647a9 Don't disable items in the preset list during the walkthrough (close #6634)
Update changelog
2019-10-15 12:47:27 +02:00
Quincy Morgan
949ec8afa0 Add issue count badges to the bottom info bar when validating Everything 2019-10-14 17:14:47 +02:00
Quincy Morgan
769c95af55 Add non-actionable fix suggestion for "Fix Me" request issues 2019-10-14 11:03:49 +02:00
Quincy Morgan
56f31adcf1 Always sort the entity issues list deterministically
Don't skip validations just because a different validation produced issues
2019-10-12 17:01:03 +02:00
Quincy Morgan
edd99f235f Use default sensitivity for sorting moreFields in UI 2019-10-12 12:04:26 +02:00
Quincy Morgan
db83254595 Sort moreFields in the UI with locale-specific alphabetization (close #6937) 2019-10-12 11:55:08 +02:00
Quincy Morgan
abd94a940f Show non-actionable "Connect this feature" fix for disconnected roads and paths with both ends as noexits
Correctly reverse the "continue" fix icons for the right-to-left layout
2019-10-11 17:04:45 +02:00
Quincy Morgan
c5e1c0d596 Fix lint warning 2019-10-11 14:02:19 +02:00
Quincy Morgan
92116f198a Only show edited vertices as needed (close #6934) 2019-10-11 14:01:07 +02:00
Quincy Morgan
aba96f039f Add specific "no issues" message if the user has no edits
Don't use "other features" language since "my edits" validation checks are no longer per-feature
2019-10-11 13:22:53 +02:00
Quincy Morgan
a66e21c76f Fix tooltips on zoom buttons when they're disabled 2019-10-11 12:46:02 +02:00
Quincy Morgan
cb95682674 Always show the reset ignored issues button when there are ignored issues 2019-10-11 12:29:59 +02:00
Quincy Morgan
82acd82a29 Don't make edited vertex targets larger
Render vertex and point change highlight with some opacity
2019-10-10 18:58:39 +02:00
Quincy Morgan
18a2c6c320 Fix issue where false edited segment indicators could appear 2019-10-10 18:28:43 +02:00
Quincy Morgan
d7bde50649 Locate impossible way issues at the questionable node, not at the center of the way's extent 2019-10-10 15:08:54 +02:00
Quincy Morgan
cdcf5c4606 Rename Fill Areas section to Style Options
Add Highlight Changes button to the Style Options section for toggling visual diffs (re: #6843)
2019-10-10 12:38:56 +02:00
Quincy Morgan
bd1e1b34ff Add subtypes to crossing_ways validation warnings
Allow the `indoor` tag to indicate a crossing feature is indoors
2019-10-09 15:24:42 +02:00
Quincy Morgan
a3d6097d40 Rename "Fix Me" Requests validation rule to more general Help Requests
Add subtypes to almost_junction and disconnected_way validation rules
Add additional validation documentation (re: #6100)
2019-10-09 15:00:28 +02:00
Quincy Morgan
d57807478e Start validation documentation (re: #6100)
Add subtypes to close_nodes and unsquare_way validations
2019-10-09 12:43:38 +02:00
Quincy Morgan
c7186e2ee6 Replace usage of lodash isEqual (re: #6843) 2019-10-08 20:42:58 +02:00
Quincy Morgan
7d31c76546 Unify visual diff styles for lines and areas (re: #6843)
Render tag-only diffs in yellow instead of translucent orange
Don't use target colors for vertex diff styling
2019-10-08 20:25:09 +02:00
Quincy Morgan
868ab2ca27 Merge pull request #6921 from cbeddow/2.15
fix: mapillary pagination and minimum detection count
2019-10-07 16:41:39 +02:00
Quincy Morgan
2924d4619a Show visual diff for standalone points (re: #6843) 2019-10-07 16:33:35 +02:00
Quincy Morgan
f3e7bd9034 Render line and vertex visual diff on shadow instead of above everything (re: #6843)
Differentiate added lines and vertices from merely changed ones
2019-10-07 16:13:35 +02:00
cbeddow
819ea05e6f fix: mapillary pagination and minimum detection count 2019-10-07 14:13:21 +02:00
Quincy Morgan
909079e454 Replace uses of lodash omit (re: #6843)
Fix lint warnings
2019-10-07 11:43:40 +02:00
Quincy Morgan
5abdd4c813 Removed unused strings and rename string ids to not indicate ways only (re: #6843) 2019-10-07 11:02:07 +02:00
Quincy Morgan
c031f2dd33 Merge branch '2.15' into 215_highlight_edits
# Conflicts:
#	modules/svg/areas.js
2019-10-07 10:49:52 +02:00
Huon Wilson
de2f052eb9 Change cliff direction marker to dark grey to match the line
Cliffs had their colour changed in 5f9bea67d, but the directional
arrow remained green.

Fixes #6918
2019-10-07 13:11:40 +11:00
Quincy Morgan
7251a2ab90 Make "edited issues" mean "issues the user created" instead of "issues for features edited by the user"
Only include issues created by the user in the "warnings" changeset tags
Include counts of issues resolved by the user in the changeset tags (close #6459)
Don't include "fixme" issue counts in "warnings" changeset tags since they're not created by the user (close #6658)
Don't cache crossing ways issues at the rule level
2019-10-04 16:50:44 +02:00
Quincy Morgan
badde3d583 Add warning for features with names that equal values in their not:name tag (close #6411) 2019-10-04 11:06:27 +02:00
Quincy Morgan
f5995dffb0 Cherry pick crossing buildings fix 2019-10-03 20:09:49 +02:00
Quincy Morgan
3b671bf4e4 Flash the "change feature type" button in the inspector whenever the preset changes (close #6764) 2019-10-03 18:50:33 +02:00
Quincy Morgan
08530dd822 Prevent stale operations by reloading them after history changes 2019-10-03 16:57:12 +02:00
Quincy Morgan
0dc890a9ee Show more specific message when nonstandard brand has simply incomplete tags (close #6909) 2019-10-03 15:25:18 +02:00