Commit Graph

4520 Commits

Author SHA1 Message Date
Martin Raifer
5ef99280bc Merge branch 'field-type-directional' into develop 2022-12-12 22:30:33 +01:00
Rewinteer
be4f3ce0d2 Added highway=busway to 'Traffic Roads' group of map features. (#9416) 2022-12-12 22:12:19 +01:00
Martin Raifer
89afee1ad5 lint code 2022-12-12 16:11:15 +01:00
Martin Raifer
479586be37 combo boxes can consume complex label strings now:
instead of `"strings": { "options": { "<tag-value>": "<translatable-string>", …` it is now also supported to have:

```
"strings": {
    "options": {
        "<tag-value>": {
            "title": "<translatable-string>",
            "description": "<translatable-string>"
        },
        …
```
2022-12-09 19:34:13 +01:00
Martin Raifer
4c222fde0a make sure editing multi selection doesn't corrupt tags
because the common tag vs. left/right tag situation can be different for different entities in the multiselection, the approach to merge/split/update the tags needs to be made on a per entity basis

this introduces a new way to specify tag changes: a callback function which is called for each to be modified entity
2022-12-09 19:01:44 +01:00
Martin Raifer
08ae8a3fac reuse combo field module from within directional_combo
reducing duplication of code, and brings missing features to the directional version of the field
2022-12-09 17:28:00 +01:00
Martin Raifer
80d3e767cc rename to "directional combo" field 2022-12-09 13:52:57 +01:00
Martin Raifer
d7cbf058ee make cycleway field modular (i.e. accept any supplied keys) 2022-12-09 13:52:02 +01:00
Martin Raifer
6239cc0ccc Merge branch 'maxlength-indicator' into develop 2022-12-02 18:37:59 +01:00
Martin Raifer
dcd7fb4938 don't include misspelled taginfo suggestions in combo fields 2022-12-02 13:49:49 +01:00
Martin Raifer
60ee70f016 replace parseFloat with Number 2022-12-02 13:41:48 +01:00
Martin Raifer
827608ad23 add warning icon also to "regular" max length indicator warning 2022-11-28 19:23:19 +01:00
Martin Raifer
d5872cca73 show prettier maxChars warning for changeset comments
from #9392
2022-11-28 19:08:37 +01:00
Martin Raifer
3b7141ba0a Merge remote-tracking branch 'alanb43/changeset-max-length-warning' into maxlength-indicator 2022-11-28 16:54:14 +01:00
alanb43
de23bd5c33 added warning when changeset comment length > 255 chars 2022-11-27 01:55:30 -05:00
Martin Raifer
6c9ffdc854 lint 2022-11-26 10:28:20 +01:00
Martin Raifer
59b10b7974 add length indicator for semicombo fields as well 2022-11-25 18:52:13 +01:00
Martin Raifer
2c0ca277bf add max-length-indicator to combo fields 2022-11-25 18:18:51 +01:00
Martin Raifer
f931d447af add length indicator to regular text (and localized) fields 2022-11-25 18:10:14 +01:00
Martin Raifer
5091966056 [WIP] add string length indicator and max-length message 2022-11-25 17:48:33 +01:00
Martin Raifer
5751e80b93 replace parseFloat with Number 2022-11-24 20:12:18 +01:00
Martin Raifer
41aa127d23 reduce use of parseFloat
as it silently strips non-numeric suffixes (e.g. a value of "123 foo" is transformed into a numeric value of 123 by `parseFloat`, which is typically not what we desire)
2022-11-24 19:39:15 +01:00
Martin Raifer
fc75d5f2a1 fix another regression (in b72f3aa), add tests 2022-11-24 19:12:23 +01:00
Martin Raifer
b72f3aae19 fixes a regression in f573c37 2022-11-24 18:40:11 +01:00
Martin Raifer
f573c374c2 number field: improve +/- buttons
* Clamp degree values in `direction` fields between 0 and 359 degrees, fixes #9386
* Only match cardinal values to numbers in `direction` fields
* Disable increment/decrement buttons on number fields if the input value is not numeric or when there is a multi-selection with conflicting values
* Fix/implement reverse operation for semicolon delimited `direction` values
2022-11-24 15:16:49 +01:00
Martin Raifer
4dcf6090d8 fetch version directly from package.json 2022-11-14 19:46:30 +01:00
Martin Raifer
21e54f956d don't preserve preset's field tags if presets are sub-presets of each other
fixes #0372
2022-11-14 18:58:37 +01:00
Martin Raifer
d9a4d6cbde Fix crash when multiselection has differing values in combo field
closes #9369
2022-11-12 22:03:28 +01:00
Martin Raifer
1054c35dc5 Set development version number 2022-11-10 13:11:05 +01:00
Martin Raifer
48f925a27b v2.23.0
Signed-off-by: Martin Raifer <martin@raifer.tech>
2022-11-10 12:35:21 +01:00
Martin Raifer
224246e90e fetch at least v5.0.1 of presets 2022-11-09 19:18:41 +01:00
Martin Raifer
9d8116ff6d don't indent combo content when there is no icon for tag value 2022-11-08 19:29:23 +01:00
Martin Raifer
635c498548 make tag value icons work for translatable strings, too 2022-11-08 19:20:47 +01:00
Martin Raifer
62113dcf74 improve icons in comboboxes: update while typing, fix spacings
also makes sure checkbox & radio are aligned with the left padding of the respective input fields
2022-11-08 18:48:06 +01:00
Martin Raifer
56e92e661c split function branches to reduce complexity 2022-11-08 13:55:28 +01:00
Martin Raifer
ef044cd17d Show icons depicting the different values of the crossing:markings field
for https://github.com/openstreetmap/id-tagging-schema/pull/590
2022-11-08 13:47:39 +01:00
Martin Raifer
501011ef4d use colour field type instead of relying on the tag key
see #9320
2022-11-08 13:16:08 +01:00
Martin Raifer
a6be05966b improve comboboxes: (#9344)
* pressing return/enter doesn't deselect the entity anymore
* predefined ("static") field options are always listed in the combobox dropdown, even if taginfo doesn't include them (because of low usage)
* (raw) tag values can also be entered for localized strings
* static localized strings can be used before taginfo response is received (useful when taginfo is slow or unavailable)
* fixes some bugs which can be triggered when taginfo is slow
* fixes a bug where the autocomplete dropdown doesn't work properly when tags have "few" values
* multiCombo fields can be case-sensitive now
2022-11-08 12:09:06 +01:00
Martin Raifer
5f1360ed0f don't suggest to "connect the ends" if a feature with area tags matches a line preset
For example, when a feature tagged as `highway=primary` (line preset) and `man_made=bridge` (area preset) is mapped as an unclosed way, converting it to an area (by closing the way by connecting the endpoints) does not improve the situation, as then the other tag doesn't fit to the geometry anymore.

closes #7037
2022-11-04 12:23:15 +01:00
Martin Raifer
58f597165b match shortest possible name or alias when sorting presets
improves preset matching in cases like https://github.com/openstreetmap/id-tagging-schema/issues/632
2022-11-04 10:06:20 +01:00
Kyℓe Hensel
2bf92b42b9 fix the phone input field showing the wrong placeholder (#9316) 2022-11-01 18:56:48 +01:00
Martin Raifer
78d37fd7a8 fix tooltip of "back/forward" buttons in preset list and entity editor 2022-11-01 18:32:47 +01:00
Martin Raifer
34a414ee18 make checkbox fields work with cross referenced string 2022-11-01 17:58:36 +01:00
Martin Raifer
56c05b1d1a Merge remote-tracking branch 'origin/locationmanager_perf' into develop 2022-10-28 17:30:10 +02:00
Bryan Housel
2b2a71f597 Don't pre-resolve and index complex locationSets into GeoJSON.
This was taking a lot of time at app startup.

Instad now we resolve and index only the include and exclude parts.
We can still determine the valid locationSets at runtime in `locationSetsAt()`
by checking the `_locationIncludedIn` and `_locationExcludedIn` caches.

This also upgrades the locationManger to an ES6 class.

This also includes some hacky code in nsi.js so that the NSI will continue to work.
The NSI matcher can build its own location index, but it doesn't need to do this.
We monkeypatch a few of the matcher collections to work with the new LocationManager.
2022-10-28 10:49:01 -04:00
Martin Raifer
c9adbc724e fix crash when conflict resolver is opened, closes #9345 2022-10-28 13:48:54 +02:00
Martin Raifer
097c6bd774 skip unsupported/invalid restrictions instead of fallback to "no_*"
closes #9337 (at least kind of… for a proper solution see #6460)
2022-10-27 18:36:05 +02:00
Martin Raifer
dd30a39d74 fix logic bug, extend test coverage 2022-10-27 17:07:32 +02:00
Martin Raifer
96bac0650b on preset change: don't drop tags if ∃ a matching field in the new preset
closes #9341
closes #9104
2022-10-27 13:06:00 +02:00
Martin Raifer
b94b811591 use config to fetch preset translations 2022-10-27 12:11:26 +02:00