Quincy Morgan
6d397e89c6
Account for waterway bridges and implicit layers in crossing ways validation
2019-02-19 15:28:27 -05:00
Quincy Morgan
f536706763
Refactor crossing ways validation for performance
2019-02-19 14:40:54 -05:00
Quincy Morgan
b766f82cbd
Improve crossing ways performance slightly by avoiding clone
2019-02-19 13:25:02 -05:00
Quincy Morgan
708c5e8155
Fix crash when undoing an added line past the first node
2019-02-19 12:10:05 -05:00
Quincy Morgan
12a44421c3
Account for indoor features in crossing ways validation
...
Recommend using an appropriate structure/layer/level for crossing ways validation
Flag crossing highways on different levels but without bridges or tunnels
2019-02-19 11:43:05 -05:00
Quincy Morgan
b43796a4c7
Don't flag almost junctions for points endpoints that also occur earlier in the way
2019-02-19 09:16:32 -05:00
Quincy Morgan
794e953d43
Don't suggest continuing a disconnected highway from endpoints that have noexit=yes
2019-02-19 08:40:49 -05:00
Quincy Morgan
7307beff21
Don't make connect endpoints fix for tag suggest area actionable if there aren't more than two nodes
2019-02-18 12:51:50 -05:00
Quincy Morgan
10d9f05739
Show the actual deprecated tag value in the issue message rather than the * placeholder
2019-02-18 12:17:52 -05:00
Quincy Morgan
66db6f3f2c
Make building crossing validation only create one issue per feature pair (re: #5891 )
2019-02-18 10:43:19 -05:00
Quincy Morgan
94cb9faaa2
Don't check for self-intersection in the crossing ways validation
2019-02-18 10:16:22 -05:00
Quincy Morgan
7021985aec
Don't suggest connection fix for highway-building crossings (re: #5891 )
2019-02-18 10:12:47 -05:00
Quincy Morgan
e48f8cfc48
Fix generic name issue message
2019-02-18 10:11:01 -05:00
Quincy Morgan
2c1955d630
Improve performance and scope of the generic name validation
2019-02-18 10:02:49 -05:00
Quincy Morgan
397097ac1f
Tweak issue and fix strings
...
Different strings for one vs. a combination of deprecated tags
2019-02-15 14:24:11 -05:00
Quincy Morgan
1821c3e955
Update fixes UI for icons, link styling, and non-actionable fixes
...
Fix several bugs
2019-02-14 15:56:04 -05:00
Bryan Housel
c86f11c359
Don't suggest extending disconnected line if it is closed
...
Extend at start/end doesn't make sense in this situation
2019-02-14 14:09:44 -05:00
Bryan Housel
c4fe42653a
s/coordinates/loc and replace legacy names in tests
...
In iD codebase `loc` is usually a single coordinate pair
and `coordinates` is usually an array of pairs
2019-02-12 21:18:25 -05:00
Bryan Housel
448fe498bd
Only recenter view if necessary, select after delay, fix maprules type
2019-02-12 17:25:54 -05:00
Bryan Housel
14896b0ce5
Documentation, and move validation type up to top of each file
2019-02-12 16:07:08 -05:00
Bryan Housel
9d58c4d0a2
Alphabetic
2019-02-11 14:11:35 -05:00
Bryan Housel
251a83ff7a
Nitpicky code formatting stuff
...
- no multiline var declaration
- squish together and alphabatize imports
- linebreaks for readability
2019-02-11 13:55:58 -05:00
Bryan Housel
a6e05b8ac5
Rename for consistency - these are called "annotations" elsewhere
2019-02-11 13:36:02 -05:00
Quincy Morgan
6a9bb2d138
Add crossing tags when connecting paths crossing roads with the quick fix
2019-02-11 12:03:56 -05:00
Quincy Morgan
47ec58e5fc
Don't zoom to the end vertex when continuing a disconnected highway if it is already visible
...
Add separate fixes for continuing a disconnected highway from the start and end vertices
Highlight the vertex that will be continued
2019-02-11 11:29:34 -05:00
Quincy Morgan
55f71f5a7d
Replace Set objects in crossing ways validation
2019-02-08 09:20:41 -05:00
Quincy Morgan
5b8fea9e87
Use existing nodes where possible in the crossing ways connection fix
...
Fix a lint warning
2019-02-06 15:03:29 -05:00
Quincy Morgan
50fcff6ec9
Only check the edge nodes for almost junction merge fix
2019-02-06 14:12:19 -05:00
Quincy Morgan
7765baf03b
Make merge threshold consistent for almost_junction and tag_suggests_area connection fixes
2019-02-06 13:12:58 -05:00
Quincy Morgan
88ecbcc069
Make the tag_suggests_area connection fix always use the location of the first node
2019-02-06 13:10:22 -05:00
Quincy Morgan
b25d75a6cc
Use existing nodes where possible in almost junction connection fix
2019-02-06 12:47:12 -05:00
Quincy Morgan
8545ebde8e
Add self-intersection check before flagging almost junction issues
2019-02-06 11:29:58 -05:00
Quincy Morgan
33d02cdba0
Add different messages for no tags vs. no descriptive tags warnings
...
Add warning for relation without a "type" tag
2019-02-06 09:38:33 -05:00
Quincy Morgan
26dd7a4148
Use error for missing tags on all newly added features
2019-02-05 16:19:43 -05:00
Quincy Morgan
beab323b20
Use warning severity for missing_tag validation if the user has not edited the feature
2019-02-05 15:58:20 -05:00
Quincy Morgan
bfefea422b
Use iD's area tag logic for the tag_suggests_area validation
2019-02-05 13:55:59 -05:00
Quincy Morgan
4f68e71094
Merge endpoints rather than add segment if ends are close together in tag_suggest_area fix
2019-02-05 13:21:39 -05:00
Quincy Morgan
7dd337383a
Add quick fix for connecting the endpoints of a line where tags suggest area if it won't create self-intersection
2019-02-05 12:16:46 -05:00
Quincy Morgan
0934db48dd
Don't count vertices toward many deletions warnings
...
Lower threshold for triggering many deletions warnings
2019-02-05 09:12:43 -05:00
Quincy Morgan
c39c584b52
Fix false positive for deprecated tag validation
2019-02-04 18:36:42 -05:00
Quincy Morgan
d3946894e8
Standardize deprecated_tag and missing_tag rule type ids
...
Run crossing_ways before disconnected_way
Break out crossing_ways issue creation into a separate function
2019-02-04 16:29:29 -05:00
Quincy Morgan
01c4c46918
Improve crossing ways validation performance by reducing garbage collection
2019-02-04 15:41:22 -05:00
Quincy Morgan
4921a32be1
Improve performance of crossing ways validation
2019-02-04 15:22:07 -05:00
Quincy Morgan
451704ca7b
Remove check to see if ways were already checked in the crossing ways validation
2019-02-04 15:07:37 -05:00
Quincy Morgan
bfb5285dc9
Fix tests and lint warnings
2019-02-04 13:34:27 -05:00
Quincy Morgan
c2d72cf434
Make sure the vertex is visible when using the "continue this feature" quick fix for disconnected way
2019-02-04 11:30:48 -05:00
Quincy Morgan
a0558102d6
Add correct tags to crossing highway/railway and highway/waterway connection during quick fix
...
Remove unused fix text
2019-02-04 09:57:47 -05:00
Quincy Morgan
9785021f44
Rename simpleMultipolygon functions to oldMultipolygon
...
Return old_multipolygon validation issues for the relations as well as the outer ways
Remove console logging
Don't run missing_tag validation for relations with old_multipolygon issues
2019-02-01 15:19:28 -05:00
Quincy Morgan
973697b8ba
Run all validators in the validations folder if not manually run
...
Remove ValidationIssueType and ValidationIssueSeverity objects
2019-02-01 13:38:17 -05:00
Quincy Morgan
46f3cea33a
Reorganize validation code
...
Rename IssueManager to coreValidator
Rename disconnected highway to disconnected way
Rename highway almost junction to almost junction
Rename mapcss checks to maprules
Rename deprecated tags to deprecated tag
2019-02-01 11:20:51 -05:00
