Commit Graph

9845 Commits

Author SHA1 Message Date
Quincy Morgan 6a931f9be6 Added colors to issue list icons
Corrected icon for warnings
Made disconnected_highway issue a warning instead of an error
2018-12-19 13:07:47 -05:00
Quincy Morgan a95af00b1d Added icons to issues list 2018-12-19 12:40:42 -05:00
Quincy Morgan c4fb38603e Merge branch 'master' into validation 2018-12-19 12:14:32 -05:00
Bryan Housel e1f26b5692 Merge pull request #5624 from ockendenjo/hat-route
Add more tests for splitting ways in relations containing loops
2018-12-19 12:10:12 -05:00
Bryan Housel 7db6133666 Merge pull request #5583 from quincylvania/field-prerequisite-tags
Mechanism for displaying fields conditionally based on tags
2018-12-19 12:08:15 -05:00
Xiaoming Gao c1e3a7396f filter validations early in history
Follow @wonga00's comment in https://github.com/openstreetmap/iD/pull/5627
2018-12-19 12:05:06 -05:00
Quincy Morgan a05e259628 Added some initial styling for issues list 2018-12-19 11:28:29 -05:00
Quincy Morgan ff95e6a337 Merge branch 'validationIssueDataModel' into validation 2018-12-19 10:59:45 -05:00
Bryan Housel f478fdbfbd Add preset for Enforcement relation type
(closes #5610)
2018-12-19 10:45:54 -05:00
Quincy Morgan 903cb63efe Renamed validations to issues in relevant places
Made the issue pane get the issues from the issue manager rather than validating itself
2018-12-19 10:41:58 -05:00
Xiaoming Gao 07a53fe6ea Extend data model for validation issues
Add the Issues pane

1. Add a class to represent the validation issue
2. Extend the data model for an validation issue to
  (1) add a severity level field (useful for identify save-blocking issues later)
  (2) replace single entity with an array of entities (useful for issues involving multiple entities)
  (3) add a coordinates field for highlighting the location of the issue on the map
  (4) add a fixes field for possible automatic fixes

3. Update existing validation modules to use the new data model
2018-12-19 10:37:32 -05:00
Quincy Morgan 0d0521c936 Moved feature applicability into the issue manager class 2018-12-19 10:32:14 -05:00
Quincy Morgan 161311faa5 Merge pull request #5626 from wonga00/wonga_issue_manager
added IssueManager
2018-12-18 18:05:40 -05:00
Quincy Morgan 858a9606d5 Added entity display name or preset name to the disconnected highway message 2018-12-18 18:05:27 -05:00
Andrew Wong 30f25c6e8d added IssueManager
- IssueManager performs validation on the current graph and also
   stores the issues and notifies listeners when the issues changed
2018-12-18 17:52:23 -05:00
ockendenjo cec442012a Add test for route going round loop in other direction 2018-12-18 22:09:20 +00:00
Quincy Morgan c1240af464 Added options UI in the Issues pane with edited vs all features selection
Added basic issues list in the Issues pane
2018-12-18 17:04:40 -05:00
ockendenjo 8aaa387d4e Add tests for hat route splitting #4876 2018-12-18 21:39:35 +00:00
Quincy Morgan 982f226d07 Merge branch 'master' into validation 2018-12-18 15:56:15 -05:00
Quincy Morgan 6e1dd34447 Fixed an issue where a new container would be added in the Map Data pane every time a section was re-expanded 2018-12-18 15:55:50 -05:00
Bryan Housel 5a2049b421 Drop extra whitespace, make sure service exists before using it 2018-12-18 15:38:53 -05:00
Quincy Morgan e87a7e1125 Merge branch 'master' into validation 2018-12-18 15:35:55 -05:00
Bryan Housel 814c72fe42 Merge branch 'remote-presets' of https://github.com/radiant-maxar/iD into radiant-maxar-remote-presets 2018-12-18 15:15:11 -05:00
Bryan Housel a31fceeef0 Restore full width textareas on settings screens
(closes #5619)
2018-12-18 12:16:46 -05:00
Bryan Housel bff0ea27f7 Merge pull request #5622 from openstreetmap/5614
5614 - add close button to commit side bar
2018-12-18 12:10:31 -05:00
Max Grossman 1471b55122 lint!
ref #5614
2018-12-18 12:02:26 -05:00
Bryan Housel 007faeae6e Adjust fields, add couplings, simplify labels 2018-12-18 11:31:30 -05:00
Max Grossman ae9d43b0ac remove double class
ref #5614
2018-12-18 11:16:37 -05:00
Quincy Morgan cf0214d06a Add the Issues pane 2018-12-18 11:11:15 -05:00
Max Grossman 18c021b5d5 add css
ref #5614
2018-12-18 11:09:26 -05:00
Max Grossman 0328e4f9da add close button w/out css
ref #5614
2018-12-18 11:00:40 -05:00
Bryan Housel 9f5d2b2e7e Merge branch 'fire-hydrants-shortened' of https://github.com/momu/iD into momu-fire-hydrants-shortened 2018-12-18 10:37:52 -05:00
Max Grossman 6ba8bacb75 use severity in test 2018-12-18 10:27:15 -05:00
Quincy Morgan 7e9082b9ff Merge branch 'master' into field-prerequisite-tags 2018-12-18 09:33:46 -05:00
Bryan Housel 029f702d99 Add Road Closed preset and render style
(re: #5599)
2018-12-17 17:53:55 -05:00
Max Grossman 64f2d913e8 remove unused entities from test 2018-12-17 17:39:47 -05:00
Max Grossman 8f33a85a12 make collection.index function to handle failing tests 2018-12-17 17:16:10 -05:00
Max Grossman d8de9e785e do not add found presets to recent 2018-12-17 14:56:33 -05:00
Max Grossman 4475964401 hey, do not comment out tests! 2018-12-17 12:56:34 -05:00
Max Grossman 74a19a6d7f remove a comment 2018-12-17 12:55:00 -05:00
Max Grossman e0e6f5b918 remove non-used util class 2018-12-17 12:52:21 -05:00
Bryan Housel 3f2cf67218 Add preset for Australian Football field
(closes #5605)
2018-12-16 16:34:53 -05:00
Bryan Housel 68a6421191 Add preset for Netball Court 2018-12-16 16:30:33 -05:00
greenkeeper[bot] 0b67629f10 chore(package): update rollup to version 0.68.0 2018-12-16 16:20:56 -05:00
Bryan Housel c6674449a3 Add diet: multicombo, put it in moreFields with the internet stuff
(closes #5580)
2018-12-16 14:40:28 -05:00
Bryan Housel 1a85f670c4 Merge pull request #5606 from RudyTheDev/additional-styles
Standing water fill pattern and water "barriers"
2018-12-15 10:31:49 -05:00
RudyTheDev 743be30a76 Use water fill pattern for fountain area 2018-12-15 16:33:06 +02:00
RudyTheDev dee530c8af Add groyne and breakwater stroke style 2018-12-15 16:16:36 +02:00
RudyTheDev 89a128f14c Allow directly specified fill pattern for entire tag (not using for anything as of yet) 2018-12-15 15:58:39 +02:00
RudyTheDev b92592b6b4 Add fill pattern for reservoir 2018-12-15 15:32:48 +02:00