Thomas Hervey
b3cffd7833
added simple keepRight button under photoItems
2018-12-19 13:12:49 -05:00
Bryan Housel
81b5fc788e
Merge pull request #5629 from openstreetmap/5587
...
5587 - make geolocation show geolocation
2018-12-19 12:14:36 -05:00
Bryan Housel
7db6133666
Merge pull request #5583 from quincylvania/field-prerequisite-tags
...
Mechanism for displaying fields conditionally based on tags
2018-12-19 12:08:15 -05:00
Max Grossman
b9ddfca152
implement point/puck geolocation
...
ref #5587
2018-12-19 11:06:41 -05:00
Quincy Morgan
6e1dd34447
Fixed an issue where a new container would be added in the Map Data pane every time a section was re-expanded
2018-12-18 15:55:50 -05:00
Bryan Housel
814c72fe42
Merge branch 'remote-presets' of https://github.com/radiant-maxar/iD into radiant-maxar-remote-presets
2018-12-18 15:15:11 -05:00
Max Grossman
b7f0d86da9
working on geolocate layer
...
ref #5587
2018-12-18 14:19:36 -05:00
Max Grossman
1471b55122
lint!
...
ref #5614
2018-12-18 12:02:26 -05:00
Max Grossman
ae9d43b0ac
remove double class
...
ref #5614
2018-12-18 11:16:37 -05:00
Max Grossman
18c021b5d5
add css
...
ref #5614
2018-12-18 11:09:26 -05:00
Max Grossman
0328e4f9da
add close button w/out css
...
ref #5614
2018-12-18 11:00:40 -05:00
Max Grossman
6ba8bacb75
use severity in test
2018-12-18 10:27:15 -05:00
Quincy Morgan
7e9082b9ff
Merge branch 'master' into field-prerequisite-tags
2018-12-18 09:33:46 -05:00
Max Grossman
d8de9e785e
do not add found presets to recent
2018-12-17 14:56:33 -05:00
Max Grossman
74a19a6d7f
remove a comment
2018-12-17 12:55:00 -05:00
Max Grossman
e0e6f5b918
remove non-used util class
2018-12-17 12:52:21 -05:00
Bryan Housel
43cea82d6f
Make sure when selecting to restore the sidebar to select mode
...
(closes #5603 )
2018-12-14 17:31:10 -05:00
Max Grossman
d87b1822f7
add/make visible weakly matched presets
2018-12-14 15:42:25 -05:00
Max Grossman
f627f1e659
make all presets visible on init!!
2018-12-14 13:29:17 -05:00
Quincy Morgan
a61cdc8208
Removed unused function
2018-12-13 17:29:59 -08:00
Quincy Morgan
a4b2924e4e
Merge branch 'master' into field-prerequisite-tags
2018-12-13 17:23:54 -08:00
Max Grossman
96e44be69c
merge 2.12.2
2018-12-13 11:22:32 -05:00
Max Grossman
f3e6459191
working on preset visibility
2018-12-13 11:16:24 -05:00
Bryan Housel
cd74e4e063
Fix broken member role dropdown for members that are not downloaded
...
(closes #5592 )
2018-12-12 16:53:20 -05:00
Bryan Housel
17615da0ea
Listen to both change and blur for role switcher, compare old v new
...
(closes #5449 )
2018-12-12 15:27:14 -05:00
Bryan Housel
e08bfb2add
Simplify accept/cancel event dispatchers, store datum in _choice
2018-12-12 15:26:18 -05:00
Bryan Housel
c635389c1a
Fix handling of semicolon delimited values in numeric field
...
(closes #5438 )
2018-12-12 01:11:34 -05:00
Bryan Housel
fc1f7e4d46
Trigger a change event when accepting combo option with return, tab
...
(closes #4900 , closes #5449 )
Some browsers need an explicit `change` event triggered on the input field
when a value has been changed by the combo and accepted by pressing return
or tab. This was only an issue on combos that aren't part of uiFields,
since the uiFields are all setup to respond to `change`,`input`,`blur` etc.
2018-12-11 23:25:47 -05:00
Bryan Housel
ec51ebb026
Fix flexbox of raw membership editor new row
...
(closes #5589 )
2018-12-11 21:54:25 -05:00
Bryan Housel
9aceb8f725
Fix lazy instantiation of the fields
...
They are shown either if `_show=true` or `isPresent()`
2018-12-11 19:01:23 -05:00
Bryan Housel
577e0c6503
Don't add "None" to imagery_used tag when other imagery was used
...
(closes #5565 )
2018-12-11 16:37:52 -05:00
Bryan Housel
0d958f04c1
Don't try to render a field that's not yet shown
2018-12-11 16:37:36 -05:00
Bryan Housel
39b3f1df68
Avoid creating comboboxes
...
(closes #5568 )
Several strategies in here:
- Move uiCombobox() from inside the render function to class variable
- Don't render stuff like the raw tag editor when it's collapsed
- Don't show as many fields/combos on hover
- Don't instantiate fields (like universal/more) until they're actually shown
- Bind the combo on enter selection not on update selection
2018-12-11 16:07:00 -05:00
Bryan Housel
222b3f1b04
Don't render contents of collapsed sections
...
(speeds things up if raw tag editor is hidden)
2018-12-11 15:19:29 -05:00
Bryan Housel
6732ca6eda
Comboboxes no longer show on focus.. update tests
2018-12-11 01:19:51 -05:00
Bryan Housel
ff646fa2c8
Dispatch a 'cancel' event if the user hits escape
2018-12-11 00:09:55 -05:00
Bryan Housel
6cf1d63b48
Make sure dropdown doesn't remain visible
...
(closes #5575 )
Also improves keyboard navigation, and adds some scrollintoview
workarounds to make sure that the selected option is visible
while also not causing the whole page to move.
2018-12-10 23:54:06 -05:00
Bryan Housel
15a54cab17
Use context.container instead of passing it in
2018-12-10 14:14:27 -05:00
Bryan Housel
e5dedeff8b
Move lib/d3.combobox.js -> ui/combobox.js
...
As with other things from this lib/ folder, little original code remains
and turning these things into reusable d3 plugins is not a priority.
2018-12-10 12:38:21 -05:00
Bryan Housel
5c9f9ac012
Always show save count 0.. makes responsivness easier
...
(closes #5576 )
2018-12-09 23:31:52 -05:00
Quincy Morgan
5471b909e2
Added mechanism for displaying fields conditionally based on tags
2018-12-09 20:11:31 -08:00
Quincy Morgan
4285f2f5c0
Added "moreFields" property to the field schema
...
The "Add field" dropdown can now be used to add preset-specific fields in addition to universal fields
2018-12-09 13:51:57 -08:00
Bryan Housel
cbcafaee15
Make sure sidebar is expanded before entering walkthrough or saving
...
(closes #5574 )
2018-12-08 10:03:43 -05:00
Bryan Housel
7fd06f69b8
Use .select instead of .selectAll to propagate the bound data
...
(closes #5573 )
2018-12-07 17:46:14 -05:00
Bryan Housel
d574bfcd77
Disable autocomplete on the localized field
...
(closes #5558 )
2018-12-07 17:19:02 -05:00
Bryan Housel
247900f727
Change several of the event things, remove numeric index
...
re: https://github.com/openstreetmap/iD/issues/5558#issuecomment-445307568
2018-12-07 16:54:32 -05:00
Bryan Housel
77a9dde6f7
Make sure combobox can always receive arrow and esc events
2018-12-05 15:59:06 -05:00
Bryan Housel
bee01d8497
Destroy all old background layer tooltips before making new ones
...
(closes #5551 )
2018-12-05 00:35:45 -05:00
Quincy Morgan
b366ace770
Switches from == to === in prior commit
2018-12-04 17:33:39 -08:00
Quincy Morgan
3cb2b8c901
Fixes an issue where the walkthrough would not display and cause an error
2018-12-04 17:29:19 -08:00