Commit Graph

43 Commits

Author SHA1 Message Date
Bryan Housel
cd74e4e063 Fix broken member role dropdown for members that are not downloaded
(closes #5592)
2018-12-12 16:53:20 -05:00
Bryan Housel
17615da0ea Listen to both change and blur for role switcher, compare old v new
(closes #5449)
2018-12-12 15:27:14 -05:00
Bryan Housel
fc1f7e4d46 Trigger a change event when accepting combo option with return, tab
(closes #4900, closes #5449)

Some browsers need an explicit `change` event triggered on the input field
when a value has been changed by the combo and accepted by pressing return
or tab.  This was only an issue on combos that aren't part of uiFields,
since the uiFields are all setup to respond to `change`,`input`,`blur` etc.
2018-12-11 23:25:47 -05:00
Bryan Housel
39b3f1df68 Avoid creating comboboxes
(closes #5568)

Several strategies in here:
- Move uiCombobox() from inside the render function to class variable
- Don't render stuff like the raw tag editor when it's collapsed
- Don't show as many fields/combos on hover
- Don't instantiate fields (like universal/more) until they're actually shown
- Bind the combo on enter selection not on update selection
2018-12-11 16:07:00 -05:00
Bryan Housel
15a54cab17 Use context.container instead of passing it in 2018-12-10 14:14:27 -05:00
Bryan Housel
e5dedeff8b Move lib/d3.combobox.js -> ui/combobox.js
As with other things from this lib/ folder, little original code remains
and turning these things into reusable d3 plugins is not a priority.
2018-12-10 12:38:21 -05:00
Bryan Housel
50d204866b Flexbox the raw member, membership controls, finish tag editor 2018-11-29 22:31:58 -05:00
Bryan Housel
958d7fac4f wip changing all fields to use flexbox everywhere 2018-11-28 18:15:38 -05:00
Bryan Housel
986b663c9e Get rid of extra form-label-button-wrap div
Buttons can now be directly appended to the form-field-label flex container
2018-11-27 09:14:11 -05:00
Quincy Morgan
b3e71c7522 Manual removal of the hover-highlight styling when clicking on a relation or member in the sidebar.
Closes #5521
2018-11-25 18:15:33 -05:00
Quincy Morgan
7bad67ff76 Flexbox preset field, member, and membership UI 2018-11-18 11:28:48 -05:00
Quincy Morgan
1161767932 Moves the entity highlighting function to util/util.js
Breaks out the code for getting a selector for entities and all their descendants into a generic function
Accounts for circular relations when recursively getting all relation member IDs
2018-10-26 18:39:01 -07:00
Quincy Morgan
ddb6e1b119 Fixes comments related to hover-highlighting 2018-10-24 22:27:37 -07:00
Quincy Morgan
81feb1cd99 Adds hover-highlighting for relations in the raw membership list
Moves hover-highlighting behavior to its own function
Hover-highlighting now correctly highlights all members of the target relation
2018-10-24 22:17:28 -07:00
Quincy Morgan
169a92df7c Fixes label button wrap on right-to-left layouts 2018-10-15 21:20:44 -07:00
Quincy Morgan
ffe38c7975 Adds a button to the relation member list item for zooming to the feature without selecting it
Adds "remove" tooltip to the delete relation member button
2018-10-15 20:41:45 -07:00
Quincy Morgan
b24256973f Makes relation members highlighted via hovering on list items more prominent 2018-10-13 23:04:35 -07:00
Quincy Morgan
cf1b391cf0 Adds highlighting of relation members in the map when hovering on their list item 2018-10-13 18:53:04 -07:00
Quincy Morgan
494ea13aac Adds the member type (node, way, or relation) to the label of non-downloaded relation members 2018-10-11 19:32:24 -07:00
Quincy Morgan
27158d77f3 Adds a button that lets users manually download individual relation members
Makes the map zoom to the chosen relation member if it is not currently visible
2018-10-10 20:36:53 -07:00
Bryan Housel
470835b38f Extract all graphics from iD sprite, reassemble with svg-sprite
All iD sprite graphics are now prefixed with `iD-`
Also includes support for sending the preset logos to taginfo
2018-06-08 16:06:46 -04:00
Bryan Housel
34cdab9197 uiDisclosure now handles expanded state in localStorage
Now all the places that use a uiDisclosure won't have to do that
2017-11-27 17:13:57 -05:00
Bryan Housel
3d13620705 Convert lodah-es and d3 to named imports for ui 2017-09-26 11:22:43 -04:00
Bryan Housel
ba97dde0f2 Limit members editor and memberships editor to 1000 entrires
(closes #3737)
2017-04-26 01:15:16 -04:00
Bryan Housel
5f44c9a00a Add combobox menus to id-container instead of document.body
(re: https://github.com/openstreetmap/iD/issues/3925#issuecomment-290718356)
2017-03-31 13:44:55 -04:00
Bryan Housel
2c11b693b8 Merge branch 'edit_menu' 2017-02-25 15:29:01 -05:00
Bryan Housel
e756520bd8 suppressMenu(true) is now the default 2017-02-21 15:47:22 -05:00
Bryan Housel
2314acfec7 Add utilNoAuto to remove autocorrect/spellcheck features from inputs
(closes #3839)
2017-02-14 17:19:24 -05:00
Bryan Housel
b9b7ef9748 Suppress menu when selecting entity from member/membership editor 2017-01-29 21:27:39 -05:00
Bryan Housel
9b7d79a3fe Use live bound object for presets object, change context.presets() getter 2016-11-14 15:44:02 -05:00
Bryan Housel
b93e9f1a1a Merge enter selection into update selection for raw member list
(closes #3524)
2016-10-26 11:31:19 -04:00
Bryan Housel
053074d076 Export live binding for services in iD.services, fix init/reset
(closes #3324)

Previously we allowed devs to swap out services that they didn't need.
This became difficult now that ES6 exports are immutable bindings.
But we can wrap the immutable bindings themselves in a live object,
to get back the flexibility that we used to have.

This change also drops the `taginfo` accessor on Context, since devs who want
to swap out taginfo service with something else can now do so through the live
binding.  `iD.services.taginfo = myTaginfo()`
2016-10-14 10:38:09 -04:00
Bryan Housel
07fa5fcc34 Refactor Entity, Node, Relation, Tags, Way from core to osm 2016-10-11 22:41:24 -04:00
Bryan Housel
84ba112ff4 Rebind clickhandler in update selection (bc it uses wrap selection) 2016-10-07 15:28:16 -04:00
Bryan Housel
3102a4ae6a Rename all the things to include pseudonamespaces 2016-10-04 19:06:20 -04:00
Bryan Housel
6346a11880 Continuing to audit enter/update selections that need merge() 2016-09-18 00:51:43 -04:00
Tom MacWright
ed135ce9ef Enable lib tests 2016-09-05 10:22:45 -04:00
Bryan Housel
a86f34b4ef Pacify eslint, get build and tests running again 2016-08-26 01:15:07 -04:00
Tom MacWright
cdb533fa84 Begin d3 v4 update 2016-08-21 15:19:27 -04:00
Minh Nguyễn
4ba0f43ee0 taginfo for relation roles
Enabled taginfo suggestions for roles on relation members and memberships.
2016-08-03 02:59:47 -07:00
Tom MacWright
af776501d3 Require locale, second pass (#3259)
* Require locale, second pass

* Remove t global, remove t where it isn't needed
2016-07-21 16:20:13 -04:00
Kushan Joshi
39c82af158 Sort modules [eslint rule] 2016-07-06 12:12:08 +05:30
Kushan Joshi
7188065a6c disband ui/core 2016-07-02 19:04:51 +05:30