Commit Graph

1282 Commits

Author SHA1 Message Date
Thomas Hervey
75cff00a2a displaying keep right (currently as notes) 2018-12-19 13:18:37 -05:00
Bryan Housel
81b5fc788e Merge pull request #5629 from openstreetmap/5587
5587 - make geolocation show geolocation
2018-12-19 12:14:36 -05:00
Bryan Housel
e1f26b5692 Merge pull request #5624 from ockendenjo/hat-route
Add more tests for splitting ways in relations containing loops
2018-12-19 12:10:12 -05:00
Max Grossman
399e7781c1 remove dispatched changes and re-order layers
ref #5587
2018-12-19 11:54:39 -05:00
Max Grossman
b010f42125 update layers test for new geolocate svg layer
ref #5587
2018-12-19 11:14:03 -05:00
ockendenjo
cec442012a Add test for route going round loop in other direction 2018-12-18 22:09:20 +00:00
ockendenjo
8aaa387d4e Add tests for hat route splitting #4876 2018-12-18 21:39:35 +00:00
Bryan Housel
5a2049b421 Drop extra whitespace, make sure service exists before using it 2018-12-18 15:38:53 -05:00
Max Grossman
6ba8bacb75 use severity in test 2018-12-18 10:27:15 -05:00
Max Grossman
64f2d913e8 remove unused entities from test 2018-12-17 17:39:47 -05:00
Max Grossman
8f33a85a12 make collection.index function to handle failing tests 2018-12-17 17:16:10 -05:00
Max Grossman
4475964401 hey, do not comment out tests! 2018-12-17 12:56:34 -05:00
Max Grossman
1b51b8bc57 adding tests and updating/fixing external presets logic 2018-12-14 13:23:58 -05:00
Max Grossman
c897331cd1 presets test w/build 2018-12-13 13:30:38 -05:00
Max Grossman
96e44be69c merge 2.12.2 2018-12-13 11:22:32 -05:00
Max Grossman
f3e6459191 working on preset visibility 2018-12-13 11:16:24 -05:00
Bryan Housel
222b3f1b04 Don't render contents of collapsed sections
(speeds things up if raw tag editor is hidden)
2018-12-11 15:19:29 -05:00
Bryan Housel
6732ca6eda Comboboxes no longer show on focus.. update tests 2018-12-11 01:19:51 -05:00
Bryan Housel
15a54cab17 Use context.container instead of passing it in 2018-12-10 14:14:27 -05:00
Bryan Housel
e5dedeff8b Move lib/d3.combobox.js -> ui/combobox.js
As with other things from this lib/ folder, little original code remains
and turning these things into reusable d3 plugins is not a priority.
2018-12-10 12:38:21 -05:00
Bryan Housel
247900f727 Change several of the event things, remove numeric index
re: https://github.com/openstreetmap/iD/issues/5558#issuecomment-445307568
2018-12-07 16:54:32 -05:00
Huon Wilson
dd0be84da4 Add one-sided triangular markers to ways with sides (e.g. natural=cliff).
This generalizes the oneway arrow logic for adding SVG markers along a
line. Using that functionality, certain tags get arrows on their
right-hand side, indicating which side is "inside", e.g. the
right-side of a cliff is the lower side.

The list of tags considered to be sided (unless there's a
two_sided=yes tag) is:

- natural=cliff
- natural=coastline
- barrier=retaining_wall
- barrier=kerb
- barrier=guard_rail
- barrier=city_wall
- man_made=embankment

The triangles attempt to be reminiscent of the triangles used for
rendering cliffs on OSM (and elsewhere). The different tags get
different renderings (e.g. colors that match the main way, and
different spacings). In addition, natural=coastline is special-cased
to have blue markers (despite having a green way), to emphasise that
the "inside" of a coastline is the water.

Fixes https://github.com/openstreetmap/iD/issues/1475.
2018-11-28 01:45:50 +11:00
Huon Wilson
f356c6ac49 test: add tests for adding oneway arrows to lines 2018-11-28 01:25:04 +11:00
Bryan Housel
9341e477a6 Merge remote-tracking branch 'origin/master' into brand-name-protection 2018-11-26 15:27:56 -05:00
J Guthrie
a23c975232 Fix specs 2018-11-24 21:27:20 +00:00
Bryan Housel
ea9e3008a5 addTags() -> setTags() / removeTags() -> unsetTags()
This avoids overriding the `addTags` and `removeTags` objects with functions
2018-11-21 12:59:43 -05:00
Bryan Housel
e3f5aecda9 Remove dataSuggestions and utilSuggestNames
- dataSuggestions was just a reexport of the name-suggestion-index
- utilSuggestNames was a combobox fetcher function used only once by uiFieldLocalized
    Doesn't need to be a util if it's only used once in the code
    and the tests for it were not really that interesting
2018-11-20 21:27:32 -05:00
Bryan Housel
1731ce4651 Partition viewport by tiles, not by pixels
(closes #4297)

The previous approach split the viewport up by pixels, but each time the view
moved, the pixels would change, so it was not a stable selection of the
streetview data, and the markers would fight for position as the user moved
around.

This approach uses utilTiler to partition the view into stable tiles.
2018-11-14 14:48:42 -05:00
Bryan Housel
152022aec4 Use context.keybinding for keybindings that don't change
(closes #5487)
2018-11-13 20:57:21 -05:00
Bryan Housel
bb30cbf555 Move lib/d3.keybinding.js -> util/keybinding.js
almost none of the original d3 "plugin" code remains
2018-11-13 13:42:09 -05:00
Bryan Housel
3bc841e95b Adjust layer ordering to draw touch targets above data layers 2018-11-09 21:48:45 -05:00
Bryan Housel
b7df3eda38 Use new Mapillary API calls for map_features, image_detections
(closes #5374)
2018-11-07 23:09:11 -05:00
Bryan Housel
a29af100df Remove test for unpopular values with a wiki page,
Restore test for unpopular keys with a wiki page
2018-11-07 11:06:48 -05:00
Mateusz Konieczny
e285066032 invert tests for inverted behavior 2018-11-03 15:07:37 +01:00
Mateusz Konieczny
bb054211c0 fix missing negation is specs 2018-11-03 14:26:52 +01:00
Bryan Housel
3e03102731 Simplify unpaved tag class logic, add tests
(re: #5422)
2018-10-31 16:13:03 -04:00
Bryan Housel
4cd442e09d Restore mapillary.js line endings back from CRLF -> CR, fix tests 2018-10-11 13:58:57 -04:00
Bryan Housel
0353b3110d Fix parse error in testing osm.js 2018-10-11 13:58:57 -04:00
Bryan Housel
1ffca3ce85 Switch crossing presets to "marked"/"unmarked", retain "zebra" as unsearchable 2018-10-02 17:01:04 -04:00
Max Grossman
622b7b9e0c move validations to its own class
ref #remote-presets
2018-10-01 21:45:21 -04:00
Max Grossman
0a31137c78 move maprules/mapcss to a service class
ref #remote-presets
2018-09-23 18:38:01 -04:00
Bryan Housel
5368aa1972 Update data layer tests to check for both shadow and stroke paths 2018-08-25 11:30:06 -04:00
Bryan Housel
0f07393fb3 Fix data file tests (in both phantom and real browsers) 2018-08-23 11:11:14 -04:00
Bryan Housel
575c98ab28 Accept both file and vector tile url templates from settings screen 2018-08-21 01:25:24 -04:00
Bryan Housel
4b446e9e78 WIP merge 'gpx' and 'mvt' layers into single 'data' layer 2018-08-17 13:03:07 -04:00
Max Grossman
8f9a281825 additional test tweaks
ref #remote-presets
2018-08-14 12:49:41 -04:00
Max Grossman
f168f85496 passing mapcss test w/out parser, use that on sever
ref #remote-presets
2018-08-10 09:16:59 -04:00
Max Grossman
3a0f8ddd09 infer geometries
ref #remote-presets
2018-08-08 13:21:35 -04:00
Bryan Housel
2e6799ac60 Don't reverse cardinal direction roles on relations anymore
re: https://github.com/openstreetmap/iD/pull/2004#issuecomment-407995998

Per thread https://twitter.com/bhousel/status/1025805098063208448
JOSM has stopped doing this too
2018-08-04 21:55:14 -04:00
Max Grossman
b93444de75 working on isArea-ish equivalent for mapcss selector objects
ref #remote-presets
2018-08-02 18:03:13 -04:00