Commit Graph

9840 Commits

Author SHA1 Message Date
Nicolas Decoster dd0a88c245 fix failing npm test 2018-01-15 11:17:51 +01:00
Bryan Housel 0382ce7d4b Updated function doc 2018-01-14 21:45:25 -05:00
Minh Nguyễn 33817af2b7 Describe relation in tooltip in add membership list 2018-01-14 13:19:35 -08:00
Bryan Housel 075b85c81d Apply reversal actions in actionJoin
(closes #4688)
2018-01-14 14:49:57 -05:00
Bryan Housel 8dbb6eb20c Return reversal actions performed by osmJoinWays
(see #4688)
2018-01-13 01:45:46 -05:00
Bryan Housel 0fd801d750 Prefer to join member ways in a way that preserves their order
(re #4589)

Strongly prefer to generate a forward path that preserves the order
of the members array. For multipolygons and most relations, member
order does not matter - but for routes, it does. If we started this
sequence backwards (i.e. next member way attaches to the start node
and not the end node), reverse the initial way before continuing.
2018-01-12 17:23:56 -05:00
Lukas Toggenburger 4544bbc1f5 Shorten label of field ref:isil=* 2018-01-12 17:31:05 +01:00
Lukas Toggenburger e8a68205ab Add ref:isil=* for libraries 2018-01-12 11:58:58 +01:00
Bryan Housel 8f6cb207fc Much expanded tests for osmJoinWays 2018-01-11 21:42:29 -05:00
Nicolas Decoster c796a9de12 Increase GPX labels readability 2018-01-10 15:42:56 +01:00
Bryan Housel 07262fa711 Add tests for #4589 2018-01-09 23:57:44 -05:00
Bryan Housel 748abdb950 Code formatting 2018-01-09 17:46:15 -05:00
Bryan Housel fdf1fa4fe7 Merge pull request #4675 from althio/master
remove addr:unit field for gb, ie, si, tr
2018-01-09 17:25:15 -05:00
Benoît 9ca0565f24 Merge pull request #1 from althio/althio-patch-addr_unit
remove addr:unit field for gb, ie, si, tr
2018-01-09 23:17:55 +01:00
Benoît b1df1ca701 remove addr:unit field for gb, ie, si, tr
as per comments in #4235
2018-01-09 23:17:37 +01:00
Bryan Housel 239bc8ffb9 Merge pull request #4670 from openstreetmap/greenkeeper/marked-0.3.12
Update marked to the latest version 🚀
2018-01-09 11:08:26 -05:00
Bryan Housel 528739b9b0 Drop unit from default address format 2018-01-09 10:15:18 -05:00
Bryan Housel f0a27bc1ec Simplify way segmentation and fix bug with adjacent segment type
(closes #4669)

Now instead of creating MultiLineString targets, we just create a bunch of
LineString targets.  This makes the code simpler, and anyway the entity is
still there in `properties` for drawing code to decide what to do with the target.

Incidentally, this change allows iD to support an extrusion operation.
(Because each way segment has its own unique GeoJSON target now)
2018-01-09 10:12:29 -05:00
Bryan Housel 4c61fadb18 Merge pull request #4671 from Andygol/patch-2
Remove addr:unit for addresses in Ukraine
2018-01-09 07:34:04 -05:00
Minh Nguyễn ea7339f49a Fixed geometry type word order
In many languages, the word for “closed” would follow the word for “line” or “area”, not precede it. Additionally, the word for “closed” may differ depending on what it modifies.
2018-01-09 03:30:14 -08:00
Andrey Golovin f339c57838 Remove addr:unit for addresses in Ukraine 2018-01-09 13:26:54 +02:00
Minh Nguyễn 702e3d2a90 DMS coordinates 2018-01-09 03:25:55 -08:00
Minh Nguyễn fe8c218fb3 Localized geocoded coordinate formatting 2018-01-09 02:24:03 -08:00
Minh Nguyễn a1e0d4fc08 Consolidated unit formatting into util module 2018-01-09 02:00:44 -08:00
Minh Nguyễn d75aa7d04a Internationalized measurement panel 2018-01-09 00:58:58 -08:00
Minh Nguyễn bc5cbc7dfd Generalized unit keys 2018-01-09 00:13:49 -08:00
Minh Nguyễn 1d8d7a74a3 Made scale legend localizable 2018-01-09 00:10:19 -08:00
greenkeeper[bot] fcb2a0aa85 fix(package): update marked to version 0.3.12 2018-01-09 00:20:41 +00:00
Bryan Housel e661281e38 Prevent self intersecting lines without a junction node
(closes #4646)
2018-01-08 19:17:50 -05:00
Bryan Housel 49eb46fefb Add epsilon parameter to geoVecEqual 2018-01-08 17:04:56 -05:00
Bryan Housel ea9643e08b Allow Alt/option key to disable geometry check and nope cursor
(re: #4646)
2018-01-08 15:47:29 -05:00
Bryan Housel 58eaca2aa0 Ignore area closing segment during move when validating geometry
(closes #4655)
2018-01-08 12:09:17 -05:00
Bryan Housel 66e8ce1363 Merge pull request #4667 from althio/patch-1
Restore address format for ["fr", "lu", "mo"]
2018-01-08 10:42:01 -05:00
Bryan Housel 45ffa3b731 Merge pull request #4658 from openstreetmap/fix_duplicate_saves
Fix duplicate upload bug, improve upload performance
2018-01-08 10:31:15 -05:00
Bryan Housel 8472f99347 Zooming out should not exit save mode
(closes #4664)
2018-01-08 09:49:32 -05:00
Benoît 6ec6c31948 Restore fr lu mo addressing
addr:unit is not standard in addressing for France
in France : 800 addr:unit / 4 000 000 addr:housenumber = 0,0002 (0,02%)

This partly reverts https://github.com/openstreetmap/iD/pull/4235/commits/de6b4fb6a20b2a3438b4159192e2b54682fab2e5 in https://github.com/openstreetmap/iD/pull/4235
2018-01-08 15:16:11 +01:00
Bryan Housel 1b973f3c9b Be more careful about enter/update selection in conflict resolution ui
This fixes one of the issues in #4351 where the radio button was not
selected. This was likely introduced during the upgrade to d3 v4, now
that enter selections do not automatically flow into update anymore.
(the fix is to add a `merge` to ensure that the `selection.each` actually
has some things to iterate over)
2018-01-07 23:46:54 -05:00
Bryan Housel 590487d237 Fix escape keybind when conflicts ui is active
(re: 4351)
2018-01-06 23:16:48 -05:00
Bryan Housel a22cfe64b8 Avoid loading circular relations by storing ids in _loaded object
(re: #3056)
2018-01-06 00:30:26 -05:00
Bryan Housel ac86869b4a Add conflict checking progress, guard code for user authentication 2018-01-05 18:11:49 -05:00
Bryan Housel a63c4a72fe Improvements to save flow
- Attempt fast save first, only perform conflict resolution if necessary (re: #3056)
- Block reentry of save, and dont keep focus on save button (closes #4641)
- Refactor modeSave() for code clarity (avoid shared state in closure variables)
2018-01-05 15:11:44 -05:00
Bryan Housel 437893ebb8 Don't reenter putChangeset, allow reuse of open changeset id
We are going to start trying an opportunistic save, then only
start the conflict resolution stuff if the server returns a 409.
Reusing an already open changeset makes sense in this situation.
2018-01-04 23:27:00 -05:00
Bryan Housel 8914d1ce36 Variable cleanups and formatting 2018-01-04 16:13:13 -05:00
Bryan Housel 954227be53 Don't let modal button cover up header bottom border 2018-01-04 16:12:40 -05:00
Bryan Housel 286c09366a Remove unused var (eslint) 2018-01-04 15:55:53 -05:00
Bryan Housel b2eb982044 Add support for oneway alternating/reversible to oneway check fields
Also allow checkbox field to display non-standard values
(i.e. not 'yes' or 'no) in the field label
2018-01-04 13:41:35 -05:00
Bryan Housel c908807f64 Render oneway=alternating, oneway=reversible with dual arrows
(closes #4291)
2018-01-04 13:40:49 -05:00
Bryan Housel 77ec49d959 Add some more building presets
(closes #4505)
2018-01-04 10:53:09 -05:00
Bryan Housel 1111c6b0c1 Fallback to event.keyCode if event.key is outside ISO-Latin-1
(closes #4618)
2018-01-03 23:37:35 -05:00
Bryan Housel 99a21d1117 Render points as vertices at zoom >= 18 (was > 18)
(closes #4642)
2018-01-03 16:52:29 -05:00