Commit Graph

910 Commits

Author SHA1 Message Date
Bryan Housel
4f0a608439 Merge pull request #5637 from openstreetmap/5618
fix autocomplete combobox bug
2018-12-26 15:15:29 -05:00
Yuri Astrakhan
9f7f4aa3fc Fix language fallback processing, caching bug. 2018-12-23 01:57:26 -05:00
Yuri Astrakhan
8b931f3e6c Use new message to encourage editing and translation 2018-12-22 15:03:22 -05:00
Yuri Astrakhan
b2810105a5 Implement support for multilingual descriptions from wiki data items
* Takes data directly from the Wikibase data items (OSM Wiki)
     https://wiki.openstreetmap.org/wiki/OpenStreetMap:Data_Items
* Understands the difference in regions - e.g. will show different
  images depending on the local settings
* Perf: Single request will get both the tag and key description
2018-12-22 00:23:31 -05:00
Bryan Housel
22e36be4f2 WIP on replacing documentation with direct calls to OSM wikibase 2018-12-22 00:23:31 -05:00
Quincy Morgan
7c192a2e36 Fixed bug where the entity ID could not be found for the field 2018-12-20 12:25:35 -05:00
Quincy Morgan
97c2361f43 Changed initial sidebar screen for highway intersection vertices from preset list to editor 2018-12-20 10:17:16 -05:00
Bryan Housel
62547e3459 Merge pull request #5638 from openstreetmap/5612
remove highlight from relation member after it is deleted from relation
2018-12-20 10:10:46 -05:00
Bryan Housel
e2c0f5edcd Merge pull request #5636 from openstreetmap/5596
open combobox if anywhere on box clicked...
2018-12-20 10:09:24 -05:00
Max Grossman
9a5a77f96c remove unneccessary space
ref #5612
2018-12-20 09:24:46 -05:00
Max Grossman
18c32511a2 remove member's highlight when removed from relation
ref #5612
2018-12-20 09:23:58 -05:00
Max Grossman
e3407d4168 do not use mouseover, use mousedown!
ref #5596
2018-12-20 09:05:23 -05:00
Max Grossman
2dab19e9ae default to value() if neither d and choice are null in the accept function
ref #5618
2018-12-20 08:52:16 -05:00
Max Grossman
5a1dfeec72 open combobox if anywhere on box clicked...
ref #5596
2018-12-20 08:47:37 -05:00
Quincy Morgan
cfbb86f88c Change the initial view of the sidebar on selection 2018-12-19 17:44:41 -05:00
Bryan Housel
81b5fc788e Merge pull request #5629 from openstreetmap/5587
5587 - make geolocation show geolocation
2018-12-19 12:14:36 -05:00
Bryan Housel
7db6133666 Merge pull request #5583 from quincylvania/field-prerequisite-tags
Mechanism for displaying fields conditionally based on tags
2018-12-19 12:08:15 -05:00
Max Grossman
b9ddfca152 implement point/puck geolocation
ref #5587
2018-12-19 11:06:41 -05:00
Quincy Morgan
6e1dd34447 Fixed an issue where a new container would be added in the Map Data pane every time a section was re-expanded 2018-12-18 15:55:50 -05:00
Bryan Housel
814c72fe42 Merge branch 'remote-presets' of https://github.com/radiant-maxar/iD into radiant-maxar-remote-presets 2018-12-18 15:15:11 -05:00
Max Grossman
b7f0d86da9 working on geolocate layer
ref #5587
2018-12-18 14:19:36 -05:00
Max Grossman
1471b55122 lint!
ref #5614
2018-12-18 12:02:26 -05:00
Max Grossman
ae9d43b0ac remove double class
ref #5614
2018-12-18 11:16:37 -05:00
Max Grossman
18c021b5d5 add css
ref #5614
2018-12-18 11:09:26 -05:00
Max Grossman
0328e4f9da add close button w/out css
ref #5614
2018-12-18 11:00:40 -05:00
Max Grossman
6ba8bacb75 use severity in test 2018-12-18 10:27:15 -05:00
Quincy Morgan
7e9082b9ff Merge branch 'master' into field-prerequisite-tags 2018-12-18 09:33:46 -05:00
Max Grossman
d8de9e785e do not add found presets to recent 2018-12-17 14:56:33 -05:00
Max Grossman
74a19a6d7f remove a comment 2018-12-17 12:55:00 -05:00
Max Grossman
e0e6f5b918 remove non-used util class 2018-12-17 12:52:21 -05:00
Bryan Housel
43cea82d6f Make sure when selecting to restore the sidebar to select mode
(closes #5603)
2018-12-14 17:31:10 -05:00
Max Grossman
d87b1822f7 add/make visible weakly matched presets 2018-12-14 15:42:25 -05:00
Max Grossman
f627f1e659 make all presets visible on init!! 2018-12-14 13:29:17 -05:00
Quincy Morgan
a61cdc8208 Removed unused function 2018-12-13 17:29:59 -08:00
Quincy Morgan
a4b2924e4e Merge branch 'master' into field-prerequisite-tags 2018-12-13 17:23:54 -08:00
Max Grossman
96e44be69c merge 2.12.2 2018-12-13 11:22:32 -05:00
Max Grossman
f3e6459191 working on preset visibility 2018-12-13 11:16:24 -05:00
Bryan Housel
cd74e4e063 Fix broken member role dropdown for members that are not downloaded
(closes #5592)
2018-12-12 16:53:20 -05:00
Bryan Housel
17615da0ea Listen to both change and blur for role switcher, compare old v new
(closes #5449)
2018-12-12 15:27:14 -05:00
Bryan Housel
e08bfb2add Simplify accept/cancel event dispatchers, store datum in _choice 2018-12-12 15:26:18 -05:00
Bryan Housel
c635389c1a Fix handling of semicolon delimited values in numeric field
(closes #5438)
2018-12-12 01:11:34 -05:00
Bryan Housel
fc1f7e4d46 Trigger a change event when accepting combo option with return, tab
(closes #4900, closes #5449)

Some browsers need an explicit `change` event triggered on the input field
when a value has been changed by the combo and accepted by pressing return
or tab.  This was only an issue on combos that aren't part of uiFields,
since the uiFields are all setup to respond to `change`,`input`,`blur` etc.
2018-12-11 23:25:47 -05:00
Bryan Housel
ec51ebb026 Fix flexbox of raw membership editor new row
(closes #5589)
2018-12-11 21:54:25 -05:00
Bryan Housel
9aceb8f725 Fix lazy instantiation of the fields
They are shown either if `_show=true` or `isPresent()`
2018-12-11 19:01:23 -05:00
Bryan Housel
577e0c6503 Don't add "None" to imagery_used tag when other imagery was used
(closes #5565)
2018-12-11 16:37:52 -05:00
Bryan Housel
0d958f04c1 Don't try to render a field that's not yet shown 2018-12-11 16:37:36 -05:00
Bryan Housel
39b3f1df68 Avoid creating comboboxes
(closes #5568)

Several strategies in here:
- Move uiCombobox() from inside the render function to class variable
- Don't render stuff like the raw tag editor when it's collapsed
- Don't show as many fields/combos on hover
- Don't instantiate fields (like universal/more) until they're actually shown
- Bind the combo on enter selection not on update selection
2018-12-11 16:07:00 -05:00
Bryan Housel
222b3f1b04 Don't render contents of collapsed sections
(speeds things up if raw tag editor is hidden)
2018-12-11 15:19:29 -05:00
Bryan Housel
6732ca6eda Comboboxes no longer show on focus.. update tests 2018-12-11 01:19:51 -05:00
Bryan Housel
ff646fa2c8 Dispatch a 'cancel' event if the user hits escape 2018-12-11 00:09:55 -05:00