John Firebaugh
7bbca76a20
Protect against relation loops ( fixes #2072 )
2014-01-02 17:42:57 -08:00
Adam Solove
2213b072dd
Clean up and test relation sorting code.
2013-12-10 22:39:37 -05:00
John Firebaugh
15590525d3
Fix build
2013-11-21 14:51:52 -08:00
tyr
2cf4c20a47
don't load parent multiple times into tree when multiple childs are changed
...
when an action (e.g. moving a way) caused multiple child elements
of the same parent to be changed, their parent was also loaded into
the tree multiple times during `tree.intersects()`.
this fixes #1978
2013-11-19 11:27:29 +01:00
John Firebaugh
b383bfec1f
Fix unclosed area rendering ( fixes #1958 )
2013-11-13 17:41:57 -08:00
John Firebaugh
492fc88aa4
Make the Graph#rebase argument an array
2013-10-31 16:24:31 -07:00
John Firebaugh
14bfc52e33
Remove repetition of entity IDs in tests
...
There were several places where the key and entity id
didn't match up.
2013-10-31 15:57:47 -07:00
John Firebaugh
ffdeef398d
Rewrite tree logic
...
The main problem with the existing logic was that it
did not update the extents of relations when previously incomplete members were loaded.
It was also overly stateful; the various queues and flags
are no longer required.
Fixes #1928 .
Fixes #1540 .
2013-10-28 16:57:18 -07:00
John Firebaugh
95e667d6b7
More tests
2013-10-28 16:34:08 -07:00
John Firebaugh
e0e08115e5
Pass entity array to Tree#rebase
2013-10-28 16:34:08 -07:00
John Firebaugh
e6d3cb242c
Clean up tests
2013-10-28 14:07:28 -07:00
John Firebaugh
fbf2118c76
Fix change summary calculation after restoring
...
We can't rely on identity equality here due to how
restoring works, and don't want to anyway -- the summary
should ignore net-no-op tag changes.
Fixes #1915 .
2013-10-23 17:35:35 -07:00
John Firebaugh
2de500a90a
Add a few more vertex cases to summary
2013-10-23 13:36:58 -07:00
John Firebaugh
697faf0265
Use summary to calculate # in Save button
2013-10-23 13:36:58 -07:00
John Firebaugh
b8e88a7aaf
Convert relevantChanges to a method on Difference
2013-10-23 13:36:58 -07:00
John Firebaugh
26e38d7f8f
Return geometries rather than features in asGeoJSON
...
No code needs the tags, and it eliminates one level
of function calls in the d3 stream pipeline.
2013-10-16 09:40:01 -04:00
John Firebaugh
81bc280aba
More reliable method for mutexed localStorage saves
...
Fixes #1883
2013-10-10 14:59:48 -07:00
John Firebaugh
a32ce33238
Add Way#affix
2013-08-30 13:59:29 -07:00
John Firebaugh
163c85bacb
Delete relations that become empty
...
Fixes #465
Fixes #1454
2013-08-27 12:27:11 -07:00
John Firebaugh
7215e91ff2
Ensure asGeoJSON returns winding orders expected by D3
2013-08-26 14:39:08 -07:00
John Firebaugh
a8f6c30a36
Fix test
2013-08-16 14:19:56 -07:00
John Firebaugh
2efafa087b
Deduplicate entities in serialized history
...
Fixes #1403
2013-08-14 16:49:53 -07:00
Vladimir Agafonkin
454eecae8f
replace RTree with RBush
2013-07-21 17:20:14 +03:00
John Firebaugh
3861879f62
Remove Connection#user and always use #userDetails
...
Because the embedded iD does not show the account
UI, Connection#userDetails was not being called, so
the commit UI didn't show the user name and image.
Fixes #1464
2013-06-14 13:06:13 -07:00
John Firebaugh
7ec1222402
Try to insert relation members at a sensible index ( #1539 )
2013-06-05 16:00:53 -07:00
John Firebaugh
2d7cc2a2d1
Preserve member order as much as possible
2013-06-05 16:00:12 -07:00
John Firebaugh
33cf029d43
Extract and refactor iD.geo.joinMemberWays
2013-06-05 16:00:12 -07:00
John Firebaugh
c14e2e600e
Fix strokes sometimes being clipped as polygons
...
Fixes #1527 .
2013-05-28 20:30:41 -07:00
John Firebaugh
16e5f5e2ce
Extract Entity#isUsed
2013-05-24 15:46:05 -07:00
John Firebaugh
1276672783
Add iD.actions.DeleteMember
2013-05-22 17:37:26 -07:00
John Firebaugh
ee4ec4e252
Fix tests
2013-05-22 17:36:41 -07:00
John Firebaugh
affdc987e4
Rename removeMember -> removeMembersWithID
2013-05-22 17:28:51 -07:00
John Firebaugh
bf21744077
Only draw intersections for {high,water,rail,aero}way lines
...
Fixes #1471
2013-05-20 17:16:36 -07:00
John Firebaugh
1db99586c4
Render only new features when a data tile is loaded
2013-05-20 12:05:31 -07:00
John Firebaugh
293bb23876
Graph#rebase must invalidate transients
2013-05-18 09:20:57 -07:00
John Firebaugh
2e4207f99b
Cache geometry
2013-05-17 15:31:27 -07:00
John Firebaugh
6431fca8a3
Fix area caching ( fixes #1485 )
2013-05-14 16:52:02 -07:00
John Firebaugh
6060e886cb
Reduce calls to iD.svg.TagClasses
...
For fills and shadows, style changes can happen only when
a new version of the feature is produced. If we include a
version number in the key, we need only call TagClasses on
the enter selection.
We cannot apply the same optimization for strokes, since
stroke style can depend on the tags of parent relations
as well.
2013-05-13 09:37:48 -07:00
Ansis Brammanis
2fa8ca174f
add test case for stale tree bug, a0e8292
2013-04-24 19:41:23 -04:00
John Firebaugh
c50c3121d8
Make Graph#entity strict
...
Use Graph#hasEntity for the previous behavior.
2013-04-24 09:27:37 -07:00
John Firebaugh
765fedef15
Omit changeset comment if empty ( fixes #1360 )
2013-04-22 12:09:22 -07:00
John Firebaugh
c8dcba31ad
Auto-zoom to entity specified by id param
2013-04-18 14:24:10 -07:00
Ansis Brammanis
c6200931e1
update tests for iD.Difference fix
2013-04-18 17:02:19 -04:00
John Firebaugh
dca9bec450
Move Connection to core
2013-04-17 17:35:34 -07:00
John Firebaugh
94e2c8d8d6
Prevent duplicate consecutive nodes ( #1296 )
2013-04-12 10:55:53 -04:00
John Firebaugh
05c659bdd7
Render oneway arrows for junction=roundabout ( fixes #1255 )
2013-04-05 12:27:36 -07:00
John Firebaugh
7100054707
Use preset names in commit dialog
2013-04-01 08:33:07 -07:00
John Firebaugh
f7fb12be76
Fix #1120 , inconsistent undo for line/area drawing
...
Gulp!
2013-03-27 16:25:10 -07:00
Ansis Brammanis
2b4e260953
walkthrough now runnable in the middle of editing
...
history.toJSON and .fromJSON are now split out of.
history.save and .restore.
2013-03-27 11:52:50 -04:00
John Firebaugh
4720a84d38
No-op a null tag merge
...
Reduces unnecessary node churn in Connect action.
2013-03-12 16:26:40 -07:00
