Commit Graph

671 Commits

Author SHA1 Message Date
Quincy Morgan 2eff493d37 Add outdated tags validation issue subtype for noncanonical brands
Add specific warning message for noncanonical brands (close #6443)
Don't allow autofixing noncanonical brand issues
2019-06-10 11:39:42 -04:00
Quincy Morgan 5f0f77cc2c Fix typo 2019-06-06 14:53:08 -04:00
Quincy Morgan d0ae7815bb Adjust the strings for the invalid formatting validation (re: #6494) 2019-06-06 13:55:54 -04:00
SilentSpike 591e41f5ec Fix email and website validation for list values
Also improved the UI message to be more clear for websites and simplify
"is tagged with" to "has" which works in context.
2019-06-06 13:55:53 -04:00
SilentSpike 770cffe7de Add email and website format validation
Simple validation following the HTML5 standard for emails as we don't
expect POIs to have convoluted email addresses. Only checks the
`website` and `email` tags as these are what iD currently supports with
fields.
2019-06-06 13:55:53 -04:00
Quincy Morgan 28db4df86b Flag detached points that are very close together (close #6394)
Fix lint error
2019-05-22 15:50:20 -04:00
Quincy Morgan 030b4b3efa Flag almost junctions between highways and themselves (close #6373) 2019-05-22 14:12:23 -04:00
Quincy Morgan 854eacdc7e Add feature filters for pistes and aerialways 2019-05-22 10:38:04 -04:00
Quincy Morgan 96c0dbde98 Update label and tooltips for indoor features and building parts (re: #6352) 2019-05-22 09:59:24 -04:00
Quincy Morgan 76b98f14e0 Merge pull request #6352 from tordans/filder-for-building-part-and-indoor
Add filter building:part and indoor
2019-05-22 09:47:45 -04:00
Quincy Morgan 82ab18dd8b Show better warning message if tags and incomplete rather than deprecated (close #6410) 2019-05-22 09:38:47 -04:00
Bryan Housel f062570eef Merge pull request #6376 from openstreetmap/routing-island-validation
Flag routing islands
2019-05-17 10:21:51 -04:00
Bryan Housel 94c5164fe2 Add ability to show the square threshold in the rule name 2019-05-17 02:15:20 -04:00
Quincy Morgan e697bdbeb1 Flag disconnected ferry routes
Flag disconnected highway multipolygon outer member ways
Let routing islands cross ferry routes
2019-05-17 00:15:53 -04:00
Quincy Morgan 07bc2821cd Flag entire routing islands as single issues 2019-05-16 22:40:25 -04:00
Tobias Jordans 35a2301ea3 Add filter building:part and indoor
- Extract the building:part from the building filter into it's own filter
- Add indoor filtering
- Update api doc
2019-05-12 19:31:23 +02:00
Quincy Morgan 8de10def2a Use actionMergeNodes instead of operationMerge for the very close nodes issue fix (close #6343) 2019-05-10 09:12:11 -04:00
Quincy Morgan 0e7a63f5c5 Add quick fix to unsquare way validation to tag a way as having unsquare corners (close #6332) 2019-05-09 12:04:18 -04:00
Bryan Housel 79149ffad2 Adjust the "unsquare corners" message per feedback
https://twitter.com/williamscraigm/status/1125589440317968384
(Not that the building should be literally square, just the corners of the building)
2019-05-07 18:19:48 -04:00
Quincy Morgan 97cb90b562 Make issue messages dynamic (close #6331) 2019-05-07 14:48:30 -04:00
Bryan Housel 77801a3ecd Merge pull request #6284 from Bonkles/id-5869
Improve validation for disconnected highways #5869
2019-05-05 22:17:12 -04:00
Bryan Housel 8f9dc7afb4 Improve localization of "Thank you for editing the map around.."
(closes #6269)
2019-05-04 13:24:46 -04:00
Quincy Morgan 4afd071a00 Add "Connect this feature" fix to disconnected ways if continuing drawing isn't possible 2019-05-03 12:59:18 -07:00
Quincy Morgan dbc3978d71 Add non-actionable fix recommendation to move very close points apart 2019-05-03 12:15:26 -07:00
Quincy Morgan b4dacdad2a Reduce very close nodes validation threshold (close #6292)
Use spherical distances for very close nodes validation
Don't flag very close nodes from different ways
Don't flag very close nodes if both have interesting tags
Update very close nodes validation reference string
2019-05-02 11:39:12 -07:00
Quincy Morgan d061ec6b61 Don't add ignore fix more than once
Tweak hidden issues text
2019-05-01 20:21:47 -07:00
Quincy Morgan 712f8bcb03 Avoid having hidden issues strings for both singular and multiple variations 2019-05-01 20:13:09 -07:00
Quincy Morgan eeaad79cb1 Display info about hidden issues in the "no issues" UI 2019-05-01 14:50:56 -07:00
Benjamin Clark ec01933d84 Disconnected highways will now be warning flagged only if unattached to existing highways. 2019-05-01 17:42:23 -04:00
Quincy Morgan 1c15338bd5 Make reset ignored button consistent with enable/disable all rules buttons 2019-05-01 12:13:10 -07:00
Quincy Morgan 52d92f125c Add button to reset ignored issues
Don't cache issue extent
2019-04-30 16:32:36 -07:00
Quincy Morgan 26f1e29072 Merge branch 'master' into ignoring-issues
# Conflicts:
#	data/core.yaml
#	dist/locales/en.json
2019-04-30 13:05:07 -07:00
Quincy Morgan 942d55a4bf Update strings for duplicate node validation
Use routable highway tags for duplicate node validation instead of any highway tag
2019-04-30 10:18:22 -07:00
Ming Gao 18dff285d0 add validation for very close node on road
addresses issue #6241

also made a change in inspector, so that when an untagged entity has issues,
show the entity editor so that the issues are visible when an item is clicked
in the issues pane.
2019-04-29 22:59:27 -04:00
Bryan Housel f9eacc9507 Fix typo "segements" -> "segments" 2019-04-29 21:03:05 -04:00
Quincy Morgan 375779882d Add ability to ignore warnings
Replace issue's array of entities with array of entity IDs
Improve issue ID hashing
2019-04-29 17:52:32 -07:00
Quincy Morgan ecc217f5d8 Add validation rule to flag impossible oneway highways and waterways (close #6216) 2019-04-26 12:04:43 -07:00
Quincy Morgan 42de00e640 Add validation warning for "fixme" tags (close #6214) 2019-04-24 16:59:57 -07:00
Quincy Morgan aa91c2d768 Move old multipolygon warning into Outdated Tags rule (close #6218) 2019-04-24 15:46:50 -07:00
Quincy Morgan 13f7e536dc Move highway=road validation warning to the missing_tag validation rule (re: #6218) 2019-04-24 15:19:57 -07:00
Bryan Housel 862eca9ddd Update shortcut screen straighten text too 2019-04-24 01:58:19 -04:00
Bryan Housel 05949608aa Support straightening of points
(closes #6217)

- Split `actionStraighten` into `actionStraightenWay` and `actionStraightenNodes`
- Now `operationStraighten` chooses the correct action depending on selected entities
- Also move `getSmallestSurroundingRectangle` from `actionReflect` to `geo.js`
2019-04-24 01:55:43 -04:00
Quincy Morgan 34fcd01f98 Add validation warning for unsquare buildings 2019-04-23 15:50:52 -07:00
Bryan Housel 7e04175559 Add Enable All / Disable All validation rules links
(closes #5986)
2019-04-23 13:01:15 -04:00
Bryan Housel bd2a33d845 Merge branch 'validation_and_change_perf' 2019-04-23 01:30:26 -04:00
Quincy Morgan e04d860f62 Convert "Detach" operation into "Extract" operation that also works on areas (close #6203) 2019-04-22 14:46:01 -07:00
Bryan Housel 3557e3c711 Don't allow disconnecting a way if parts extend to undownloaded tiles
(re: #2248, #4245)
2019-04-20 00:02:46 -04:00
Bryan Housel 7c85cc997e Merge branch 'master' into validation_and_change_perf 2019-04-19 22:44:04 -04:00
Quincy Morgan b566ef05b5 Add Option+W shortcut to toggle the OSM data layer (close #6104) 2019-04-19 14:51:53 -07:00
Bryan Housel 51c1088c1b Merge branch 'master' into validation_and_change_perf 2019-04-19 15:18:23 -04:00