Commit Graph

11493 Commits

Author SHA1 Message Date
Bryan Housel 7e36ed0d93 Close seams in corners of highlighting strokes
(closes #6336)
2019-05-08 13:53:48 -04:00
Quincy Morgan 3e7472e42f Use fence_type=wire instead of fence_type=chain when upgrading barrier=wire_fence 2019-05-08 12:35:22 -04:00
Quincy Morgan 79f9e82b12 Add derived data for prior merge 2019-05-08 12:19:47 -04:00
Quincy Morgan 9b5cf50f17 Merge pull request #6337 from westnordost/patch-1
create highway=emergency_bay preset
2019-05-08 12:17:47 -04:00
Quincy Morgan 760134c2aa Add check for possible missing activeEntity in drag_node 2019-05-08 12:17:36 -04:00
Tobias Zwick 6849a2fb41 limit to vertices, change name, add icon 2019-05-08 18:16:01 +02:00
Tobias Zwick 0df764b1a7 use correct extension 2019-05-08 16:51:21 +02:00
Quincy Morgan bafc0da99c Force child nodes visible when forcing a way visible (close #6328) 2019-05-08 10:50:21 -04:00
Tobias Zwick b06a75993d create highway=emergency_bay preset 2019-05-08 16:42:56 +02:00
Quincy Morgan 3a78cf512c Move connect ways fix to its own function
Make the edges and connection tags part of the crossing ways issue ID
2019-05-08 10:32:25 -04:00
Bryan Housel 41f3bb9c07 Only include relation members that are visible, if extent supplied
followup to b0d5f0dd4
2019-05-08 09:23:04 -04:00
Bryan Housel b0d5f0dd48 Include multipolygon members in complete()
(closes #3613)
2019-05-08 00:49:33 -04:00
Bryan Housel 79149ffad2 Adjust the "unsquare corners" message per feedback
https://twitter.com/williamscraigm/status/1125589440317968384
(Not that the building should be literally square, just the corners of the building)
2019-05-07 18:19:48 -04:00
Bryan Housel 289c75fee1 When showing tooltip, update disabled in case disabled states disagree
(closes #6296)
2019-05-07 17:53:22 -04:00
Bryan Housel 58cae43b9b Use parentNode instead of parentElement for IE 2019-05-07 17:48:56 -04:00
Quincy Morgan 3d9f7244f0 Update issue messages after merge instead of by invalidating issues 2019-05-07 16:38:08 -04:00
Bryan Housel 4ee58887af Update dependencies
(closes #6329, closes #6330)
2019-05-07 16:17:03 -04:00
SilentSpike 5af7e86ef4 Fix findIssues test for dynamic issue messages 2019-05-07 20:43:27 +01:00
Quincy Morgan 73467d53b4 Don't flag highways connected to amenity=parking_entrance nodes as disconnected
Don't flag oneways with entrance endpoints as impossible
2019-05-07 14:55:57 -04:00
Quincy Morgan 97cb90b562 Make issue messages dynamic (close #6331) 2019-05-07 14:48:30 -04:00
Quincy Morgan 5160754dcc Display issues for disabled rules in the commit UI
Allow errors for disabled rules to block upload
Include warnings for disabled rules in the changeset tags (re: #6325)
2019-05-07 13:07:31 -04:00
Quincy Morgan 4a379480ad Merge branch 'master' of https://github.com/openstreetmap/iD 2019-05-07 12:29:11 -04:00
Quincy Morgan fd35e10aa7 Make the very close nodes validation work for any way (close #6326) 2019-05-07 12:28:59 -04:00
Bryan Housel 901cab57da Remove _disabled caches for operations
(re: #6296, reverts 81127d7)
see https://github.com/openstreetmap/iD/issues/6296#issuecomment-489259027
(I'll find another way to deal with the menu not matching the tooltip)
2019-05-07 10:32:12 -04:00
Bryan Housel d3a53309b7 Allow uppercase taginfo results for _ref tags
(closes #6324)
2019-05-07 09:32:13 -04:00
Bryan Housel 966f5c3586 Add explicit validation calls to each operation
This is cleaner than adding hooks to transitionable actions, or performing validation
on every history change.  We want validation to run after each operation, but not
while the user is drawing lines or typing in fields.
2019-05-06 14:49:46 -04:00
Bryan Housel 7551dd9093 fix typo 2019-05-06 13:04:00 -04:00
Bryan Housel e3ea4b8484 Additional improvements to unsquare_way validation
(re: #6288)

- use default params for actionOrthogonalize, not relaxed epsilon
- only allow autofix if there are no extra tags on the building (e.g. source)
2019-05-06 12:58:40 -04:00
Quincy Morgan faf86d961a Add initial 2.15.0 changelog based mostly on issues in the milestone 2019-05-06 11:06:36 -05:00
Bryan Housel 4608e9598c Adjust thresholds for unsquare_way detection
(re: #6288)

I'd like to keep the angle threshold the same as what the action does
for UI consistency, but use a larger epsilon, so that fewer nearly-orthogonal
errors are reported.

With previous constants, it was strange that very orthogonal buildings
were being flagged, and very not-orthogonal buildings were not.
2019-05-06 11:42:57 -04:00
Bryan Housel 59c34e2537 Perform orthagonalization fixes without a transition
We can just set `action.transitionable = false` to make the action instant.
Also removes the `onCompletion` handlers. They shouldn't really be needed,
because the validator will run after the fix is applied (and at other times).
2019-05-06 10:23:30 -04:00
Bryan Housel 26db518dcc Add icon for natural=glacier, use tractor icon for landuse=farmland 2019-05-05 23:46:04 -04:00
Bryan Housel 4c53c5a72c npm run build for new presets 2019-05-05 23:11:52 -04:00
Bryan Housel 5f9bea67da Render more areas in dark grey (rocks, cave entrances, cliffs, etc) 2019-05-05 23:11:33 -04:00
Bryan Housel c320e9f9de Remove extra "cave entrance" from natural catetory 2019-05-05 23:11:12 -04:00
Bryan Housel 02f837ccb4 Add more search terms for the "Road Surface" preset
(closes #6309)
2019-05-05 23:10:30 -04:00
Bryan Housel 77801a3ecd Merge pull request #6284 from Bonkles/id-5869
Improve validation for disconnected highways #5869
2019-05-05 22:17:12 -04:00
Bryan Housel 4d7bc54eb4 Upgrage to rollup 1.11.3
(closes #6303)
2019-05-05 19:08:10 -04:00
Bryan Housel 6d1e546607 Fix "Summit Cross" capitalization, npm run build for new presets 2019-05-05 18:43:06 -04:00
Bryan Housel 0647ef9aac Merge pull request #6321 from westnordost/presets-castles
add castle-related presets
2019-05-05 18:38:11 -04:00
Tobias Zwick 60bdaef999 add castle-related presets 2019-05-05 23:52:01 +02:00
Bryan Housel 659240d9fa Disclosure should unhide before rendering content
(closes #6312)

In case something in the content can't cope with `display: none`
2019-05-05 15:56:56 -04:00
Bryan Housel 66e4564ae7 Adjust zoo type icons 2019-05-05 00:07:43 -04:00
Bryan Housel 1a820e48da Adjust preset names for natural=rock natural=stone 2019-05-04 23:48:10 -04:00
Bryan Housel a266a4d0ec Merge pull request #6311 from westnordost/presets-rock-stone
Add preset for natural=rock
2019-05-04 23:24:34 -04:00
Bryan Housel a5a93e1740 Merge pull request #6313 from westnordost/presets-wastewater-pool
add preset for water=wastewater
2019-05-04 23:20:56 -04:00
Bryan Housel 8ed3715993 Merge pull request #6314 from westnordost/presets-fire-hose
add preset for fire hose
2019-05-04 23:20:06 -04:00
Bryan Housel bde5b24fcf Merge pull request #6315 from westnordost/presets-ambulatory_care
add ambulatory_care preset
2019-05-04 23:19:44 -04:00
Bryan Housel 8a3b2daf96 Merge pull request #6316 from westnordost/presets-crafts
add joiner, floorer, agricultural engine mechanic and parquet layer crafts
2019-05-04 23:19:25 -04:00
Bryan Housel 6b64ed15fe Merge pull request #6317 from westnordost/presets-zoo
add some zoo types presets
2019-05-04 23:18:41 -04:00