Quincy Morgan
8de10def2a
Use actionMergeNodes instead of operationMerge for the very close nodes issue fix ( close #6343 )
2019-05-10 09:12:11 -04:00
Quincy Morgan
ad744a75ef
Use "nonsquare" instead of "nosquare" for marking unsquare ways as physically unsquare (re: #6332 )
2019-05-09 19:11:11 -04:00
Quincy Morgan
05b77318ab
Add Horseshoes Pit and Shuffleboard Court presets
2019-05-09 18:43:21 -04:00
Quincy Morgan
7b441ab766
Don't flag unsquare buildings connected to building multipolygons
2019-05-09 18:06:40 -04:00
Quincy Morgan
58e6afd3ea
Don't flag very close nodes in boundaries
2019-05-09 17:50:22 -04:00
Quincy Morgan
f264cc47f0
Don't flag almost junctions when endpoint is building or parking entrance
...
Include issues for disabled rules in entity issues
2019-05-09 14:38:19 -04:00
Quincy Morgan
0e7a63f5c5
Add quick fix to unsquare way validation to tag a way as having unsquare corners ( close #6332 )
2019-05-09 12:04:18 -04:00
Bryan Housel
5e21cec469
Swap ecstatic for StaticServer
...
(closes #6342 )
2019-05-09 11:14:43 -04:00
Bryan Housel
8bad3e2f4b
Update icon for height restrictor, npm run build for new presets
2019-05-09 10:12:51 -04:00
Bryan Housel
34b6625d80
Merge pull request #6339 from westnordost/preset-height-restrictor
...
add height restrictor preset
2019-05-09 10:04:16 -04:00
Bryan Housel
83703ffe55
Merge pull request #6340 from westnordost/preset-chain
...
add barrier=chain preset
2019-05-09 10:03:53 -04:00
Bryan Housel
0767dd325f
npm run imagery
...
so people can test DigitalGlobe-Vivid
https://github.com/osmlab/editor-layer-index/pull/655
2019-05-09 09:59:45 -04:00
Quincy Morgan
399b9be006
Don't flag very close nodes in ways with too few nodes, indoor ways, and very small ways
2019-05-08 17:15:18 -04:00
Quincy Morgan
dcd9876fdf
Use thinner partial fills for buildings parts and indoor features (re: #6204 )
2019-05-08 15:55:59 -04:00
Quincy Morgan
fd8f460739
Don't flag oneway highways that connect to highway areas or ferry routes as impossible
...
Don't flag oneway waterways that connect to springs, storm drains, water bodies, or coastlines as impossible
2019-05-08 15:36:37 -04:00
Quincy Morgan
1d797b8fc6
Validate connected ways when validating a way to avoid stale connectivity issues ( close #6335 )
2019-05-08 14:56:49 -04:00
Bryan Housel
86c6805cf7
Optionally include ids members of modified relations in extantIDs
...
(closes #6273 )
2019-05-08 13:53:48 -04:00
Bryan Housel
7e36ed0d93
Close seams in corners of highlighting strokes
...
(closes #6336 )
2019-05-08 13:53:48 -04:00
Quincy Morgan
3e7472e42f
Use fence_type=wire instead of fence_type=chain when upgrading barrier=wire_fence
2019-05-08 12:35:22 -04:00
Quincy Morgan
79f9e82b12
Add derived data for prior merge
2019-05-08 12:19:47 -04:00
Quincy Morgan
9b5cf50f17
Merge pull request #6337 from westnordost/patch-1
...
create highway=emergency_bay preset
2019-05-08 12:17:47 -04:00
Quincy Morgan
760134c2aa
Add check for possible missing activeEntity in drag_node
2019-05-08 12:17:36 -04:00
Tobias Zwick
6849a2fb41
limit to vertices, change name, add icon
2019-05-08 18:16:01 +02:00
Tobias Zwick
9847a0d076
add barrier=chain preset
2019-05-08 17:42:07 +02:00
Tobias Zwick
037c22f161
add height restrictor preset
2019-05-08 17:34:48 +02:00
Tobias Zwick
0df764b1a7
use correct extension
2019-05-08 16:51:21 +02:00
Quincy Morgan
bafc0da99c
Force child nodes visible when forcing a way visible ( close #6328 )
2019-05-08 10:50:21 -04:00
Tobias Zwick
b06a75993d
create highway=emergency_bay preset
2019-05-08 16:42:56 +02:00
Quincy Morgan
3a78cf512c
Move connect ways fix to its own function
...
Make the edges and connection tags part of the crossing ways issue ID
2019-05-08 10:32:25 -04:00
Bryan Housel
41f3bb9c07
Only include relation members that are visible, if extent supplied
...
followup to b0d5f0dd4
2019-05-08 09:23:04 -04:00
Bryan Housel
b0d5f0dd48
Include multipolygon members in complete()
...
(closes #3613 )
2019-05-08 00:49:33 -04:00
Bryan Housel
79149ffad2
Adjust the "unsquare corners" message per feedback
...
https://twitter.com/williamscraigm/status/1125589440317968384
(Not that the building should be literally square, just the corners of the building)
2019-05-07 18:19:48 -04:00
Bryan Housel
289c75fee1
When showing tooltip, update disabled in case disabled states disagree
...
(closes #6296 )
2019-05-07 17:53:22 -04:00
Bryan Housel
58cae43b9b
Use parentNode instead of parentElement for IE
2019-05-07 17:48:56 -04:00
Quincy Morgan
3d9f7244f0
Update issue messages after merge instead of by invalidating issues
2019-05-07 16:38:08 -04:00
Bryan Housel
4ee58887af
Update dependencies
...
(closes #6329 , closes #6330 )
2019-05-07 16:17:03 -04:00
SilentSpike
5af7e86ef4
Fix findIssues test for dynamic issue messages
2019-05-07 20:43:27 +01:00
Quincy Morgan
73467d53b4
Don't flag highways connected to amenity=parking_entrance nodes as disconnected
...
Don't flag oneways with entrance endpoints as impossible
2019-05-07 14:55:57 -04:00
Quincy Morgan
97cb90b562
Make issue messages dynamic ( close #6331 )
2019-05-07 14:48:30 -04:00
Quincy Morgan
5160754dcc
Display issues for disabled rules in the commit UI
...
Allow errors for disabled rules to block upload
Include warnings for disabled rules in the changeset tags (re: #6325 )
2019-05-07 13:07:31 -04:00
Quincy Morgan
4a379480ad
Merge branch 'master' of https://github.com/openstreetmap/iD
2019-05-07 12:29:11 -04:00
Quincy Morgan
fd35e10aa7
Make the very close nodes validation work for any way ( close #6326 )
2019-05-07 12:28:59 -04:00
Bryan Housel
901cab57da
Remove _disabled caches for operations
...
(re: #6296 , reverts 81127d7 )
see https://github.com/openstreetmap/iD/issues/6296#issuecomment-489259027
(I'll find another way to deal with the menu not matching the tooltip)
2019-05-07 10:32:12 -04:00
Bryan Housel
d3a53309b7
Allow uppercase taginfo results for _ref tags
...
(closes #6324 )
2019-05-07 09:32:13 -04:00
Bryan Housel
966f5c3586
Add explicit validation calls to each operation
...
This is cleaner than adding hooks to transitionable actions, or performing validation
on every history change. We want validation to run after each operation, but not
while the user is drawing lines or typing in fields.
2019-05-06 14:49:46 -04:00
Bryan Housel
7551dd9093
fix typo
2019-05-06 13:04:00 -04:00
Bryan Housel
e3ea4b8484
Additional improvements to unsquare_way validation
...
(re: #6288 )
- use default params for actionOrthogonalize, not relaxed epsilon
- only allow autofix if there are no extra tags on the building (e.g. source)
2019-05-06 12:58:40 -04:00
Quincy Morgan
faf86d961a
Add initial 2.15.0 changelog based mostly on issues in the milestone
2019-05-06 11:06:36 -05:00
Bryan Housel
4608e9598c
Adjust thresholds for unsquare_way detection
...
(re: #6288 )
I'd like to keep the angle threshold the same as what the action does
for UI consistency, but use a larger epsilon, so that fewer nearly-orthogonal
errors are reported.
With previous constants, it was strange that very orthogonal buildings
were being flagged, and very not-orthogonal buildings were not.
2019-05-06 11:42:57 -04:00
Bryan Housel
59c34e2537
Perform orthagonalization fixes without a transition
...
We can just set `action.transitionable = false` to make the action instant.
Also removes the `onCompletion` handlers. They shouldn't really be needed,
because the validator will run after the fix is applied (and at other times).
2019-05-06 10:23:30 -04:00