CalvinBackup/iD
1
0
Fork 0
mirror of https://github.com/FoggedLens/iD.git synced 2026-02-14 09:42:56 +00:00
Code Issues Packages Projects Releases Wiki Activity
11,341 Commits 2 Branches 0 Tags
942d55a4bfbbfec8300704309cd8a7e02a6f99b7
Commit Graph

2774 Commits

Author SHA1 Message Date
Quincy Morgan
942d55a4bf Update strings for duplicate node validation 
Use routable highway tags for duplicate node validation instead of any highway tag
 2019-04-30 10:18:22 -07:00
Quincy Morgan
ddae6641b3 Fix issue where preset list would not appear when adding new features (close #6271) 2019-04-30 09:42:24 -07:00
Bryan Housel
dbb10bb155 Just update save count on all changes 
(closes #6239)
 2019-04-30 10:02:00 -04:00
Ming Gao
18dff285d0 add validation for very close node on road 
addresses issue #6241

also made a change in inspector, so that when an untagged entity has issues,
show the entity editor so that the issues are visible when an item is clicked
in the issues pane.
 2019-04-29 22:59:27 -04:00
Bryan Housel
a3605f9b74 Comment out "anchor encoding" for wiki links 
(closes #6232)
 2019-04-29 22:53:16 -04:00
Bryan Housel
a72865e4d8 Treat anything with a from/via/to like a restriction 
(closes #6221)

Applies to actions like splitting, connecting, extracting a via node, etc
 2019-04-29 21:58:10 -04:00
Bryan Housel
2b46440429 Add Relation#hasFromViaTo method and tests 2019-04-29 21:39:40 -04:00
Bryan Housel
bd2490a965 Reverse internal left/right/forward/backward keyparts 
(closes #6235)

Previously only trailing keyparts would reverse:
 `cycleway:left` ⟺  `cycleway:right`
Now it can do internal keyparts too:
 `cycleway:left:surface` ⟺  `cycleway:right:surface`
 2019-04-29 21:13:18 -04:00
Bryan Housel
fceb1a86f7 Merge pull request #6245 from openstreetmap/d3-v5 
d3 v5
 2019-04-29 15:46:08 -04:00
Bryan Housel
e981cd5dd5 Switch mapillary and openstreetcam tests to work async 
- can't reliably use sinon.spy to tell whether a thing has been called,
  so we listen for events instead and check server.requests()
- make sure to request the next page before dispatching `loadedImages` so
  we can `server.respond()` to the request in the event handler if we want to
- also moves `localeDateString` in the openstreetcam service from parsing
  code to display code, because it's very slow (we can just do this for the
  images we look at, instead of all images we fetch)
 2019-04-29 15:31:08 -04:00
Quincy Morgan
56898b1843 Merge branch 'master' into unsquare-buildings-autofix 2019-04-29 10:44:37 -07:00
Bryan Housel
b48a7d1e1b Workround for status errors thrown by d3-xml 
Because the done callback is expecting something that has a `status` property,
(like an XHR would), we need to extract the status out of the error message.
d3-xml includes status in the error message, but we can't access the response itself.
 2019-04-26 22:23:08 -04:00
Quincy Morgan
ea05d4e672 Unhighlight features when clicking issue quick fix (close #6219) 2019-04-26 16:26:19 -07:00
Quincy Morgan
3fad3513c1 Don't zoom to the feature and remove hover-highlighting upon clicking the issue fix button in the issues pane 2019-04-26 16:05:10 -07:00
Quincy Morgan
59bd6194e0 Add "autofix" for the unsquare building validation 2019-04-26 14:56:39 -07:00
Quincy Morgan
239c622044 Don't tag redundant ignored warnings counts on changesets 2019-04-26 13:02:13 -07:00
Quincy Morgan
228af9a000 Move areaKeys and setAreaKeys to modules/osm/tags 2019-04-26 12:53:05 -07:00
Quincy Morgan
ecc217f5d8 Add validation rule to flag impossible oneway highways and waterways (close #6216) 2019-04-26 12:04:43 -07:00
Bryan Housel
b99be67169 When calling an errback from a Promise.catch, pass err.message 2019-04-25 21:58:36 -04:00
Quincy Morgan
7d29a98a14 Add subtype to some validation issues 2019-04-25 10:35:27 -07:00
Quincy Morgan
f2ca5316b0 Add total ignored warnings count to changeset tags (re: #6123) 2019-04-25 09:34:07 -07:00
Quincy Morgan
6eeaf94076 Show members of selected relations even when their feature layer is otherwise hidden (close #6220) 2019-04-24 17:28:56 -07:00
Quincy Morgan
42de00e640 Add validation warning for "fixme" tags (close #6214) 2019-04-24 16:59:57 -07:00
Quincy Morgan
aa91c2d768 Move old multipolygon warning into Outdated Tags rule (close #6218) 2019-04-24 15:46:50 -07:00
Quincy Morgan
6a9c7b97a8 Don't flag websites on residential buildings 2019-04-24 15:21:49 -07:00
Quincy Morgan
13f7e536dc Move highway=road validation warning to the missing_tag validation rule (re: #6218) 2019-04-24 15:19:57 -07:00
Quincy Morgan
b30c91828f Don't flag buildings with lots of nodes or buildings connected to other buildings as unsquare (re: #6215) 2019-04-24 14:52:41 -07:00
Quincy Morgan
d01bb78707 Reduce circular dependencies caused by importing from indexes, the location of the validation models, and the location of areaKeys (close #6237) 2019-04-24 13:45:59 -07:00
Bryan Housel
e6bc9d9e8f Swap out d3-request, swap in d3-fetch 2019-04-24 16:25:25 -04:00
Bryan Housel
48b1ddc925 Rename fetch to fetchComboData to not conflict with fetch API 2019-04-24 16:24:36 -04:00
Bryan Housel
b6cd13508a Add abortcontroller-polyfill to support abortable fetch calls 2019-04-24 16:24:13 -04:00
Bryan Housel
05949608aa Support straightening of points 
(closes #6217)

- Split `actionStraighten` into `actionStraightenWay` and `actionStraightenNodes`
- Now `operationStraighten` chooses the correct action depending on selected entities
- Also move `getSmallestSurroundingRectangle` from `actionReflect` to `geo.js`
 2019-04-24 01:55:43 -04:00
Quincy Morgan
34fcd01f98 Add validation warning for unsquare buildings 2019-04-23 15:50:52 -07:00
Bryan Housel
a37ce90af7 Move "Fix All" from bottom of list to top 2019-04-23 17:42:14 -04:00
Quincy Morgan
4948474118 Set the default validation filters to be My Edits / Everywhere (re: #6223) 2019-04-23 10:34:10 -07:00
Bryan Housel
7e04175559 Add Enable All / Disable All validation rules links 
(closes #5986)
 2019-04-23 13:01:15 -04:00
Bryan Housel
1d4770a3c6 Merge pull request #6211 from AndreasHae/feature/split-multiple-tags 
Handle multiple tags when splitting up in tag editor
 2019-04-23 11:05:03 -04:00
Bryan Housel
bd2a33d845 Merge branch 'validation_and_change_perf' 2019-04-23 01:30:26 -04:00
Bryan Housel
a3bc164c43 Redraw entity editor fields on addition, deletion too 
This is important to make the turn restriction editor work
 2019-04-23 01:07:38 -04:00
Bryan Housel
7dce4bb161 Avoid asking DOM if layers are classed disabled in map.editable 
`map.editable` is hot code because it's called frequently by the `isHiddenX`
tests in `features.js`.  It's much more efficient to just ask the osm layer
whether it is enabled, than to use D3 to find that layer in the DOM and check
whether it's classed `disabled`
 2019-04-22 22:12:42 -04:00
Bryan Housel
61da61d7fd Add missing button arg to modeDrawLine, ensure using current entities 2019-04-22 20:00:53 -04:00
Bryan Housel
3fe9d75f35 Fix issues with issue cache for entities that no longer exist 2019-04-22 19:35:23 -04:00
Quincy Morgan
e04d860f62 Convert "Detach" operation into "Extract" operation that also works on areas (close #6203) 2019-04-22 14:46:01 -07:00
Andreas Hässler
e49fdce215 Add missing semicolons 2019-04-22 23:43:55 +02:00
Andreas Hässler
2596b97dbc Do not use ES6 features 2019-04-22 16:38:33 +02:00
Andreas Hässler
faa178797d Handle multiple tags when splitting up 2019-04-22 16:22:59 +02:00
Bryan Housel
e4fc821eb0 Just use reduce 2019-04-22 09:49:17 -04:00
Bryan Housel
3557e3c711 Don't allow disconnecting a way if parts extend to undownloaded tiles 
(re: #2248, #4245)
 2019-04-20 00:02:46 -04:00
Bryan Housel
bbf4495f5c pacify eslint 2019-04-19 23:44:49 -04:00
Bryan Housel
7c85cc997e Merge branch 'master' into validation_and_change_perf 2019-04-19 22:44:04 -04:00