Commit Graph

3676 Commits

Author SHA1 Message Date
Quincy Morgan
bea1fdc692 Check feature names against additional generic tag keys/values 2020-06-16 17:08:35 -04:00
Quincy Morgan
e790525903 Remove unneeded full redraw upon entering modeSelect 2020-06-16 13:41:45 -04:00
Quincy Morgan
3ba805d6ca Skip editableDataEnabled check in rendererFeatures filters (re: #7706) 2020-06-16 13:19:54 -04:00
Quincy Morgan
e476321818 Use loops instead of functions in actionDisconnect.connections, for performance (re: #7706) 2020-06-16 13:18:59 -04:00
Quincy Morgan
5f93da5a59 Add a reusable function for calculating the combined extent of multiple entities (re: #7706) 2020-06-16 13:17:43 -04:00
Quincy Morgan
f53cce783a Only update selection styling for full redraws (re: #7706) 2020-06-16 13:14:06 -04:00
Quincy Morgan
24b124e536 Fix infinite recursion error caused when rendering cyclical relations (close #7691) 2020-06-16 10:24:42 -04:00
Quincy Morgan
0473243930 Add workaround for broken rapid tapping on iOS 13.4+ (close #7694) 2020-06-15 12:27:53 -04:00
Quincy Morgan
7565e685d1 Fix lint warning 2020-06-12 14:19:13 -04:00
Quincy Morgan
51f465c84e Flash disabled reason for zoom buttons on touch action (close #7699) 2020-06-12 14:18:31 -04:00
Quincy Morgan
70aaa0fa3a Add disabled message to tooltip when Zoom To Selection button is disabled 2020-06-12 13:55:05 -04:00
Quincy Morgan
4874ee2c62 Add disabled messages for zoom in/out buttons when at max/min zooms 2020-06-12 13:44:13 -04:00
Quincy Morgan
b7bb8213ba Flash the disabled message for touch interaction for the save button (re: #7699)
Don't flash undo/redo tooltip text when the map isn't editable
2020-06-12 13:10:15 -04:00
Quincy Morgan
a1e6a1acd9 Increase tolerance for discarding erroneous mouse pointenter events on touch devices 2020-06-12 13:06:29 -04:00
Quincy Morgan
1e68917e2a Flash tooltip text when tapping undo/redo toolbar buttons and disabled operation buttons on touch devices (re: #7699) 2020-06-12 12:48:16 -04:00
Quincy Morgan
4467c4a501 Fix issue where spaces couldn't be typed in the changeset comment (re: #6817) 2020-06-11 10:52:58 -04:00
Quincy Morgan
cc5da9b9c3 Add endpoints to customize or disable iD's changing of the document title (close #7503)
Use the initial title as the default base title
2020-06-10 15:47:41 -04:00
Quincy Morgan
874c412b74 Enforce max unicode charachter length of keys, values, and relation roles through truncation upon input rather than HTML maxlength attribute (close #6817)
Normalize unicode when changing keys, values, and relation roles
2020-06-10 14:11:55 -04:00
Quincy Morgan
2064f7a2f7 Update util function comments 2020-06-10 12:44:10 -04:00
Quincy Morgan
d01f1598d3 Show the delete button for filled multilingual name fields even if no name tag is present (close #7572)
Focus the language input when clicking a multilingual name field label instead of deleting the value
Be more lenient with `utilUniqueDomId` function input
2020-06-10 10:35:03 -04:00
Quincy Morgan
369044bc11 Focus relation role when clicking on member or membership item label (close #7690) 2020-06-10 09:53:51 -04:00
Quincy Morgan
05d357159d Add implied oneway logic info for man_made=goods_conveyor 2020-06-09 17:55:17 -04:00
Quincy Morgan
762307bd7d Restrict key, value, and role character limits based on unicode characters, not UTF-16 code units (re: #6817) 2020-06-09 15:41:15 -04:00
Quincy Morgan
a7e16a5625 Show the number of unique nodes instead of the aggregate for the selection in the measurement panel (re: #7329) 2020-06-08 17:07:26 -04:00
Quincy Morgan
2f2e0dcb94 Show combined length, area, and node count in the measurement panel for multiselections (close #7329) 2020-06-08 16:47:03 -04:00
Quincy Morgan
8b258d2cbd Load the maximum nodes per way value from the OSM API and add a getter to the service object
Disable the Merge operation if the resultant way would have more than the maximum number of nodes (close #6030)
Simplify some code in operationMerge
2020-06-08 14:38:49 -04:00
Quincy Morgan
bf7b30ace9 Fix unreleased regression where OSM notes were being parsed as JSON and thus not loading (re: #7188) 2020-06-08 13:19:46 -04:00
Quincy Morgan
2e5e3791c5 Disable the straighten operation for selections that are already straight (close #7658) 2020-06-08 11:58:10 -04:00
Quincy Morgan
61b3aaafd2 Autofocus new note descriptions in the UI code instead of the mode code (re: #7680) 2020-06-08 11:42:29 -04:00
Quincy Morgan
fd41e5fd75 Add specific error feedback for disabled straighten operation for multiple selected features 2020-06-08 11:16:25 -04:00
Quincy Morgan
c85fbf34f9 Underscore function scope variables in modeSelectNote 2020-06-08 10:30:04 -04:00
Quincy Morgan
def3a373a7 Autofocus the comment field when adding a new OSM note (close #7680) 2020-06-08 10:26:16 -04:00
Quincy Morgan
e8a227fc59 Allow straightening a selected line between two points if the two points are visible, regardless of how long the line is 2020-06-08 10:08:52 -04:00
Quincy Morgan
cee4b0a4da Give several functions more descriptive names 2020-06-08 09:50:13 -04:00
Quincy Morgan
632849b509 Show the inspector instead of the preset list when selecting an untagged vertex with a parent relation 2020-06-07 20:42:42 -04:00
Quincy Morgan
ab3717bbc8 Disable the Straighten operation when not enough of the selection is visible (close #7675)
Add specific straighten tooltip and annotation labels for multiple selected lines
2020-06-05 14:59:27 -04:00
Quincy Morgan
f14577b2d0 Fix lint warning 2020-06-05 14:32:59 -04:00
Quincy Morgan
02f8849bd0 Properly disable more operations for single nodes that aren't visible 2020-06-05 14:22:50 -04:00
Quincy Morgan
251f9825f4 Fix extent logic change from 28bd985a31 2020-06-05 14:19:37 -04:00
Quincy Morgan
28bd985a31 Prevent disconnecting nodes that aren't mostly visible
Return 1 for geoExtent.percentContainedIn when caller is a zero-area extent contained within the argument extent
Prefix function-scope operationExtent variables with underscores
2020-06-05 13:54:41 -04:00
Quincy Morgan
790f90c11d Show "not visible" disabled reason over "connected to hidden" in the extract operation when both are applicable, in accordance with other operations 2020-06-05 13:12:51 -04:00
Quincy Morgan
fac0eea761 Use eased zoom when selecting features from search results and zoom to their full extent 2020-06-05 12:12:37 -04:00
Quincy Morgan
3506389d83 Fix JS error when zooming to lat/lon values coded in search bar (close #7670) 2020-06-05 12:06:21 -04:00
Quincy Morgan
d22d3bfc66 Update for string.fromcodepoint v1.0.0 API 2020-06-05 11:08:34 -04:00
Quincy Morgan
fcc21ce856 Update node-diff3 API calls for v2.0.0 2020-06-04 19:16:49 -04:00
Quincy Morgan
6128c6514f Enable the Extract operation for multiple selected extractable features (close #7600)
Allow extracting vertices that are `via` or `location_hint` relation members
2020-06-04 16:35:25 -04:00
Quincy Morgan
572ce0a787 Make sure horizontal-only scroll events can be translated into map pans (close #7659) 2020-06-04 13:29:45 -04:00
Quincy Morgan
6c2b097eb7 Enable disconnection of multiple selected features from each other, if connected, and otherwise from everything (close #7652)
Add specific descriptions for a wider range of disconnection scenarios
2020-06-03 14:51:31 -04:00
Quincy Morgan
0cd1b40c57 Make sure clicking the first node finishes drawing when drawing any closed way 2020-06-02 16:57:14 -04:00
Quincy Morgan
5eb0fc3e0e Update comments 2020-06-02 15:58:35 -04:00