Commit Graph

3604 Commits

Author SHA1 Message Date
SilentSpike d4723ec9e2 Read icons from qa_errors.json when building data
Also adds support for the following error types:
- Objects mapped as both node/area or way/area
- Power lines that lead to nowhere
- Extra nodes in power lines (which should only go from support to
support to endpoint)
- Power line supports with no power lines
2020-02-03 23:20:30 +00:00
SilentSpike 5afdfc527b Add support for more Osmose error types
- Missing parking access
- Malformed opening hours tagging
- Objects detected by Mapillary that aren't mapped
- Traffic sign information detected by Mapillary that isn't mapped

Mapillary errors add example code for special error type handling as
they don't need to request further details and can use piecewise
translation strings
2020-02-03 23:01:03 +00:00
SilentSpike b24b041335 Add Osmose issue detail fetching for UI
Must fetch details per-issue to get the associated OSM elements for
highlighting and use in the error description.

Also fixes URL for error closure.
2020-02-03 23:01:03 +00:00
SilentSpike ebd206595a Use Osmose tiles API endpoint instead of issues
- Simplifies our code a little bit
- Quick to provide and gives us the `item` + `class` without requesting
all other information (the two things needed to know the error type)
- Removed handling of associated elements for now, need to implement
fetching for that data on a per-issue basis when the UI loads
- Set things up for the possibility of using the provided translation
strings (need to determine if desirable)

See: https://github.com/osm-fr/osmose-frontend/issues/193
2020-02-03 23:01:03 +00:00
SilentSpike 680fdb6b54 Allow Osmose errors to use category for UI strings
Some error types don't require unique strings and can share common
strings among the category. This makes that possible as well as adding
support for some other types of error for demonstrative purposes.
2020-02-03 23:01:02 +00:00
SilentSpike 09e7b23665 Add Osmose issues UI and filtering
Filters out errors not present in the data .json file to enable
selective support since Osmose has a wide variety of errors which may be
too advanced for iD.

Also added processing for the elements associated with an error for
forced visibility and highlighting.
2020-02-03 23:01:01 +00:00
SilentSpike e11d97b38c Add Osmose QA layer and service
Initial implementation - need to add UI for the errors and correctly set
up support for the desired error types provided by osmose.
2020-02-03 23:01:01 +00:00
Quincy Morgan 3370bea588 Add derived data for #7289 2020-02-03 13:58:12 -05:00
Quincy Morgan 1fd3e15e6b Merge pull request #7289 from ToastHawaii/2.x
Add simple access to advertising
2020-02-03 13:37:35 -05:00
Quincy Morgan 4627a158f8 Merge pull request #7323 from animesh-007/7296
added new preset, fixes #7296
2020-02-03 08:57:02 -05:00
animesh-007 54fa13be7e added new preset 2020-02-03 17:43:52 +05:30
Bryan Housel ab3b731d66 Merge pull request #7310 from animesh-007/7274-new
Added new preset, fixes #7274
2020-01-31 15:21:01 -05:00
Quincy Morgan 208f3d5d1c Add Incline field to rail presets
Use field inheritance for rail presets
2020-01-31 14:58:12 -05:00
animesh-007 813afc073e added new feature 2020-02-01 01:11:57 +05:30
Quincy Morgan 04bd811fde Merge pull request #7306 from openstreetmap/multiselection-field-editing
Enable field editing in multiselection
2020-01-31 14:36:42 -05:00
animesh-007 fb52e2d5b5 added new feature 2020-02-01 00:58:50 +05:30
Quincy Morgan 3f5374e154 Deprecate tunnel=1 2020-01-31 14:12:26 -05:00
Quincy Morgan 2783408fc3 Add tooltips to mixed values in semicombo, multicombo, and radio fields 2020-01-31 14:07:16 -05:00
Quincy Morgan 103be60112 Add tactile_paving field to bus and trolleybus stops (close #7307) 2020-01-31 10:10:40 -05:00
Quincy Morgan 5cd65efd6e Update generic aerialway and aeroway preset names to include "Feature"
Add icon to generic power preset
2020-01-31 10:07:55 -05:00
Bryan Housel 6e5cb45c17 Don't bundle the imagery anymore, fetch from dist/data at runtime
(re: #4994)
2020-01-30 17:10:41 -05:00
Bryan Housel fb4d658860 Don't bundle the community index anymore, fetch from CDN instead
Start fetching and preparing it just before the changeset gets sent
2020-01-29 15:24:26 -05:00
Bryan Housel c481f90e7d Stop bundling wmf-sitematrix, move it extern
This also includes a bunch of tweaks to make the tests work
in both PhantomJS and modern browsers like Chrome.

Basically - introduce some more async into the test code so that
the coreData.get promise is guaranteed to settle.  Because in
PhantomJS the promise is polyfilled, and Chrome it's native, they
work slightly differently.
2020-01-29 12:30:11 -05:00
Bryan Housel 567eeac587 Make several data external instead of bundled:
Also dist/data/* contains minified files now

These are now external and will fetch as needed:
-export { dataAddressFormats } from './address-formats.json';
-export { dataDeprecated } from './deprecated.json';
-export { dataDiscarded } from './discarded.json';
-export { dataLanguages } from './languages.json';
-export { dataPhoneFormats } from './phone-formats.json';
-export { dataShortcuts } from './shortcuts.json';
-export { dataTerritoryLanguages } from './territory-languages.json';
2020-01-28 22:21:31 -05:00
Bryan Housel ce7cac6738 Move all the build scripts into scripts/ folder, ES6ify more stuff 2020-01-28 15:00:23 -05:00
Quincy Morgan aadbddba2f Update to temaki 3.14.0 (close #7299, re: #7255) 2020-01-28 13:21:46 -05:00
Quincy Morgan d7e4575a7b Update to temaki 3.13.0 (close #7298)
Add new rail icons (close #7255)
Render "statused" railways with lighter colors
Don't render disused features with a dashed stroke
2020-01-28 11:42:53 -05:00
Bryan Housel 31e007fc83 Create a data loader and move the intro graph into dist/data
(re: #3403)
2020-01-27 17:15:00 -05:00
ToastHawaii 84b3a394ca Add more fields to advertising. 2020-01-26 22:15:58 +01:00
ToastHawaii 14d29c7dd7 Add simple access to advertising 2020-01-24 22:30:36 +01:00
Quincy Morgan f21be40b9a Correct issue where Monastery Grounds preset would unexpectedly add a "building" tag (close #7287) 2020-01-24 13:02:58 -05:00
Quincy Morgan 5640f37bb6 Add terms to car repair shop 2020-01-24 09:22:57 -05:00
Quincy Morgan 69df630f21 Support multiple values in the beauty field (close #7215) 2020-01-24 09:20:23 -05:00
Quincy Morgan d83ccf590c Deprecate building:height and building:min_height (close #7285) 2020-01-24 08:44:06 -05:00
Bryan Housel a166eb6daa ES6 update_imagery 2020-01-23 14:31:31 -05:00
Quincy Morgan 9aefe4a6dc Deprecate bicycle:oneway -> oneway:bicycle (close #7281) 2020-01-23 09:00:46 -05:00
Quincy Morgan 046fb1d0bf Add derived data for prior merge (re: #7284) 2020-01-23 08:59:42 -05:00
Ferdinand S cdf4a9d9d3 Update research.json 2020-01-23 12:54:56 +01:00
Ferdinand S 2c53962041 added another option for terms 2020-01-23 10:30:40 +01:00
Quincy Morgan fd2b97331c Add label to "change feature type" button in inspector and make it a collapsible section (close #6811) 2020-01-22 09:19:54 -05:00
Quincy Morgan 6bb2997306 Enable changing the preset of multiple selected features (re: #7276)
Fix issue where preset tag reference wouldn't load
Change "Change feature" tooltip to more accurate "Change feature type"
2020-01-21 15:19:51 -05:00
Quincy Morgan 11035127a3 Rename "Adjust imagery offset" section to "Imagery Offset" 2020-01-20 13:12:46 -05:00
Quincy Morgan 019e9a956c Remove unused strings 2020-01-20 12:15:13 -05:00
Quincy Morgan 667406c6e0 Remove "all" from the inspector section names 2020-01-20 11:51:00 -05:00
Quincy Morgan 48bda8ba67 Move selected feature list to a collapsible inspector section (close #7273) 2020-01-20 11:34:51 -05:00
Quincy Morgan bb593c5ccc Add "deselect" tooltip to X buttons in selected features list 2020-01-20 10:22:49 -05:00
Quincy Morgan d2ee613bfc Merge pull request #7268 from hikemaniac/exhibition_centre
Add preset for amenity=exhibition_centre
2020-01-18 16:00:13 -05:00
hikemaniac c8283028c2 Rebuild with updated dependencies 2020-01-18 21:39:58 +01:00
hikemaniac 826a3e954e Added preset for amenity=exhibition_centre 2020-01-18 21:23:48 +01:00
Quincy Morgan caf3a4d83a Merge pull request #7262 from openstreetmap/multiselect-tag-editing
Raw tag editor for multiple select features (2.x)
2020-01-18 15:07:50 -05:00