Commit Graph

11381 Commits

Author SHA1 Message Date
Quincy Morgan
a180c794cb Merge branch 'master' into ignoring-issues 2019-05-01 20:13:49 -07:00
Quincy Morgan
712f8bcb03 Avoid having hidden issues strings for both singular and multiple variations 2019-05-01 20:13:09 -07:00
Bryan Housel
534fa3460b npm run build for recent preset updates 2019-05-01 19:24:22 -04:00
Bryan Housel
087f252b18 When removing a tag, remove it from _indexedKeys too
(re: d026f2f / #5927)

So that if the user decides to put it back, it will be sorted to the
end and not inserted back at its original position in the middle
2019-05-01 19:17:59 -04:00
Bryan Housel
382e0a7dd6 Merge pull request #6270 from westnordost/patch-10
inherit preset.removeTags from preset.addTags if not defined [Ready for Review]
2019-05-01 19:15:24 -04:00
Bryan Housel
03ce2871d1 Merge pull request #6285 from westnordost/presets-houseboat
add houseboat preset
2019-05-01 19:13:52 -04:00
Tobias Zwick
ac14294399 add houseboat preset 2019-05-01 23:59:10 +02:00
Quincy Morgan
eeaad79cb1 Display info about hidden issues in the "no issues" UI 2019-05-01 14:50:56 -07:00
Quincy Morgan
1c15338bd5 Make reset ignored button consistent with enable/disable all rules buttons 2019-05-01 12:13:10 -07:00
Quincy Morgan
56544303ca Merge branch 'master' into ignoring-issues 2019-05-01 11:58:39 -07:00
Quincy Morgan
d2cca04c3f Deprecate artwork and artwork:type keys in favor of artwork_type 2019-05-01 11:56:51 -07:00
Quincy Morgan
9b9e3dbdfa Merge branch 'master' of https://github.com/openstreetmap/iD 2019-05-01 11:51:59 -07:00
Quincy Morgan
e93857012e Add better icons for Bust and Statue presets 2019-05-01 11:51:49 -07:00
Bryan Housel
d7a569c425 Merge branch 'defer-select-for-6028' 2019-05-01 14:49:31 -04:00
Bryan Housel
37557a7c98 Defer processing clicks in behaviorSelect
(closes #6028) (I hope?)

Because this click may trigger a blur event,
and the blur event may trigger a tag change,
and we really want that tag change to go to the already selected entity
and not the one that we are about to select with the click  #6028, #5878

(Be very careful entering modeSelect anywhere that might also blur a field!)
2019-05-01 14:47:29 -04:00
Quincy Morgan
949b57d118 Ensure that relations are called before ways when categorizing fetched features (close #6277) 2019-05-01 11:33:39 -07:00
Quincy Morgan
907df1c10e Include relation members when forcing relations visible in all cases, not just selection (re: 6eeaf94076) 2019-05-01 11:08:52 -07:00
Bryan Housel
d3f767d6f4 Code cleanups, prefix state variables with _ 2019-05-01 13:48:36 -04:00
Quincy Morgan
21dc6fe500 Update meadow preset terms (close #6280) 2019-05-01 09:24:34 -07:00
Quincy Morgan
1d8e27ef91 Add derived data from prior merge 2019-05-01 09:06:40 -07:00
Quincy Morgan
6d1bb43793 Merge pull request #6275 from westnordost/presets-more-artwork-types
Add bust, graffiti and installation artwork type preset
2019-05-01 09:04:47 -07:00
Tobias Zwick
250df5b6a8 use "Graffiti" instead of "Graffiti Artwork" as name 2019-05-01 11:12:44 +02:00
Quincy Morgan
52d92f125c Add button to reset ignored issues
Don't cache issue extent
2019-04-30 16:32:36 -07:00
Bryan Housel
d026f2f296 Add index property to tag rows, don't reorder on modifying key
(closes #5927)
2019-04-30 18:22:11 -04:00
Tobias Zwick
6a59a8c1f6 change name to Installation Art 2019-05-01 00:09:36 +02:00
Tobias Zwick
a36c746b56 Add bust, graffiti and installation artwork type preset 2019-04-30 23:26:20 +02:00
Tobias Zwick
4bb5c27a2a remove removeTags from 2 recently deprecated presets 2019-04-30 22:28:18 +02:00
Tobias Zwick
446dc1097d Merge branch 'master' into patch-10
# Conflicts:
#	data/presets/presets/highway/crossing/unmarked-raised.json
#	data/presets/presets/highway/crossing/unmarked.json
2019-04-30 22:20:05 +02:00
Quincy Morgan
a4ebbaf7f5 Don't use the issue loc as a differentiator for all issues 2019-04-30 13:16:03 -07:00
Tobias Zwick
ba996f700d remove all now unnecessary removeTags 2019-04-30 22:15:51 +02:00
Tobias Zwick
a1b89332bb add test 2019-04-30 22:15:34 +02:00
Tobias Zwick
62e0f76243 update readme and preset schema description 2019-04-30 22:15:16 +02:00
Tobias Zwick
d008a585fa remove removeTags from suggestionsToPresets 2019-04-30 22:14:51 +02:00
Quincy Morgan
26f1e29072 Merge branch 'master' into ignoring-issues
# Conflicts:
#	data/core.yaml
#	dist/locales/en.json
2019-04-30 13:05:07 -07:00
Quincy Morgan
76e2948088 Add underscores to filenames of unsearchable crossing presets 2019-04-30 11:55:18 -07:00
Quincy Morgan
9d6b461d0e Apply the crossing tag of the path to the node even if it's not a footpath when connecting crossing ways 2019-04-30 11:53:03 -07:00
Quincy Morgan
07573091ad Don't add a "crossing" tag to ambiguous crossings when connecting crossing ways via the quick fix (re: #6244) 2019-04-30 11:46:15 -07:00
Quincy Morgan
5eb3416431 Don't suggest upgrading crossings without a "crossing" tag to crossing=unmarked (close #6244)
Style crossing icons more nicely
2019-04-30 11:41:50 -07:00
Quincy Morgan
942d55a4bf Update strings for duplicate node validation
Use routable highway tags for duplicate node validation instead of any highway tag
2019-04-30 10:18:22 -07:00
Quincy Morgan
ddae6641b3 Fix issue where preset list would not appear when adding new features (close #6271) 2019-04-30 09:42:24 -07:00
Bryan Housel
dbb10bb155 Just update save count on all changes
(closes #6239)
2019-04-30 10:02:00 -04:00
Bryan Housel
b215c1f1a5 built with updated imagery 2019-04-30 10:01:47 -04:00
Bryan Housel
0a4e2c03a3 Extend timeouts on slow async mapillary tests
Trying to avoid false test failures.  Default timeout is 2sec, and we can't
be sure slow async tests will finish in that time esp. in a CI environment
2019-04-30 09:59:51 -04:00
Tobias Zwick
f1d9b82831 inherit preset.removeTags from preset.addTags if not defined 2019-04-30 09:50:47 +02:00
Bryan Housel
2fde32ce9f Merge pull request #6267 from gaoxm/dupeNodeValidation
add validation for very close node on road
2019-04-29 23:52:49 -04:00
Ming Gao
18dff285d0 add validation for very close node on road
addresses issue #6241

also made a change in inspector, so that when an untagged entity has issues,
show the entity editor so that the issues are visible when an item is clicked
in the issues pane.
2019-04-29 22:59:27 -04:00
Bryan Housel
a3605f9b74 Comment out "anchor encoding" for wiki links
(closes #6232)
2019-04-29 22:53:16 -04:00
Bryan Housel
a72865e4d8 Treat anything with a from/via/to like a restriction
(closes #6221)

Applies to actions like splitting, connecting, extracting a via node, etc
2019-04-29 21:58:10 -04:00
Bryan Housel
2b46440429 Add Relation#hasFromViaTo method and tests 2019-04-29 21:39:40 -04:00
Bryan Housel
bd2490a965 Reverse internal left/right/forward/backward keyparts
(closes #6235)

Previously only trailing keyparts would reverse:
 `cycleway:left` ⟺  `cycleway:right`
Now it can do internal keyparts too:
 `cycleway:left:surface` ⟺  `cycleway:right:surface`
2019-04-29 21:13:18 -04:00