Quincy Morgan
95a14ea722
Add unit test for single-member multipolygon collapse behavior exception for conflicting tags in actionJoin (re: f7d8c51bd3)
2019-11-21 12:54:59 -05:00
Quincy Morgan
4297b0d95b
Add unit test for single-member multipolygon collapse behavior in actionJoin (re: f7d8c51bd3)
2019-11-21 11:20:56 -05:00
Katarzyna Król
48ccc7900e
improve checking circularity and unit tests
2019-10-29 22:51:05 +01:00
Quincy Morgan
516570739c
Fix node reverse code test
...
Add more code tests for reversing nodes
2019-09-18 13:13:44 -04:00
Quincy Morgan
c229326aad
Allow using the Reverse operation on directional nodes ( close #6850 )
2019-09-17 10:57:55 -04:00
Quincy Morgan
14c0809426
Fix issue where cuisine -> diet upgrades could overwrite existing values ( close #6462 )
2019-05-31 08:25:29 -04:00
Quincy Morgan
0dfd0612b1
For ice rinks, prefer the "sport" values "ice_hockey" and "ice_skating" instead of "hockey" and "skating" since that latter are ambiguous
...
Don't remove other values when upgrading a tag value within a semicolon-delimited list
2019-05-23 15:39:15 -04:00
Bryan Housel
a72865e4d8
Treat anything with a from/via/to like a restriction
...
(closes #6221 )
Applies to actions like splitting, connecting, extracting a via node, etc
2019-04-29 21:58:10 -04:00
Bryan Housel
bd2490a965
Reverse internal left/right/forward/backward keyparts
...
(closes #6235 )
Previously only trailing keyparts would reverse:
`cycleway:left` ⟺ `cycleway:right`
Now it can do internal keyparts too:
`cycleway:left:surface` ⟺ `cycleway:right:surface`
2019-04-29 21:13:18 -04:00
Bryan Housel
05949608aa
Support straightening of points
...
(closes #6217 )
- Split `actionStraighten` into `actionStraightenWay` and `actionStraightenNodes`
- Now `operationStraighten` chooses the correct action depending on selected entities
- Also move `getSmallestSurroundingRectangle` from `actionReflect` to `geo.js`
2019-04-24 01:55:43 -04:00
Quincy Morgan
e04d860f62
Convert "Detach" operation into "Extract" operation that also works on areas ( close #6203 )
2019-04-22 14:46:01 -07:00
J Guthrie
bd44cec2e8
Fix broken testcase!
2019-04-08 16:48:27 +01:00
J Guthrie
57a0358061
Add test cases
2019-04-08 15:19:21 +01:00
J Guthrie
470d6c257d
Update to work on ways going in opposite directions
2019-03-22 15:29:48 -04:00
J Guthrie
5aecfcabc9
Update tests
2019-03-22 15:29:47 -04:00
Bryan Housel
c7e375cbd7
Preserve directionality of sided way when joining to non-sided ways
...
(closes #6033 )
2019-03-21 22:19:05 -04:00
Quincy Morgan
93df5d42d9
Flag and upgrade deprecated tags in a semicolon-delimited tag value ( close #6038 )
2019-03-11 10:22:28 -04:00
Bryan Housel
3f8911c149
Merge pull request #5999 from openstreetmap/squarish
...
Improve orthogonalization action
2019-03-01 23:28:23 -05:00
Bryan Housel
fab6bd1d33
Support orthogonalizing a single vertex, add tests
...
(closes #2205 )
2019-03-01 23:20:50 -05:00
Bryan Housel
e64693eea5
Upgrade tests from legacy iD.Difference to iD.coreDifference
2019-03-01 16:03:21 -05:00
Bryan Housel
cb51c16c8f
Expand actionOrthogonalize tests, fix abs issue in canOrthogonalize
2019-03-01 13:45:00 -05:00
Quincy Morgan
1f21b029fd
Move tag upgrade fix to an action and add unit tests
2019-02-26 10:42:12 -05:00
Bryan Housel
71b2d2c6b7
Upgrade legacy symbols in tests
...
- iD.Context -> iD.coreContext
- iD.Graph -> iD.coreGraph
- iD.Node -> iD.osmNode
- iD.Way -> iD.osmWay
- iD.Relation -> iD.osmRelation
2019-01-30 15:43:02 -05:00
J Guthrie
631ace27d5
Add check to stop joining ways if resulting way intersects itself
...
- Includes new test case
2019-01-22 03:07:38 +00:00
ockendenjo
cec442012a
Add test for route going round loop in other direction
2018-12-18 22:09:20 +00:00
ockendenjo
8aaa387d4e
Add tests for hat route splitting #4876
2018-12-18 21:39:35 +00:00
Bryan Housel
1ffca3ce85
Switch crossing presets to "marked"/"unmarked", retain "zebra" as unsearchable
2018-10-02 17:01:04 -04:00
Bryan Housel
2e6799ac60
Don't reverse cardinal direction roles on relations anymore
...
re: https://github.com/openstreetmap/iD/pull/2004#issuecomment-407995998
Per thread https://twitter.com/bhousel/status/1025805098063208448
JOSM has stopped doing this too
2018-08-04 21:55:14 -04:00
Bryan Housel
119792fd22
Cleanups to Detach Node feature
...
This commit includes a bunch of minor things:
- change keyboard shortcut to 'E' to not conflict with anything
- move `disabled` check from operation into action and simplify
- use `actionMoveNode` to place the detached node at the mouse cursor
- disable the operation if the node is connected to hidden features
- lots of code simplification
- make the icon more centered
2018-07-23 13:36:34 -04:00
Bryan Housel
94b0affe8c
Merge branch '4320' of https://github.com/Psigio/iD into Psigio-4320
2018-07-23 08:44:19 -04:00
Jon D
90bc0b8537
Update to prevent detachment of node when either a via or
...
location_hint role in a turn restriction.
Update to move any other relation to new node.
2018-07-22 19:35:29 +01:00
Jon D
3bad09d497
Merge Work-In-Progress 4320 to 4320
2018-07-06 22:20:19 +01:00
Bryan Housel
416ae66f71
Support more direction tags for reversal in Reverse action
...
(closes #5121 )
This commit also refactors some of the logic to make it simpler and more efficient
(removes lodash _transform too) and updates the comment that was out of date.
2018-07-05 14:47:56 -04:00
Bryan Housel
6ed20d7762
actionMergeNodes can just use actionConnect
2018-04-25 22:26:34 -04:00
Bryan Housel
2909162158
Rename merge_way_nodes to merge_nodes, update tests
2018-04-25 20:57:40 -04:00
Bryan Housel
9bf4799b56
Merge branch 'merge-way-nodes-feature' of https://github.com/ferdibiflator/iD into ferdibiflator-merge-way-nodes-feature
2018-04-25 16:19:32 -04:00
Bryan Housel
00e5e8efa0
Avoid reversing osmWays in order to "prefer a forward path"
...
(closes #4872 , related #4859 )
2018-04-18 23:43:19 -04:00
Bryan Housel
ce77538185
Allow connecting FROM nodes to TO nodes if it's a u-turn
2018-04-16 08:00:44 -04:00
Bryan Housel
b2df343f2d
Allow connecting to nodes in the turn restriction from outside
2018-04-14 23:12:19 -04:00
Bryan Housel
87841fc403
Stricter checks to prevent turn restriction breakage when dragging
...
(re: #4921 )
2018-04-13 22:50:51 -04:00
Bryan Housel
8fb083578f
Prevent drag/connect which could damage relations
...
(closes #4921 )
2018-04-12 17:32:16 -04:00
Bryan Housel
b09c712fc5
When connecting nodes, prefer to keep an existing (not new) node
...
(closes #4974 , closes #4674 )
2018-04-09 14:20:40 -04:00
Bryan Housel
734957f283
Handle variants of 'stop' and 'platform' when identifying PTv2 members
...
(closes #4946 )
2018-03-27 21:52:52 -04:00
Bryan Housel
f8bbb995ac
Properly split ways which are members of a via way turn restriction
...
(closes #4861 )
2018-03-10 15:20:20 -05:00
Bryan Housel
aa1565baf8
Avoid reordering stops and platforms in PTv2 routes
...
(closes #4864 )
2018-03-10 00:12:46 -05:00
Bryan Housel
4b1f8a8f61
Merge pull request #4768 from openstreetmap/advanced_intersection
...
Add support for complex intersection and via way restrictions
2018-03-01 01:46:30 -05:00
Bryan Housel
241159b547
Cleanup docs and tests for actionRestrictTurn / actionUnrestrictTurn
...
- actionRestrictTurn will no longer "infer" the turn type
- restrictionType *must* be passed in - this is ok because the only code
we use this action (restrictions.js) already has inferred the type
- this simplifies what the action actually does
- moved the tests from restrict_turn.js that were really just testing
the restriction type inferrence over to intersection.js
(and added a few more tests for iD.osmInferRestriction)
2018-02-28 23:55:59 -05:00
Bryan Housel
0cbff57dc9
Cycle through only_ turn restriction states
...
(re: #2622 )
2018-02-07 19:04:28 -05:00
Bryan Housel
dac753c4ea
Speedup hot code in actionDiscardTags
...
(re: #4611 )
2018-02-04 14:57:26 -05:00
Bryan Housel
c1378a141f
Add support for complex intersection and via way restrictions
2018-02-02 19:58:09 -05:00