Quincy Morgan
627b4ee732
Fixed an bug where the wrong feature could be deleted from the untagged feature issue fix
2018-12-21 14:00:08 -05:00
Quincy Morgan
c9350c632e
Add issue fixes UI
...
Add two issue fixes for untagged feature
2018-12-21 12:31:33 -05:00
Bryan Housel
f7150004c0
Refactor things out of util with limited use, move more to service
2018-12-21 11:56:55 -05:00
Andrew Wong
67bab7aecf
don't import all of d3
2018-12-20 16:31:32 -05:00
Bryan Housel
4eb0e4b3a4
Remove more duplicate strings
2018-12-20 16:09:18 -05:00
Andrew Wong
5971bbebb7
Added more validation tests
2018-12-20 15:39:26 -05:00
Bryan Housel
6e1d6bcfda
Drop legacy translation keys
2018-12-20 15:38:04 -05:00
Bryan Housel
177537f0ce
Move coincident markers away from related geometry and from each other
2018-12-20 15:23:53 -05:00
Quincy Morgan
026597017a
Update styling in the entity issues list
2018-12-20 14:49:35 -05:00
Bryan Housel
7f669d292f
Simplify KeepRight tile fetching code
2018-12-20 14:40:14 -05:00
Quincy Morgan
99e5a52bc9
Improved margins for the entity issues list
2018-12-20 14:18:15 -05:00
Quincy Morgan
d58867df7c
Add entity display label util function
...
Condense message and tooltip text for for the untagged feature issue
Use lighter border color for error issues
2018-12-20 14:04:15 -05:00
Quincy Morgan
373be68294
Merge branch 'master' into validation
2018-12-20 13:58:09 -05:00
Quincy Morgan
7c192a2e36
Fixed bug where the entity ID could not be found for the field
2018-12-20 12:25:35 -05:00
Quincy Morgan
d7ef2de073
Re-organizes issue messages and tooltips
2018-12-20 12:16:54 -05:00
Quincy Morgan
7416fc7ac3
Fixed typo in crossing ways issue label
2018-12-20 10:40:48 -05:00
Quincy Morgan
f0fa59874f
Merge branch 'master' into validation
2018-12-20 10:31:25 -05:00
Quincy Morgan
97c2361f43
Changed initial sidebar screen for highway intersection vertices from preset list to editor
2018-12-20 10:17:16 -05:00
Bryan Housel
62547e3459
Merge pull request #5638 from openstreetmap/5612
...
remove highlight from relation member after it is deleted from relation
2018-12-20 10:10:46 -05:00
Bryan Housel
e2c0f5edcd
Merge pull request #5636 from openstreetmap/5596
...
open combobox if anywhere on box clicked...
2018-12-20 10:09:24 -05:00
Max Grossman
9a5a77f96c
remove unneccessary space
...
ref #5612
2018-12-20 09:24:46 -05:00
Max Grossman
18c32511a2
remove member's highlight when removed from relation
...
ref #5612
2018-12-20 09:23:58 -05:00
Max Grossman
e3407d4168
do not use mouseover, use mousedown!
...
ref #5596
2018-12-20 09:05:23 -05:00
Max Grossman
2dab19e9ae
default to value() if neither d and choice are null in the accept function
...
ref #5618
2018-12-20 08:52:16 -05:00
Max Grossman
5a1dfeec72
open combobox if anywhere on box clicked...
...
ref #5596
2018-12-20 08:47:37 -05:00
Xiaoming Gao
a4e1012c91
add crossing_way validation
...
Tests are also added and passed.
One thing to note: I had to add the tree() function to history so that I can
use the tree in the test; hope that's fine.
2018-12-19 19:23:35 -05:00
Quincy Morgan
2207a6c3a4
Added severity tooltip to issue icon
2018-12-19 18:35:17 -05:00
Quincy Morgan
ac539dddaa
Merge branch 'master' into validation
2018-12-19 18:13:44 -05:00
Quincy Morgan
90e3cd8e87
Merge pull request #5632 from quincylvania/sidebar-behavior-on-feature-selection
...
Change the initial inspector of the sidebar upon feature selection
2018-12-19 18:07:42 -05:00
Quincy Morgan
3cab39f590
Merge pull request #5631 from wonga00/continuous_validation
...
listening to user generated history changes for validation
2018-12-19 17:51:44 -05:00
Quincy Morgan
cfbb86f88c
Change the initial view of the sidebar on selection
2018-12-19 17:44:41 -05:00
Bryan Housel
ca2d4e2c34
Fix layer test
2018-12-19 17:31:55 -05:00
Andrew Wong
6e749c70ef
listening to user generated history changes for validation
2018-12-19 17:28:34 -05:00
Bryan Housel
2deadd5d6c
Fix merge issues
2018-12-19 17:12:06 -05:00
Quincy Morgan
490143d1a8
Added Issues section to the entity sidebar
...
Fixed bug where stale issues would stick around in the issues pane
2018-12-19 16:12:33 -05:00
Xiaoming Gao
efc64f3cf6
Merge pull request #5630 from wonga00/wonga_validation_tests
...
fixed maprules test and added missing_tag test
2018-12-19 14:03:53 -05:00
Thomas Hervey
c501c44f60
updated: KeepRight description text
2018-12-19 13:45:35 -05:00
Thomas Hervey
f4e71812ca
added: help documentation
2018-12-19 13:45:35 -05:00
Thomas Hervey
cedf6955b5
added: notes and todos for keepRight
2018-12-19 13:45:34 -05:00
Thomas Hervey
ee00635cc4
updated: some error colors; fixed: error 320, 220
2018-12-19 13:45:15 -05:00
SilentSpike
1f7455fdad
Add missing error types 73, 74 and 75
2018-12-19 13:45:15 -05:00
SilentSpike
9bd772748a
Convert warnings to regex
...
These aren't shown in the layer currently, but for future use this
should work
2018-12-19 13:45:15 -05:00
SilentSpike
da23bf79a8
Fix parsing of error type 294
2018-12-19 13:45:15 -05:00
SilentSpike
005927dae3
Fix parsing of error type 211
2018-12-19 13:45:15 -05:00
SilentSpike
2b1e37ab78
Handle simple error descriptions explicitly
...
This adds a flag to the error schema to explicitly say whether to parse
the description with regex or not. Prevents us from having to escape
special characters in fixed strings and is a minor optimisation.
2018-12-19 13:45:15 -05:00
SilentSpike
e77d779173
Adhere to style guide for variables
2018-12-19 13:45:15 -05:00
SilentSpike
e0e48b7505
Fix parsing of error type 231
2018-12-19 13:45:15 -05:00
SilentSpike
a2fe431637
Add support for arbitrary number of details
2018-12-19 13:45:15 -05:00
SilentSpike
d054e9cf6b
Convert all error message schema to regex
2018-12-19 13:45:15 -05:00
SilentSpike
1527bbb043
Fix missing and unnecessary semicolons
2018-12-19 13:45:15 -05:00