424bebf099
Convert preliminary amount of errors to regex
...
This focuses on converting error types I found on the map for testing
(can confirm the code is working!) as well as the more problematic cases
from the old code to show that this approach can handle them easily.
2018-12-19 13:45:15 -05:00
bb89827ee7
Use regex group capture to extract error details
2018-12-19 13:45:15 -05:00
fbe3c94b01
updated: punctuation, some specialized QA error parsing
2018-12-19 13:45:14 -05:00
84895834f7
updated: punctuation and missing descriptions
2018-12-19 13:45:14 -05:00
187d1add49
added: outline for KeepRight icon
2018-12-19 13:44:38 -05:00
d125c62c78
updated: variable and function names, html regex
2018-12-19 13:43:48 -05:00
ed34d522ff
updated: check entity type from second word as well
2018-12-19 13:43:48 -05:00
e0d5391f1b
added: entity links within descriptions
2018-12-19 13:43:48 -05:00
d095de08fe
updated comment UI, added stub for POST; TODO: finish links & POST
2018-12-19 13:43:48 -05:00
b5a316df48
fixed: svg icon placement
2018-12-19 13:43:08 -05:00
1335549ad3
cleaned map data UI; commented sub-layer filtering
2018-12-19 13:43:08 -05:00
9948a7729d
Darkened the error item hover color somewhat
2018-12-19 13:41:33 -05:00
805dd394c9
added link for object in header
2018-12-19 13:40:56 -05:00
cbcdfc075c
small UI change to header
2018-12-19 13:40:56 -05:00
6dbea57721
added back supported
2018-12-19 13:40:56 -05:00
3e7146c63f
WIP: menu with sub-layer buttons; TODO: bug fixes, ui updates, wiring buttons
2018-12-19 13:40:56 -05:00
18278371aa
WIP: identifying variables in errors
2018-12-19 13:38:40 -05:00
92cc7eae15
Added hover background colors to the issue list items
2018-12-19 13:38:36 -05:00
0e34313d1d
fixed maprules test
2018-12-19 13:38:21 -05:00
31f35b0389
added basics to sidebar
2018-12-19 13:35:26 -05:00
6ae25eada7
fixing tests around issues
2018-12-19 13:34:16 -05:00
c11ac6ed89
added missing_tag test
2018-12-19 13:33:02 -05:00
14f62ec3b9
Merge branch 'master' into validation
2018-12-19 13:23:54 -05:00
59b0252b0e
Fixed several linting errors
2018-12-19 13:22:48 -05:00
75cff00a2a
displaying keep right (currently as notes)
2018-12-19 13:18:37 -05:00
b96965568f
WIP: added schemas for errors and warnings
2018-12-19 13:13:30 -05:00
b3cffd7833
added simple keepRight button under photoItems
2018-12-19 13:12:49 -05:00
fb182dca37
Removed unneeded code in the issues pane
2018-12-19 13:10:03 -05:00
6a931f9be6
Added colors to issue list icons
...
Corrected icon for warnings
Made disconnected_highway issue a warning instead of an error
2018-12-19 13:07:47 -05:00
a95af00b1d
Added icons to issues list
2018-12-19 12:40:42 -05:00
81b5fc788e
Merge pull request #5629 from openstreetmap/5587
...
5587 - make geolocation show geolocation
2018-12-19 12:14:36 -05:00
c4fb38603e
Merge branch 'master' into validation
2018-12-19 12:14:32 -05:00
e1f26b5692
Merge pull request #5624 from ockendenjo/hat-route
...
Add more tests for splitting ways in relations containing loops
2018-12-19 12:10:12 -05:00
7db6133666
Merge pull request #5583 from quincylvania/field-prerequisite-tags
...
Mechanism for displaying fields conditionally based on tags
2018-12-19 12:08:15 -05:00
c1e3a7396f
filter validations early in history
...
Follow @wonga00's comment in https://github.com/openstreetmap/iD/pull/5627
2018-12-19 12:05:06 -05:00
399e7781c1
remove dispatched changes and re-order layers
...
ref #5587
2018-12-19 11:54:39 -05:00
a05e259628
Added some initial styling for issues list
2018-12-19 11:28:29 -05:00
3755951009
remove unused vars
...
ref #5587
2018-12-19 11:24:26 -05:00
83c0843e57
just call accuracy function when setting r attr
...
ref #5587
2018-12-19 11:23:19 -05:00
b010f42125
update layers test for new geolocate svg layer
...
ref #5587
2018-12-19 11:14:03 -05:00
b9ddfca152
implement point/puck geolocation
...
ref #5587
2018-12-19 11:06:41 -05:00
ff95e6a337
Merge branch 'validationIssueDataModel' into validation
2018-12-19 10:59:45 -05:00
f478fdbfbd
Add preset for Enforcement relation type
...
(closes #5610 )
2018-12-19 10:45:54 -05:00
903cb63efe
Renamed validations to issues in relevant places
...
Made the issue pane get the issues from the issue manager rather than validating itself
2018-12-19 10:41:58 -05:00
07a53fe6ea
Extend data model for validation issues
...
Add the Issues pane
1. Add a class to represent the validation issue
2. Extend the data model for an validation issue to
(1) add a severity level field (useful for identify save-blocking issues later)
(2) replace single entity with an array of entities (useful for issues involving multiple entities)
(3) add a coordinates field for highlighting the location of the issue on the map
(4) add a fixes field for possible automatic fixes
3. Update existing validation modules to use the new data model
2018-12-19 10:37:32 -05:00
0d0521c936
Moved feature applicability into the issue manager class
2018-12-19 10:32:14 -05:00
161311faa5
Merge pull request #5626 from wonga00/wonga_issue_manager
...
added IssueManager
2018-12-18 18:05:40 -05:00
858a9606d5
Added entity display name or preset name to the disconnected highway message
2018-12-18 18:05:27 -05:00
30f25c6e8d
added IssueManager
...
- IssueManager performs validation on the current graph and also
stores the issues and notifies listeners when the issues changed
2018-12-18 17:52:23 -05:00
cec442012a
Add test for route going round loop in other direction
2018-12-18 22:09:20 +00:00
SilentSpike