Martin Raifer
aa96a67c65
use lodash-es everywhere, replace custom clamp methods with lodash
2025-04-21 14:43:35 +02:00
Martin Raifer
4254e67ca7
render addresses (housenumber/housename)
...
* points with a dedicated marker
* text inside of areas
2025-04-17 17:47:08 +02:00
Mateusz Konieczny
2ff01beba3
Better describe culvert in fix for waterway-road intersection warnings ( #10783 )
2025-02-17 18:59:29 +01:00
Justin Tracey
d6ee1bb4cd
add crossing:markings tag when connecting crossing ( #9586 )
2025-02-17 12:57:25 +01:00
Kyle Hensel
f244e63661
validate crossing aeroways ( #9315 )
2025-02-05 14:42:32 +01:00
Kyle Hensel
90c4241723
fix dependency cycle caused by utilDisplayLabel importing presetManager
2024-08-24 11:34:46 +10:00
Martin Raifer
140838f4b1
fix accidentally committed code, switch to different ford icon
2023-05-26 19:50:09 +02:00
Martin Raifer
f517b867de
add tests for #9650
2023-05-25 15:24:52 +02:00
Martin Raifer
9517d06d11
use lodash for object comparison
2023-05-25 13:22:39 +02:00
Minh Nguyễn
e4641b581f
Offer to connect sidewalk to service road without tagging crossing ( #9650 )
2023-05-25 13:17:34 +02:00
archpdx
81374c3735
Fix connect features with uncontrolled crossing ( #9443 )
2023-01-19 11:59:16 +01:00
Martin Raifer
41aa127d23
reduce use of parseFloat
...
as it silently strips non-numeric suffixes (e.g. a value of "123 foo" is transformed into a numeric value of 123 by `parseFloat`, which is typically not what we desire)
2022-11-24 19:39:15 +01:00
Martin Raifer
0c1d4c7c44
Merge remote-tracking branch 'faebebin/fix/9176-connect-features-crossing-with-pedestrian-signals' into develop
2022-07-19 16:38:18 +02:00
faebebin
9dcc6d1e7d
Fix connect features when crossing with pedestrian signals
2022-06-24 19:02:33 +02:00
Martin Raifer
8bb1d39431
refactor validation modules to not inject html
2022-06-24 13:25:56 +02:00
Martin Raifer
6a9e0997c7
Handle indoor features like buildings when checking for crossing ways
...
see https://github.com/openstreetmap/iD/issues/8944#issuecomment-1029213558
2022-02-03 19:11:27 +01:00
Martin Raifer
9f3f8e1366
rename method
2021-11-29 19:26:18 +01:00
Martin Raifer
d78c357588
replace raw html injection of localized texts
...
by using d3 to insert the localized text spans directly into the DOM
2021-11-26 18:51:45 +01:00
Martin Raifer
4f51ededfd
fix eslint "no-implicit-coercion" warning
...
See https://eslint.org/docs/rules/no-implicit-coercion for this warning. However the implicit type conversion is unnecessary here, since `Number.toFixed` already returns a string, see https://developer.mozilla.org/de/docs/Web/JavaScript/Reference/Global_Objects/Number/toFixed .
2021-11-16 11:20:01 +01:00
Bryan Housel
1f172d5623
Make the crossing_ways hash less strict
...
Previously it was including a lot of data about the edge, and a very specific
crossing location. This meant that any tiny perturbation in the crossing ways
would generate a new issue hash, effectively "fixing" the old crossing issue and
creating a new one.
2021-08-13 16:24:29 -04:00
Bryan Housel
b5d7cdb6fa
Use utilHashcode to generate reasonable ids for crossing_ways issues
...
The ones before were a giant blob of json
2021-08-13 12:56:50 -04:00
Milos Brzakovic
750b4e023f
crossing_ways fixing - specially handle crossing nodes
2021-08-05 14:50:38 +02:00
Bryan Housel
4c1d51348d
Don't repurpose a node with interesting tags in crossing_ways fix
...
(closes #8326 )
2021-01-27 14:38:11 -05:00
Quincy Morgan
c940d827e6
Enable the Split operation for multiple selected nodes ( close #7990 )
2020-09-24 15:13:05 -04:00
Quincy Morgan
7b5df1bc40
Add lang attribute to issue fix labels (re: #7963 )
2020-09-22 17:48:35 -04:00
Quincy Morgan
aa9b44a0bf
Add the lang attribute to issue messages (re: #7963 )
2020-09-22 17:25:18 -04:00
Quincy Morgan
5435082d9c
Revert t function to returning the plain string by default
...
Add `t.html` function for getting the string with the `lang` attribute
2020-09-22 12:03:29 -04:00
Quincy Morgan
32f8274929
Make t function return a span element with a lang attribute unless html: false is specified in the options (re: #7963 )
...
Update `text` functions to `html` to support inserting the `span` elements
Specify `html: false` for various instances where a `span` is not desired, e.g. `placeholder` and `title` attributes
2020-09-15 21:56:22 -04:00
Quincy Morgan
e5d4fcfa44
Properly handle disambiguating tags on crossing multipolygons ( close #7935 )
2020-09-01 17:31:16 -04:00
Quincy Morgan
59aa79548e
Use tram crossing tags when connecting crossing tram tracks with roads/paths ( close #7902 )
2020-08-15 13:25:26 -04:00
Peter Newman
4205ca1d07
Fix the seemingly safe spellings found by codespell
...
Untested, only checked by inspection.
(cherry picked from commit 2c47a11008
2020-08-10 17:32:37 +01:00
Quincy Morgan
d179f791a9
Significantly improve the performance of the crossing_ways validation in areas with long ways ( close #7656 )
2020-06-22 16:49:32 -04:00
Quincy Morgan
ef48fb0c50
Fix potential error in crossing ways validation
2020-04-14 15:52:05 -07:00
Quincy Morgan
3a933de876
Don't add tags to connection node when connecting crossing line/area
2020-04-13 18:57:26 -07:00
Quincy Morgan
513b344012
Fix code tests
2020-04-03 13:33:54 -07:00
Quincy Morgan
ca1e2031e7
Flag issues with crossing highway areas ( close #7455 )
...
Don't show add bridge/tunnel fixes for highway areas (close #7472 )
2020-04-03 12:30:07 -07:00
Quincy Morgan
0120b009fa
Take a graph parameter in utilDisplayLabel instead of the context
2020-04-01 13:29:17 -07:00
Quincy Morgan
a1af118f0e
Ensure locales and presets are loaded before the UI loads ( close #7406 )
...
Consolidate localization behavior and init to a coreLocalizer function and singleton
Explicitly support `en-US` locale
Rename coreData to coreFileFetcher and export a singleton rather than using a property of coreContext
Add `apiConnections` property of coreContext to simplify adding a source switcher
Replace some init functions with re-callable, promise-supporting `ensureLoaded` functions
Make coreContext itself load the UI if a container has been specified at init time
Fix code tests
2020-03-31 12:23:31 -07:00
Quincy Morgan
a7cba6a694
Don't show the tunnel fix for features crossing waterways (re: #7447 )
2020-03-23 10:13:21 -07:00
Bryan Housel
fe5ca6867c
Fix error in generating outdated_tags messgae
2020-02-04 13:00:14 -05:00
Quincy Morgan
45d22261fc
Don't leave an extra junction segment when the end node of the crossing edge is only the endpoint of two lines (re: #7202 )
...
Make the length of added crossing structures much closer to the intended spherical length
2020-01-16 17:55:13 -05:00
Quincy Morgan
6c30ae2664
Where possible, leave a segment between structures and intersections when applying the "add a bridge/tunnel" fix ( close #7202 )
2020-01-09 11:36:19 -05:00
Quincy Morgan
4adecbb6ac
Account for the angle of the crossing in the length of structures when applying "add a bridge/tunnel" fixes
2020-01-08 14:11:27 -05:00
Quincy Morgan
09ad21a26f
Improve "add a bridge/tunnel" fixes by basing the structure length on the crossed feature type, not a fixed constant (re: #7202 )
2020-01-08 12:03:30 -05:00
Quincy Morgan
a7dd6db8a7
Use tunnel=culvert on waterways when using the "add a tunnel" crossing ways fix (re: #6617 )
2019-12-11 10:31:33 -05:00
Quincy Morgan
394396326c
Update to temaki 3.4.0 ( close #7102 )
2019-12-09 12:44:17 -05:00
Quincy Morgan
62865db740
Fix issue where crossing ways layer fix would set layer tag as a number instead of a string (re: #6911 )
2019-11-22 15:50:40 -05:00
Quincy Morgan
7cd57789fe
Improve "add a bridge/tunnel" fix variable names somewhat (re: #7055 )
...
Add a minimum structure length as derived from the crossing feature's width
2019-11-20 16:58:42 -05:00
Quincy Morgan
ff6eb88957
Update add a bridge/tunnel fix icons
2019-11-20 16:04:10 -05:00
Quincy Morgan
e791b7514c
Use existing vertices for "add a bridge/tunnel" endpoints if the edge is too short to add a new vertex (re: #7055 )
...
Avoid creating very short edges from splitting too close to another node when adding a bridge or tunnel via fix
Fix possible "entity not found" error
2019-11-20 15:44:14 -05:00
