Commit Graph

4095 Commits

Author SHA1 Message Date
Bryan Housel
b032cd9f01 Adust NSI matching validation code:
- don't try matching semicolon-separated lists to NSI
- better matching for flagpoles with a `country` tag
- better lists of namelike keys (don't match flag operator)

see: https://github.com/openstreetmap/iD/pull/8305#issuecomment-769174070
2021-01-28 17:17:49 -05:00
Bryan Housel
3640e15fa2 Fix misspelling "coprorate" -> "corporate" 2021-01-27 11:54:39 -05:00
Bryan Housel
f87c2d9357 Allow validators to return provisional results, revalidate after delay
Also add a ton of commments to validator.js
2021-01-27 10:38:48 -05:00
Bryan Housel
11201eb822 Rewrite the validator in ES6/Promises, several improvements here:
- implements a validation work queue, jobs are run during browser idle callbacks
- when merging base entities, don't run validations 2x on both base and head graphs (this was wasteful)
- keep track of resolved issues in a separate set (it's not a simple compare of base/head anymore)
  this happens after validation queue is empty and avoids race conditions and inaccurate resolved counts
2021-01-25 12:50:11 -05:00
Bryan Housel
96298f2836 Preserve name value if this preset shows brand or operator field
This also fixes the logic for calculating whether the preset shows a
`brand` or `operator` field - it needs to use `fields()` to actually
resolve the fields, as these fields can be inherited from another preset.

This also includes a change to match "primary" names before
"alternate" names (aka the "Baby Gap" / "Gap" problem)
2021-01-19 13:15:16 -05:00
Bryan Housel
f61a3ef5e3 Don't replace flag:name tag - it's expected to be in local language 2021-01-18 21:44:27 -05:00
Bryan Housel
a32553595c name:pronunciation is not namelike 2021-01-18 21:39:06 -05:00
Bryan Housel
74d28257c4 Fix teh misspellings 2021-01-18 19:48:35 -05:00
Bryan Housel
4228b65602 Support more *:wikidata tags for field locking and pin styling 2021-01-18 17:18:37 -05:00
Bryan Housel
f39f73e3ae Make sure suggestion preset terms get used in the search 2021-01-18 15:02:07 -05:00
Bryan Housel
a38a93c073 Actually assign the locationSetID properties on the given objects
(should have been in 868db8819)
2021-01-18 13:41:46 -05:00
Bryan Housel
0b3795cde3 NSI match returns an object now 2021-01-15 17:25:24 -05:00
Bryan Housel
d3fb8c60f9 Upgrade validations outdated_tags, suspicious_names to NSI v5 2021-01-13 13:46:00 -05:00
Bryan Housel
2d8c90786f coreLocation tests, documentation 2021-01-11 13:01:30 -05:00
Bryan Housel
868db8819f Have mergeLocationSets work on Objects, add locationSetID property
This means less work for the other parts of the code,
now they don't need to chain that extra step after the promise.
2021-01-09 10:34:58 -05:00
Bryan Housel
c4daf1b377 Use locationManager to resolve/query community index 2021-01-08 17:05:37 -05:00
Bryan Housel
271e1c2e19 Use locationManager to filter fields/presets/defaults 2021-01-08 16:06:57 -05:00
Bryan Housel
ab85590eb4 Pre-resolve the world locationSet 2021-01-08 14:00:49 -05:00
Bryan Housel
0ad7de0f10 Move the location index and resolver into a global coreLocations 2021-01-08 11:29:51 -05:00
Bryan Housel
9eb6f8781f Update presetIndex to resolve and index locationSets
Added a deferred work queue to do this with requestIdleCallback in the background
2021-01-06 16:26:12 -05:00
Bryan Housel
b0800c10ed Update to name-suggestion-index v5
Merge in NSI presets after UI has initialized
2021-01-05 12:44:33 -05:00
Quincy Morgan
2c2eabb145 Don't count tags under the name namespace as descriptive tags (close #8273)
Don't count `description`, `note`, `start_date`, or tags under those namespaces as descriptive tags
2021-01-05 09:56:19 -05:00
Quincy Morgan
af4acaec79 Don't clear power output tag when changing between power presets (close #8159) 2020-12-21 13:17:18 -05:00
Quincy Morgan
6cd81df1a2 Fix preset search result sorting (re: #8242) 2020-12-21 11:26:34 -05:00
Quincy Morgan
2591a13f9c Honor diacritics on preset search value but still compare to stripped preset names (re: #8242) 2020-12-21 11:14:10 -05:00
Quincy Morgan
c61924407d Add icon styling for Mountain Biking Route preset (re: https://github.com/openstreetmap/id-tagging-schema/issues/99) 2020-12-21 10:08:55 -05:00
Quincy Morgan
d57ed85e98 Merge branch develop 2020-12-16 11:43:36 -05:00
Bryan Housel
9e93701c58 Update osm-community-index to v3.0.1
The major version bump is because
- it no longer distributes index.js/index.mjs code bundles
   (which iD hasn't needed in a long time anyway)
- renamed dist/features.json -> dist/featureCollection.json
2020-12-16 09:25:11 -05:00
Quincy Morgan
0a0e2dcf75 Fix issue where extracting points could results in off placements (close #8246) 2020-12-11 12:50:32 -05:00
Quincy Morgan
b3ad282f40 Ignore diacritics when searching presets (close #8242) 2020-12-09 17:12:43 -05:00
Quincy Morgan
c8c288d6a3 Support using delete/backspace on focused, readonly combo fields
Make custom combo field values lowercase if they're also made snake_case
2020-12-09 15:26:45 -05:00
Quincy Morgan
cb7f1c2b3c Update to id-tagging-schema v3.0.0
Add UI for translatable combo fields
2020-12-08 15:23:51 -05:00
Quincy Morgan
17cd39a6f7 Use addTags for preset category icon classes 2020-12-07 15:17:20 -05:00
Quincy Morgan
998f0c02b4 Use area fills for category icons (close #6986) 2020-12-07 14:55:09 -05:00
Quincy Morgan
7911152dec Merge branch 'develop' into unbundled-presets
# Conflicts:
#	dist/locales/en.json
2020-12-07 10:57:14 -05:00
Quincy Morgan
32dcfcc08e Fix spelling 2020-12-07 10:55:43 -05:00
Quincy Morgan
2dd6bce851 Add quick fix to convert areas to lines for mismatched geometry validation 2020-12-07 09:47:18 -05:00
Quincy Morgan
c43fac8d64 Ignore nodes on address lines for the mismatched geometry validation 2020-12-07 09:46:37 -05:00
Quincy Morgan
a7b3985237 Flag points as areas or lines, areas or lines as points, and lines as areas (close #8231) 2020-12-04 16:22:36 -05:00
Quincy Morgan
40362f1d08 Fix issue with removing multilingual name entries 2020-12-04 11:59:51 -05:00
Quincy Morgan
0bc2b1b6a0 Improve multilingual name UI updates, don't use blank tag values (re: #8164) 2020-12-04 10:22:18 -05:00
Quincy Morgan
0bd2351d68 Don't remove multilingual name list items when deleting the name value (close #8164)
Allow removing multilingual name list items that don't have full values
2020-12-03 16:26:58 -05:00
Quincy Morgan
655c3a692c Enable dragging the map during feature move and selection without exiting the mode (close #8187) 2020-12-03 15:05:19 -05:00
Quincy Morgan
611abf8ed0 Enable rotating selection even when mouse isn't over the map (re: #8187) 2020-12-03 15:04:21 -05:00
Quincy Morgan
a85ac34a35 Add tooltip to the review request checkbox (close #7227) 2020-12-03 13:50:56 -05:00
Quincy Morgan
9f6aaf2438 Add folder border to preset category icons (close #6085) 2020-12-03 13:13:08 -05:00
Quincy Morgan
07a59ba3a4 Break out some preset icon functions (re: #8117) 2020-12-03 12:23:09 -05:00
Quincy Morgan
2dd0b8449f Rewrite some confusing nested ternaries (close #8117) 2020-12-03 12:18:39 -05:00
Quincy Morgan
ec1c922cda Allow moving single nodes using the Move operation (close #8225) 2020-12-02 15:13:33 -05:00
Quincy Morgan
102fe6277c Add checks for calling coreLocalizer.tInfo before loading strings 2020-12-02 10:10:20 -05:00