Commit Graph

343 Commits

Author SHA1 Message Date
Bryan Housel
96298f2836 Preserve name value if this preset shows brand or operator field
This also fixes the logic for calculating whether the preset shows a
`brand` or `operator` field - it needs to use `fields()` to actually
resolve the fields, as these fields can be inherited from another preset.

This also includes a change to match "primary" names before
"alternate" names (aka the "Baby Gap" / "Gap" problem)
2021-01-19 13:15:16 -05:00
Bryan Housel
4228b65602 Support more *:wikidata tags for field locking and pin styling 2021-01-18 17:18:37 -05:00
Quincy Morgan
c8c288d6a3 Support using delete/backspace on focused, readonly combo fields
Make custom combo field values lowercase if they're also made snake_case
2020-12-09 15:26:45 -05:00
Quincy Morgan
cb7f1c2b3c Update to id-tagging-schema v3.0.0
Add UI for translatable combo fields
2020-12-08 15:23:51 -05:00
Quincy Morgan
7911152dec Merge branch 'develop' into unbundled-presets
# Conflicts:
#	dist/locales/en.json
2020-12-07 10:57:14 -05:00
Quincy Morgan
40362f1d08 Fix issue with removing multilingual name entries 2020-12-04 11:59:51 -05:00
Quincy Morgan
0bc2b1b6a0 Improve multilingual name UI updates, don't use blank tag values (re: #8164) 2020-12-04 10:22:18 -05:00
Quincy Morgan
0bd2351d68 Don't remove multilingual name list items when deleting the name value (close #8164)
Allow removing multilingual name list items that don't have full values
2020-12-03 16:26:58 -05:00
Quincy Morgan
baabd81987 Unbundle id-tagging-schema data and translations
Update for id-tagging-schema 2.0.0
2020-12-01 11:14:14 -05:00
Quincy Morgan
ba48a861bc Enable curly and block-spacing eslint rules 2020-11-10 14:19:11 -05:00
Quincy Morgan
8147fcfa84 Show multilingual values in the Name field even for keys with spaces or other unexpected characters (re: #8165) 2020-11-06 17:38:09 -05:00
Quincy Morgan
1a43dbe1fe Use the actual dropdown label for the localized name language input label (re: #8165) 2020-11-06 17:36:32 -05:00
Quincy Morgan
02add6e3ff Fix issue where existing multiCombo field values wouldn't appear (close #8155) 2020-11-06 16:14:58 -05:00
Quincy Morgan
e83235df54 Fix regression where changing the Wikidata field wouldn't update the wikidata tag (close #8132) 2020-10-29 10:05:43 -04:00
Quincy Morgan
b2582dcf9e Fix critical issue with editing Bike Lanes and Allowed Access fields 2020-10-27 20:44:56 -04:00
Quincy Morgan
154c6ed0ed Fix issue where clicking some buttons would clear the URL hash 2020-10-27 09:56:05 -04:00
Quincy Morgan
dc8fd13586 Enable array-callback-return eslint rule 2020-10-23 13:47:09 -04:00
Quincy Morgan
4059ee5118 Enable block-scoped-var eslint rule 2020-10-23 13:38:36 -04:00
Quincy Morgan
0f716e93f8 Merge branch 'develop' into d3-6 2020-10-13 13:38:09 -04:00
Quincy Morgan
c214a6c6e2 Add increment property for numeric fields (close #7867) 2020-10-13 12:00:01 -04:00
Quincy Morgan
baace6d092 Update more code for D3 v6 2020-10-07 11:57:25 -04:00
Quincy Morgan
21a49bbec8 Initial support for D3 v6.2.0 2020-10-06 15:08:39 -04:00
Quincy Morgan
79b6a9d863 Add lang attribute to text in turn restriction editor (re: #7963) 2020-09-29 16:38:23 -04:00
Quincy Morgan
3b793351f7 Fix issue where names with en dashes couldn't be added (close #7536)
Add `lang` attribute to brand name dropdown labels (re: #7963)
2020-09-28 15:28:07 -04:00
Quincy Morgan
087e7eac14 Enable removing multicombo field values with keyboard (re: #8004) 2020-09-28 15:03:29 -04:00
Quincy Morgan
9a8cae70d2 Fix lint errors 2020-09-24 11:35:38 -04:00
Quincy Morgan
4d51713253 Add lang attribute to more display text (re: #7963) 2020-09-24 11:34:33 -04:00
Quincy Morgan
482d0902ac Fix issues with Wikidata field 2020-09-24 10:27:35 -04:00
Quincy Morgan
f163722c9a Create a new manyCombo field type for the public transport vehicles field instead of using multiCombo in a new way (re: #6142) 2020-09-24 09:21:59 -04:00
Quincy Morgan
9da4c4bb62 Add lang attribute to more labels (re: #7963) 2020-09-23 10:44:38 -04:00
Quincy Morgan
4600ab596f Add lang attribute to more display labels (re: #7963) 2020-09-23 10:10:24 -04:00
Quincy Morgan
5435082d9c Revert t function to returning the plain string by default
Add `t.html` function for getting the string with the `lang` attribute
2020-09-22 12:03:29 -04:00
Quincy Morgan
a3549f9a76 Merge branch 'develop' into lang-attributes
# Conflicts:
#	modules/ui/commit_warnings.js
#	modules/ui/field.js
#	modules/ui/fields/wikidata.js
#	modules/ui/fields/wikipedia.js
#	modules/ui/full_screen.js
#	modules/ui/panels/history.js
#	modules/ui/sections/entity_issues.js
#	modules/ui/sections/map_features.js
#	modules/ui/sections/raw_member_editor.js
#	modules/ui/sections/validation_rules.js
#	modules/ui/tag_reference.js
2020-09-22 10:55:07 -04:00
Quincy Morgan
79688ce2d9 Show count and use plural forms for more operation strings (re: #8014) 2020-09-22 09:10:49 -04:00
Quincy Morgan
7157feba20 Don't make button text bold by default
Make the oneway field reverser a button instead of a link
2020-09-18 13:14:01 -04:00
Quincy Morgan
58014ace62 Don't prevent default tabbing to elements (re: #8004) 2020-09-17 12:07:20 -04:00
Quincy Morgan
a3f9c3fb81 Merge branch 'develop' into lang-attributes
# Conflicts:
#	modules/ui/fields/combo.js
2020-09-17 09:07:18 -04:00
Quincy Morgan
98bea69947 Add Vehicles field for public_transport presets (close #6142, re: #7970)
Enable variant type of `multiCombo` field that works for any listed keys, not ones under a prefix
2020-09-16 15:15:10 -04:00
Quincy Morgan
32f8274929 Make t function return a span element with a lang attribute unless html: false is specified in the options (re: #7963)
Update `text` functions to `html` to support inserting the `span` elements
Specify `html: false` for various instances where a `span` is not desired, e.g. `placeholder` and `title` attributes
2020-09-15 21:56:22 -04:00
Quincy Morgan
42efdf29f1 More progress on #7965 2020-09-10 15:03:18 -04:00
Quincy Morgan
426af25ae4 Fix code tests re: #7890 2020-09-02 16:32:30 -04:00
Quincy Morgan
caf1343b62 Properly default the Wikipedia field language to iD's current language (close #7890) 2020-09-02 14:51:15 -04:00
Peter Newman
4205ca1d07 Fix the seemingly safe spellings found by codespell
Untested, only checked by inspection.

(cherry picked from commit 2c47a11008)
2020-08-10 17:32:37 +01:00
Quincy Morgan
5fbaad1088 Make the waterway destination field separate from the road sign destination field (re: 7c5ec9be70)
Make the destination field for the destination_sign preset a semiCombo (re: #6970)
2020-06-24 16:31:28 -04:00
Quincy Morgan
cc52b6cfd4 Prevent empty combo fields from adding a blank tag 2020-06-18 10:51:12 -04:00
Quincy Morgan
5f93da5a59 Add a reusable function for calculating the combined extent of multiple entities (re: #7706) 2020-06-16 13:17:43 -04:00
Quincy Morgan
4467c4a501 Fix issue where spaces couldn't be typed in the changeset comment (re: #6817) 2020-06-11 10:52:58 -04:00
Quincy Morgan
874c412b74 Enforce max unicode charachter length of keys, values, and relation roles through truncation upon input rather than HTML maxlength attribute (close #6817)
Normalize unicode when changing keys, values, and relation roles
2020-06-10 14:11:55 -04:00
Quincy Morgan
d01f1598d3 Show the delete button for filled multilingual name fields even if no name tag is present (close #7572)
Focus the language input when clicking a multilingual name field label instead of deleting the value
Be more lenient with `utilUniqueDomId` function input
2020-06-10 10:35:03 -04:00
Quincy Morgan
762307bd7d Restrict key, value, and role character limits based on unicode characters, not UTF-16 code units (re: #6817) 2020-06-09 15:41:15 -04:00