Commit Graph

2927 Commits

Author SHA1 Message Date
Bryan Housel
b4ebaaa01e Fix raw tag editor styling for custom data editor
(closes #6427)
2019-05-24 11:32:14 -04:00
Quincy Morgan
c95cead06d Fix bug where issues would not be properly centered if the map was not already at z19 (close #6384) 2019-05-24 10:28:59 -04:00
Bryan Housel
2a08868c14 Fix vector tile layers
(closes #6426)

After switching from XHR->fetch, we now parse the response separately,
so the `vtToGeoJSON` function already has an ArrayBuffer to work with.
2019-05-24 10:15:35 -04:00
Bryan Housel
0ded25885d Back off if the toLoad queue is filling up..
(re #6417)
2019-05-24 09:44:35 -04:00
Quincy Morgan
43cd46f046 Prevent Chrome autofill of recent values in the Allowed Access inputs (close #6414) 2019-05-24 09:30:06 -04:00
Bryan Housel
a5a7e0aaf1 Switch Bing Imagery Key
(re: #5833)
2019-05-24 01:32:02 -04:00
Bryan Housel
77f89d4170 Merge branch 'validation_fix_issues' 2019-05-23 19:41:13 -04:00
Bryan Housel
149a0b43b3 Use latest entity at time of fix for private_data validation too
(re: #6407)
2019-05-23 19:40:10 -04:00
Bryan Housel
5440467db0 Undo 5b8db55b4 and instead get latest entity at time of fix
Per conversation w @quincylvania we need the issue ids to remain
stable so that users can ignore them.

So instead of forcing a refresh by changing the `id` we will grab current
versions of entities at fix time so that tags aren't replaced wrongly.
2019-05-23 18:52:32 -04:00
Quincy Morgan
ca19d50558 Fix issue where duplicate expanded community entries could appear (close #6422) 2019-05-23 17:02:15 -04:00
Quincy Morgan
0dfd0612b1 For ice rinks, prefer the "sport" values "ice_hockey" and "ice_skating" instead of "hockey" and "skating" since that latter are ambiguous
Don't remove other values when upgrading a tag value within a semicolon-delimited list
2019-05-23 15:39:15 -04:00
Quincy Morgan
8e66b74bcc Make unsquare threshold field wider to account for stepper control in Firefox (close #6418) 2019-05-23 10:01:30 -04:00
Bryan Housel
5b8db55b47 Need issue id to actually change for d3 to replace it
(re: #6407)

What's happening here is that the validator is updating the issues, but the
entity_issues component leaves the original issue in the list because the `id`
has not changed.

Need to review all the validators to see if others have this problem too.
2019-05-22 23:47:53 -04:00
Quincy Morgan
28db4df86b Flag detached points that are very close together (close #6394)
Fix lint error
2019-05-22 15:50:20 -04:00
Quincy Morgan
030b4b3efa Flag almost junctions between highways and themselves (close #6373) 2019-05-22 14:12:23 -04:00
Quincy Morgan
35b3102006 Add Disable All and Enable All buttons for the Map Features list (close #5234) 2019-05-22 11:56:04 -04:00
Quincy Morgan
6260cdbb8f Fix several lint warnings 2019-05-22 10:48:39 -04:00
Quincy Morgan
f5a8615f5c Fix bug where iD could add empty source tag to changeset (close #6405) 2019-05-22 10:47:23 -04:00
Quincy Morgan
854eacdc7e Add feature filters for pistes and aerialways 2019-05-22 10:38:04 -04:00
Quincy Morgan
30b01906e3 Hide indoor areas and building part areas when those features types are disabled (re: #6352) 2019-05-22 10:08:30 -04:00
Quincy Morgan
76b98f14e0 Merge pull request #6352 from tordans/filder-for-building-part-and-indoor
Add filter building:part and indoor
2019-05-22 09:47:45 -04:00
Quincy Morgan
82ab18dd8b Show better warning message if tags and incomplete rather than deprecated (close #6410) 2019-05-22 09:38:47 -04:00
Quincy Morgan
9a8623748f Don't flag private data only buildings that are also offices (close #6404)
Flag private data on building=houseboat
2019-05-22 08:40:48 -04:00
Bryan Housel
b7089675a1 v2.15.0 2019-05-21 13:07:58 -04:00
Bryan Housel
e1331016d1 Merge pull request #6386 from openstreetmap/configurable-squareness
Allow user to adjust the threshold for the unsquare building warning
2019-05-20 21:04:30 -04:00
Bryan Housel
2f0e0dffdb Merge pull request #6389 from openstreetmap/wikidata-style
Support special styling for Wikidata-tagged features
2019-05-20 18:05:29 -04:00
Bryan Housel
69a25fd6aa Move locking code from input and localized up to uiField
Also adjust styles some more for wikidata tagged items
2019-05-20 17:50:50 -04:00
Quincy Morgan
460f136819 Lower default threshold for unsquare building detection to 5 degrees
Use the detection threshold for the action when fixing unsquare buildings
Don't disallow unsquare autofixing based on maximum angle
Disallow unsquare autofixing for features with wikidata tags
Don't toggle rule when selecting degree threshold field in Safari
Apply the change when pressing enter in the degree threshold field
Select the input when clicking the degree threshold field
Use the min or max threshold instead of the default when an input is out of bounds
2019-05-20 15:48:01 -04:00
Bryan Housel
06bdfbfb8a Use gray stroke on marker and lock icon on field for locked item 2019-05-20 15:36:10 -04:00
Quincy Morgan
39784cdd1f Merge in master 2019-05-20 14:38:52 -04:00
Quincy Morgan
4fb4f88e5a Fix issue where only the first page of mapillary results would be shown (close #6382) 2019-05-20 12:36:12 -04:00
Quincy Morgan
e599488121 Lower the very close nodes warning threshold for buildings, building parts, and paths (re: #6374)
Flag very close nodes in indoor features but with an extremely small threshold
2019-05-20 11:21:50 -04:00
Bryan Housel
6eb73e7de6 Don't adjust map labels for wikidata tagged items 2019-05-20 10:55:23 -04:00
Bryan Housel
0f387c9fcd Include office key for name-suggestion-index matching
In anticipation of https://github.com/osmlab/name-suggestion-index/issues/2634
2019-05-19 21:42:57 -04:00
Bryan Housel
b09b43f6d3 Trim the user's string when preset searching
(closes #6383)
2019-05-19 21:37:09 -04:00
Bryan Housel
0982379187 Don't offer to upgrade brands without a brand:wikidata tag 2019-05-19 00:16:05 -04:00
Bryan Housel
344aec206c Support special styling for wikidata-tagged features 2019-05-18 23:57:23 -04:00
Bryan Housel
511f8ecc82 Allow user to adjust the threshold for the unsquare building warning 2019-05-18 15:44:29 -04:00
Quincy Morgan
936822849a Don't consider "highway=raceway" as routable (#6385)
Update the icon for the raceway preset
2019-05-18 11:49:25 -04:00
Bryan Housel
cc4991d111 Don't draw until we've set zoom/lat/long 2019-05-17 11:19:38 -04:00
Bryan Housel
f062570eef Merge pull request #6376 from openstreetmap/routing-island-validation
Flag routing islands
2019-05-17 10:21:51 -04:00
Bryan Housel
7a07506edc Skip ambiguous matches (like Target~(USA) vs Target~(Australia))
This also reorders the nsiKeys array to maybe match slightly quicker
2019-05-17 09:45:08 -04:00
Bryan Housel
94c5164fe2 Add ability to show the square threshold in the rule name 2019-05-17 02:15:20 -04:00
Bryan Housel
8d0fa289cf Include name-suggestion-index matcher in outdated_tags validator 2019-05-17 01:58:57 -04:00
Quincy Morgan
e697bdbeb1 Flag disconnected ferry routes
Flag disconnected highway multipolygon outer member ways
Let routing islands cross ferry routes
2019-05-17 00:15:53 -04:00
Quincy Morgan
07bc2821cd Flag entire routing islands as single issues 2019-05-16 22:40:25 -04:00
Bryan Housel
bdb454e1b3 Remove utilCallWhenIdle, use requestIdleCallback/cancelIdleCallback
Places where a reset or connection switch would be problematic,
we can now cancel the callbacks.
2019-05-16 22:28:56 -04:00
Bryan Housel
a8c6ab4d67 Move requestIdleCallback polyfill to id.js, remove utilIdleWorker
`utilIdleWorker` was only used one place.
It just processes a list in an idle callback.

I'm working towards removing the util functions for handling idle work.
We can still do `requestIdleCallback` work throughout the code, however
each place we use it needs to have a strategy for cancellation, which
the existing util functions don't allow for.
2019-05-16 21:19:25 -04:00
Bryan Housel
ec0145de3a Prevent accidental loading of many tiles at low zoom
This could happen because `editable` was checked before the call was scheduled
not before the `loadTiles`.  The user can zoom out more while the call is deferred.
2019-05-16 16:44:19 -04:00
Bryan Housel
aa7820b699 Don't treat new raw_tag_editor rows the same as deleted rows
(closes #6369)
2019-05-16 15:36:47 -04:00