Commit Graph

399 Commits

Author SHA1 Message Date
Bryan Housel
2a08868c14 Fix vector tile layers
(closes #6426)

After switching from XHR->fetch, we now parse the response separately,
so the `vtToGeoJSON` function already has an ArrayBuffer to work with.
2019-05-24 10:15:35 -04:00
Bryan Housel
0ded25885d Back off if the toLoad queue is filling up..
(re #6417)
2019-05-24 09:44:35 -04:00
Quincy Morgan
4fb4f88e5a Fix issue where only the first page of mapillary results would be shown (close #6382) 2019-05-20 12:36:12 -04:00
Bryan Housel
bdb454e1b3 Remove utilCallWhenIdle, use requestIdleCallback/cancelIdleCallback
Places where a reset or connection switch would be problematic,
we can now cancel the callbacks.
2019-05-16 22:28:56 -04:00
Bryan Housel
a8c6ab4d67 Move requestIdleCallback polyfill to id.js, remove utilIdleWorker
`utilIdleWorker` was only used one place.
It just processes a list in an idle callback.

I'm working towards removing the util functions for handling idle work.
We can still do `requestIdleCallback` work throughout the code, however
each place we use it needs to have a strategy for cancellation, which
the existing util functions don't allow for.
2019-05-16 21:19:25 -04:00
Quincy Morgan
97cb90b562 Make issue messages dynamic (close #6331) 2019-05-07 14:48:30 -04:00
Bryan Housel
d3a53309b7 Allow uppercase taginfo results for _ref tags
(closes #6324)
2019-05-07 09:32:13 -04:00
Quincy Morgan
375779882d Add ability to ignore warnings
Replace issue's array of entities with array of entity IDs
Improve issue ID hashing
2019-04-29 17:52:32 -07:00
Bryan Housel
fceb1a86f7 Merge pull request #6245 from openstreetmap/d3-v5
d3 v5
2019-04-29 15:46:08 -04:00
Bryan Housel
e981cd5dd5 Switch mapillary and openstreetcam tests to work async
- can't reliably use sinon.spy to tell whether a thing has been called,
  so we listen for events instead and check server.requests()
- make sure to request the next page before dispatching `loadedImages` so
  we can `server.respond()` to the request in the event handler if we want to
- also moves `localeDateString` in the openstreetcam service from parsing
  code to display code, because it's very slow (we can just do this for the
  images we look at, instead of all images we fetch)
2019-04-29 15:31:08 -04:00
Bryan Housel
b48a7d1e1b Workround for status errors thrown by d3-xml
Because the done callback is expecting something that has a `status` property,
(like an XHR would), we need to extract the status out of the error message.
d3-xml includes status in the error message, but we can't access the response itself.
2019-04-26 22:23:08 -04:00
Quincy Morgan
228af9a000 Move areaKeys and setAreaKeys to modules/osm/tags 2019-04-26 12:53:05 -07:00
Bryan Housel
b99be67169 When calling an errback from a Promise.catch, pass err.message 2019-04-25 21:58:36 -04:00
Quincy Morgan
d01bb78707 Reduce circular dependencies caused by importing from indexes, the location of the validation models, and the location of areaKeys (close #6237) 2019-04-24 13:45:59 -07:00
Bryan Housel
e6bc9d9e8f Swap out d3-request, swap in d3-fetch 2019-04-24 16:25:25 -04:00
Bryan Housel
51c1088c1b Merge branch 'master' into validation_and_change_perf 2019-04-19 15:18:23 -04:00
Quincy Morgan
72266af1e5 Show case-sensitive taginfo results for Manufacturer field 2019-04-16 09:59:00 -07:00
Bryan Housel
e30090996b Add loadTileAtLoc to fetch data tile for a specific location
(closes #4890)

This lets iD request needed tiles outside of the viewport, for example to
properly straighten lines or validate features that may have unloaded
connections.
2019-04-09 23:49:31 -04:00
Bryan Housel
2660a8554b Add isDataLoaded and tilecache rtree for testing
(re: #2248, #5938, maybe others)
2019-04-08 15:59:42 -04:00
Quincy Morgan
d5a2ca131d Fix issue with loading brand documentation (close #6134) 2019-04-02 07:21:30 -04:00
Bryan Housel
05f0e9f76f Remove lodash isMatch
(re: #6087)
2019-03-30 09:36:24 -04:00
Bryan Housel
cda8f657ac Swap fast-deep-equal for lodash isEqual
(re: #6087)
2019-03-29 22:17:29 -04:00
Bryan Housel
3673a7c7e7 Remove lodash cloneDeep
(re #6087)

- some were able to do a different approach
    (validations/almost_junction, and settings/*)
- some were replaced with custom speedy cloners
   (in orthogonalize clonePoints and osm.js cloneNoteCache)
- some just replaced with JSON.parse(JSON.stringify()))
2019-03-29 17:18:40 -04:00
Bryan Housel
ba6283af98 Fix point averaging code in improveOSM service
re: 4a8c20c56e (r32961438)
2019-03-29 09:06:27 -04:00
Bryan Housel
4a8c20c56e Remove lodash forEach
(re: 6087)
2019-03-28 19:50:20 -04:00
Quincy Morgan
5a0f8b3453 Autocomplete labels in the Wikidata field (close #5544) 2019-03-28 19:34:47 -04:00
Bryan Housel
3d80e6505f Remove lodash chunk, groupBy
(re: #6087)
2019-03-27 16:18:41 -04:00
Bryan Housel
0edd10001e Removing more lodash: isEmpty, isNumber, some map/reduce/forEach
(re: #6087)
2019-03-27 13:32:35 -04:00
Bryan Housel
5b4aa529de Replace lodash uniq
(re: 6087)
2019-03-27 02:43:25 -04:00
Bryan Housel
5e1ff74199 Replace lodash difference, intersects, union
(re: 6087)
2019-03-27 01:22:11 -04:00
Bryan Housel
4821bf0a68 Remove lodash omit
(re: #6087)
2019-03-26 14:12:45 -04:00
Bryan Housel
76e0d13729 Remove lodash every and filter
(re: #6087)
2019-03-23 01:22:56 -04:00
Bryan Housel
7a6c63fcc5 Remove lodash extend (re: #6087) 2019-03-23 00:38:39 -04:00
Bryan Housel
7e6f68a1b2 Remove lodash some
(re: #6087)
2019-03-23 00:07:52 -04:00
Bryan Housel
0e90167513 Remove lodash clone
(re: #6087)
2019-03-22 23:18:25 -04:00
Bryan Housel
ff4f8f005f Remove lodash find and findIndex
(re: #6087)
2019-03-22 17:31:41 -04:00
Bryan Housel
11bfeaabfc Add browser-polyfills, remove lodash assign, compact, values
(re: #6087)
2019-03-22 17:14:41 -04:00
Quincy Morgan
7d0080a642 Persist the photo overlay layers via the URL query string (re: #5813) 2019-03-14 16:48:08 -04:00
Quincy Morgan
c65a4d038e Add photo overlay filter options for hiding flat and pano photos (close #5433) 2019-03-14 14:24:21 -04:00
SilentSpike
5bd13dc590 Use https for ImproveOSM requests 2019-02-20 23:11:09 +00:00
Quincy Morgan
a928621681 Fix issue where mapillary sign colors were not shown 2019-02-20 11:09:57 -05:00
Quincy Morgan
db319e8ff5 Merge branch 'master' into validation 2019-02-11 07:59:29 -05:00
Bryan Housel
d055f34be8 Add sitelinks to result from wikidata getDocs 2019-02-09 15:18:32 -05:00
Bryan Housel
29ce6cb30c Use proper errbacks
(re: #5823)
2019-02-09 14:51:37 -05:00
SilentSpike
24022416cb Fix negative number of trips in ImproveOSM issues
See https://github.com/openstreetmap/iD/pull/5739#issuecomment-460786055
2019-02-09 16:31:37 +00:00
Bryan Housel
a2b140e92b Remove unnecessary ternary 2019-02-08 16:38:40 -05:00
Bryan Housel
fbe584c7ec Lookup docs for some presets on wikidata, not wikibase
(re: #5823)

Now `uiTagReference` can accept a `qid` param for presets where we want this
(such as brands)
2019-02-08 16:27:33 -05:00
Bryan Housel
2a7fec46fe Fetch somewhat higher resolution images
(100x100 was really too small)
2019-02-08 13:36:39 -05:00
Bryan Housel
32c42073c6 Add support for Relation type documentation lookups from wikibase
(closes #5860)
2019-02-08 13:24:58 -05:00
Quincy Morgan
ff6860693a Merge branch 'master' into validation 2019-02-08 13:21:46 -05:00