Quincy Morgan
43cd46f046
Prevent Chrome autofill of recent values in the Allowed Access inputs ( close #6414 )
2019-05-24 09:30:06 -04:00
Quincy Morgan
6260cdbb8f
Fix several lint warnings
2019-05-22 10:48:39 -04:00
Bryan Housel
69a25fd6aa
Move locking code from input and localized up to uiField
...
Also adjust styles some more for wikidata tagged items
2019-05-20 17:50:50 -04:00
Bryan Housel
06bdfbfb8a
Use gray stroke on marker and lock icon on field for locked item
2019-05-20 15:36:10 -04:00
Quincy Morgan
401c3a5005
Fix issue with the Label field by changing the class name of form-field-label ( close #6344 )
2019-05-13 10:36:21 -04:00
Bryan Housel
a3605f9b74
Comment out "anchor encoding" for wiki links
...
(closes #6232 )
2019-04-29 22:53:16 -04:00
Bryan Housel
fceb1a86f7
Merge pull request #6245 from openstreetmap/d3-v5
...
d3 v5
2019-04-29 15:46:08 -04:00
Bryan Housel
b99be67169
When calling an errback from a Promise.catch, pass err.message
2019-04-25 21:58:36 -04:00
Quincy Morgan
d01bb78707
Reduce circular dependencies caused by importing from indexes, the location of the validation models, and the location of areaKeys ( close #6237 )
2019-04-24 13:45:59 -07:00
Bryan Housel
a3bc164c43
Redraw entity editor fields on addition, deletion too
...
This is important to make the turn restriction editor work
2019-04-23 01:07:38 -04:00
Quincy Morgan
80a6e1806f
Don't remove wikidata tag when clearing the wikipedia field value ( close #4322 )
2019-04-15 13:39:30 -07:00
Quincy Morgan
cf6e6c7970
Always display the wikidata label and description in the user's language, if available
2019-04-01 13:04:33 -04:00
Quincy Morgan
2e7a47d0f2
Update the wikipedia tag when setting the wikidata tag via the field ( close #5543 )
2019-03-31 15:49:35 -04:00
Bryan Housel
3673a7c7e7
Remove lodash cloneDeep
...
(re #6087 )
- some were able to do a different approach
(validations/almost_junction, and settings/*)
- some were replaced with custom speedy cloners
(in orthogonalize clonePoints and osm.js cloneNoteCache)
- some just replaced with JSON.parse(JSON.stringify()))
2019-03-29 17:18:40 -04:00
Bryan Housel
d5abe468b9
Remove rest of the lodash iterators: map, reduce, forEach
...
(re: #6087 )
2019-03-29 15:14:21 -04:00
Quincy Morgan
5a0f8b3453
Autocomplete labels in the Wikidata field ( close #5544 )
2019-03-28 19:34:47 -04:00
Bryan Housel
3896b2282f
Remove lodash isNaN, isNumber, isString, bind, uniqBy
...
(re: 6087)
2019-03-27 23:11:45 -04:00
Quincy Morgan
748c9c9598
Filter out deprecated tag values from combobox suggestions ( close #6084 )
2019-03-27 17:15:10 -04:00
Bryan Housel
5b4aa529de
Replace lodash uniq
...
(re: 6087)
2019-03-27 02:43:25 -04:00
Bryan Housel
5e1ff74199
Replace lodash difference, intersects, union
...
(re: 6087)
2019-03-27 01:22:11 -04:00
Bryan Housel
33a40f59eb
Remove lodash includes and reduce from address.js
...
(re #6087 )
2019-03-26 12:20:58 -04:00
Bryan Housel
eb0d0a35d1
Remove lodash pull
...
(re: #6087 )
2019-03-25 22:03:39 -04:00
Bryan Housel
963a4127db
Remove lodash remove
...
(re: #6087 )
2019-03-24 01:50:32 -04:00
Bryan Housel
5280d07bad
Remove lodash reject (re: #6087 )
2019-03-23 12:51:13 -04:00
Bryan Housel
76e0d13729
Remove lodash every and filter
...
(re: #6087 )
2019-03-23 01:22:56 -04:00
Bryan Housel
7e6f68a1b2
Remove lodash some
...
(re: #6087 )
2019-03-23 00:07:52 -04:00
Bryan Housel
0e90167513
Remove lodash clone
...
(re: #6087 )
2019-03-22 23:18:25 -04:00
Bryan Housel
ff4f8f005f
Remove lodash find and findIndex
...
(re: #6087 )
2019-03-22 17:31:41 -04:00
Bryan Housel
166a50028b
Handle commas and semicolons typed into semi/multicombo values
...
(closes #6013 )
2019-03-05 14:51:29 -05:00
Bryan Housel
6525bbf154
Exclude current entity's value from address nearby values lookup
...
re: https://github.com/openstreetmap/iD/issues/5887#issuecomment-463385328
2019-02-14 00:27:32 -05:00
Bryan Housel
9e2acd836c
Use case sensitive combos in address fields
...
(closes #5887 )
This allows users to correct mistyped address parts
2019-02-14 00:20:38 -05:00
Bryan Housel
26368522c9
Batch changes from raw tag editor so blur/remove tag don't conflict
...
(closes #5878 )
2019-02-10 22:08:13 -05:00
Bryan Housel
29ce6cb30c
Use proper errbacks
...
(re: #5823 )
2019-02-09 14:51:37 -05:00
Andreas Haessler
82ea58d943
Add default value to number field
2019-02-04 15:59:08 +01:00
Bryan Housel
d0021f77ca
Handle possibility of combobox blurring without dispatching accept
2019-01-28 13:43:40 -05:00
Bryan Housel
18d71448be
pacify eslint
2019-01-25 16:23:46 -05:00
Bryan Housel
5d6e331635
Don't erase name field when tabbing from it
...
(closes #5760 )
2019-01-25 16:16:07 -05:00
Quincy Morgan
decba8f215
Fix cycleway field to appear if "cycleway" tag present but not "cycleway:left" nor "cycleway:right" ( close #5756 )
2019-01-25 08:39:15 -05:00
Bryan Housel
20bcfc5730
Delimit name-suggestion-preset names on en-dash, not hyphen
...
To avoid conflicts with hyphenated names, or bilingual names
with hyphens in them (like used in Brussels)
2019-01-23 09:44:24 -05:00
Bryan Housel
4583e2d4d7
Make sure all combo event listeners can handle accept/cancel w/o datum
...
(re: #5637 , re: #5618 )
This can happen if the user enters a value that is not matched to
one of the combo suggestions.
Also make sure to set `this` to the input field. It might not be
already if the event was triggered from a keypress instead of a click.
2019-01-22 23:14:34 -05:00
Quincy Morgan
46beb31e74
Removed extra padding in comboboxes when the caret is hidden
2019-01-18 11:59:40 -05:00
Quincy Morgan
bf2574f4e3
Hide the dropdown arrow in combo fields if there are no suggestions from tagInfo ( closes #5730 )
2019-01-18 11:21:31 -05:00
Quincy Morgan
bc81a62a58
Made the value chips in the Destinations semiCombo field full-width to mimic the layout of highway signs (re: #4178 )
...
The input and combobox caret elements in the multicombo field value list are now wrapped in a li element for consistency
2019-01-18 10:41:51 -05:00
Quincy Morgan
77cfde7913
combo, multiCombo, and semiCombo fields now correctly submit the typed value upon pressing enter/return without deselecting the feature ( closes #5725 )
2019-01-17 15:42:35 -05:00
Quincy Morgan
90637bdcfa
Fixed an issue where the cycleway field would throw an error when added from the "Add field:" dropdown
2019-01-17 12:32:14 -05:00
Bryan Housel
c635389c1a
Fix handling of semicolon delimited values in numeric field
...
(closes #5438 )
2018-12-12 01:11:34 -05:00
Bryan Housel
39b3f1df68
Avoid creating comboboxes
...
(closes #5568 )
Several strategies in here:
- Move uiCombobox() from inside the render function to class variable
- Don't render stuff like the raw tag editor when it's collapsed
- Don't show as many fields/combos on hover
- Don't instantiate fields (like universal/more) until they're actually shown
- Bind the combo on enter selection not on update selection
2018-12-11 16:07:00 -05:00
Bryan Housel
ff646fa2c8
Dispatch a 'cancel' event if the user hits escape
2018-12-11 00:09:55 -05:00
Bryan Housel
15a54cab17
Use context.container instead of passing it in
2018-12-10 14:14:27 -05:00
Bryan Housel
e5dedeff8b
Move lib/d3.combobox.js -> ui/combobox.js
...
As with other things from this lib/ folder, little original code remains
and turning these things into reusable d3 plugins is not a priority.
2018-12-10 12:38:21 -05:00