Commit Graph

31 Commits

Author SHA1 Message Date
Bryan Housel
08d4c3268e pacify eslint 2019-02-14 17:26:57 -05:00
Quincy Morgan
1821c3e955 Update fixes UI for icons, link styling, and non-actionable fixes
Fix several bugs
2019-02-14 15:56:04 -05:00
Bryan Housel
5bca360f50 Don't show the entity_issues section if there are no issues
(I think it worked this way before)
2019-02-13 13:57:46 -05:00
Bryan Housel
c292a32a66 Better message padding, remove double tooltip 2019-02-13 13:47:00 -05:00
Bryan Housel
448fe498bd Only recenter view if necessary, select after delay, fix maprules type 2019-02-12 17:25:54 -05:00
Bryan Housel
9ebc9a22e9 perf: use Object instead of Array for lookup, cache on osmEntity.key 2019-02-12 14:23:50 -05:00
Bryan Housel
4e6ade08b1 Comment out cache in getIssuesForEntityWithID
It seems like entity editor draws before the validator runs so the
rendered list is often one history change behind.
2019-02-12 00:22:24 -05:00
Bryan Housel
6cb1656cac Animate expand fix menus 2019-02-12 00:00:12 -05:00
Bryan Housel
81bd734849 WIP uiEntityIssues cleanups, simplify
fixes are still not being applied properly
2019-02-11 20:44:02 -05:00
Bryan Housel
a5ffec5665 utilHighlightEntities accept an array instead of calling it in a loop 2019-02-11 12:40:23 -05:00
Quincy Morgan
0826050b55 Only zoom to the clicked issue in the entity sidebar if it isn't visible 2019-02-11 12:10:57 -05:00
Quincy Morgan
99e1203d46 Zoom to entity when opening an issue without a specific location in the entity editor 2019-02-11 11:48:21 -05:00
Quincy Morgan
47ec58e5fc Don't zoom to the end vertex when continuing a disconnected highway if it is already visible
Add separate fixes for continuing a disconnected highway from the start and end vertices
Highlight the vertex that will be continued
2019-02-11 11:29:34 -05:00
Quincy Morgan
01b0c618d1 Don't highlight the selected entity when hovering over issues in the entity editor 2019-02-11 10:58:47 -05:00
Quincy Morgan
83f8cd97f6 Add feature highlighting when hovering over their corresponding issues 2019-02-11 09:45:33 -05:00
Quincy Morgan
0aa3ce2cee Fix issue with Issues section appearance if the sidebar was loaded with the section closed 2019-02-05 16:57:34 -05:00
Quincy Morgan
ca8c91563b Add issue count to section title in entity editor
Remove redundant string
2019-02-04 16:48:54 -05:00
Quincy Morgan
6514f645d1 Add error and warning count to the list titles
Hide error and warnings lists when there are no errors or warnings
2019-02-04 09:28:01 -05:00
Quincy Morgan
251d83f86c Show warnings and errors in different lists in the issues pane 2019-02-01 16:38:48 -05:00
Quincy Morgan
46f3cea33a Reorganize validation code
Rename IssueManager to coreValidator
Rename disconnected highway to disconnected way
Rename highway almost junction to almost junction
Rename mapcss checks to maprules
Rename deprecated tags to deprecated tag
2019-02-01 11:20:51 -05:00
Quincy Morgan
907c4d9616 Rename fix function from action to onClick 2019-01-29 12:18:02 -05:00
Quincy Morgan
b48445b29a Make the first issue's fix list appear by default 2019-01-29 09:56:44 -05:00
Quincy Morgan
33ae009936 Clarify wording of old_multipolygon issue and tooltip
Add quick fix for old_multipolygon issue
2019-01-24 11:01:41 -05:00
Quincy Morgan
7b288ef95d Add basic zoom-to-clicked-issue behavior 2019-01-23 15:25:55 -05:00
Quincy Morgan
4f1cb0dc46 Made the entity issues UI update when the issues reload 2019-01-14 12:33:32 -05:00
Quincy Morgan
dc3a42f33d Fixed validation-related linting errors 2018-12-21 14:08:35 -05:00
Quincy Morgan
627b4ee732 Fixed an bug where the wrong feature could be deleted from the untagged feature issue fix 2018-12-21 14:00:08 -05:00
Quincy Morgan
c9350c632e Add issue fixes UI
Add two issue fixes for untagged feature
2018-12-21 12:31:33 -05:00
Quincy Morgan
026597017a Update styling in the entity issues list 2018-12-20 14:49:35 -05:00
Quincy Morgan
2207a6c3a4 Added severity tooltip to issue icon 2018-12-19 18:35:17 -05:00
Quincy Morgan
490143d1a8 Added Issues section to the entity sidebar
Fixed bug where stale issues would stick around in the issues pane
2018-12-19 16:12:33 -05:00