Commit Graph

16 Commits

Author SHA1 Message Date
Quincy Morgan
1821c3e955 Update fixes UI for icons, link styling, and non-actionable fixes
Fix several bugs
2019-02-14 15:56:04 -05:00
Bryan Housel
14896b0ce5 Documentation, and move validation type up to top of each file 2019-02-12 16:07:08 -05:00
Bryan Housel
251a83ff7a Nitpicky code formatting stuff
- no multiline var declaration
- squish together and alphabatize imports
- linebreaks for readability
2019-02-11 13:55:58 -05:00
Bryan Housel
a6e05b8ac5 Rename for consistency - these are called "annotations" elsewhere 2019-02-11 13:36:02 -05:00
Quincy Morgan
d3946894e8 Standardize deprecated_tag and missing_tag rule type ids
Run crossing_ways before disconnected_way
Break out crossing_ways issue creation into a separate function
2019-02-04 16:29:29 -05:00
Quincy Morgan
973697b8ba Run all validators in the validations folder if not manually run
Remove ValidationIssueType and ValidationIssueSeverity objects
2019-02-01 13:38:17 -05:00
Quincy Morgan
46f3cea33a Reorganize validation code
Rename IssueManager to coreValidator
Rename disconnected highway to disconnected way
Rename highway almost junction to almost junction
Rename mapcss checks to maprules
Rename deprecated tags to deprecated tag
2019-02-01 11:20:51 -05:00
Quincy Morgan
957eb28242 Don't run other validators if feature is missing tags
Don't run disconnected highway check if there is an almost junction issue already
Only run way validators on ways
2019-01-30 17:59:23 -05:00
Quincy Morgan
6aea578f92 Make validation functions take a single entity rather than an array of them
Pass context into validation functions directly rather than initializer
Don't initiate validation functions for every pass
2019-01-30 16:39:37 -05:00
Quincy Morgan
907c4d9616 Rename fix function from action to onClick 2019-01-29 12:18:02 -05:00
Quincy Morgan
2051dc4ca8 Update id of remove generic name fix 2019-01-29 10:45:48 -05:00
Quincy Morgan
3886ce2ba8 Update issue tooltips and messages 2019-01-25 12:49:02 -05:00
Quincy Morgan
ffe4aa09f4 Pass entity array into validators instead of changes object 2019-01-24 15:26:19 -05:00
Quincy Morgan
981ed9ef8c Integrate the generic_name validation into the new validations framework 2019-01-24 09:28:59 -05:00
Bryan Housel
6c5ea96ab6 Adjust generic name validation to better check tag values
e.g. "name=Fast Food" should match "amenity=fast_food"
2019-01-08 13:43:40 -05:00
Bryan Housel
5f20218f1f Add validation warning for generic names
(closes #5590)
2019-01-08 02:15:28 -05:00