Max Grossman
b9ddfca152
implement point/puck geolocation
...
ref #5587
2018-12-19 11:06:41 -05:00
Quincy Morgan
ff95e6a337
Merge branch 'validationIssueDataModel' into validation
2018-12-19 10:59:45 -05:00
Quincy Morgan
903cb63efe
Renamed validations to issues in relevant places
...
Made the issue pane get the issues from the issue manager rather than validating itself
2018-12-19 10:41:58 -05:00
Xiaoming Gao
07a53fe6ea
Extend data model for validation issues
...
Add the Issues pane
1. Add a class to represent the validation issue
2. Extend the data model for an validation issue to
(1) add a severity level field (useful for identify save-blocking issues later)
(2) replace single entity with an array of entities (useful for issues involving multiple entities)
(3) add a coordinates field for highlighting the location of the issue on the map
(4) add a fixes field for possible automatic fixes
3. Update existing validation modules to use the new data model
2018-12-19 10:37:32 -05:00
Quincy Morgan
0d0521c936
Moved feature applicability into the issue manager class
2018-12-19 10:32:14 -05:00
Quincy Morgan
161311faa5
Merge pull request #5626 from wonga00/wonga_issue_manager
...
added IssueManager
2018-12-18 18:05:40 -05:00
Quincy Morgan
858a9606d5
Added entity display name or preset name to the disconnected highway message
2018-12-18 18:05:27 -05:00
Andrew Wong
30f25c6e8d
added IssueManager
...
- IssueManager performs validation on the current graph and also
stores the issues and notifies listeners when the issues changed
2018-12-18 17:52:23 -05:00
Quincy Morgan
c1240af464
Added options UI in the Issues pane with edited vs all features selection
...
Added basic issues list in the Issues pane
2018-12-18 17:04:40 -05:00
Quincy Morgan
982f226d07
Merge branch 'master' into validation
2018-12-18 15:56:15 -05:00
Quincy Morgan
6e1dd34447
Fixed an issue where a new container would be added in the Map Data pane every time a section was re-expanded
2018-12-18 15:55:50 -05:00
Bryan Housel
5a2049b421
Drop extra whitespace, make sure service exists before using it
2018-12-18 15:38:53 -05:00
Quincy Morgan
e87a7e1125
Merge branch 'master' into validation
2018-12-18 15:35:55 -05:00
Bryan Housel
814c72fe42
Merge branch 'remote-presets' of https://github.com/radiant-maxar/iD into radiant-maxar-remote-presets
2018-12-18 15:15:11 -05:00
Max Grossman
b7f0d86da9
working on geolocate layer
...
ref #5587
2018-12-18 14:19:36 -05:00
Max Grossman
1471b55122
lint!
...
ref #5614
2018-12-18 12:02:26 -05:00
Max Grossman
02261c96e0
adding svg layer...
...
ref #5587
2018-12-18 12:01:22 -05:00
Max Grossman
ae9d43b0ac
remove double class
...
ref #5614
2018-12-18 11:16:37 -05:00
Quincy Morgan
cf0214d06a
Add the Issues pane
2018-12-18 11:11:15 -05:00
Max Grossman
18c021b5d5
add css
...
ref #5614
2018-12-18 11:09:26 -05:00
Max Grossman
0328e4f9da
add close button w/out css
...
ref #5614
2018-12-18 11:00:40 -05:00
Max Grossman
6ba8bacb75
use severity in test
2018-12-18 10:27:15 -05:00
Quincy Morgan
7e9082b9ff
Merge branch 'master' into field-prerequisite-tags
2018-12-18 09:33:46 -05:00
Max Grossman
64f2d913e8
remove unused entities from test
2018-12-17 17:39:47 -05:00
Max Grossman
8f33a85a12
make collection.index function to handle failing tests
2018-12-17 17:16:10 -05:00
Max Grossman
d8de9e785e
do not add found presets to recent
2018-12-17 14:56:33 -05:00
Max Grossman
74a19a6d7f
remove a comment
2018-12-17 12:55:00 -05:00
Max Grossman
e0e6f5b918
remove non-used util class
2018-12-17 12:52:21 -05:00
RudyTheDev
743be30a76
Use water fill pattern for fountain area
2018-12-15 16:33:06 +02:00
RudyTheDev
89a128f14c
Allow directly specified fill pattern for entire tag (not using for anything as of yet)
2018-12-15 15:58:39 +02:00
RudyTheDev
b92592b6b4
Add fill pattern for reservoir
2018-12-15 15:32:48 +02:00
Bryan Housel
43cea82d6f
Make sure when selecting to restore the sidebar to select mode
...
(closes #5603 )
2018-12-14 17:31:10 -05:00
Max Grossman
d87b1822f7
add/make visible weakly matched presets
2018-12-14 15:42:25 -05:00
Max Grossman
f627f1e659
make all presets visible on init!!
2018-12-14 13:29:17 -05:00
Max Grossman
1b51b8bc57
adding tests and updating/fixing external presets logic
2018-12-14 13:23:58 -05:00
Bryan Housel
e5aa8a7058
Simplify setPattern
2018-12-14 12:57:28 -05:00
Quincy Morgan
a61cdc8208
Removed unused function
2018-12-13 17:29:59 -08:00
Quincy Morgan
a4b2924e4e
Merge branch 'master' into field-prerequisite-tags
2018-12-13 17:23:54 -08:00
Max Grossman
c897331cd1
presets test w/build
2018-12-13 13:30:38 -05:00
Max Grossman
96e44be69c
merge 2.12.2
2018-12-13 11:22:32 -05:00
Max Grossman
f3e6459191
working on preset visibility
2018-12-13 11:16:24 -05:00
Bryan Housel
eb14a9ed53
v2.12.2
2018-12-13 10:28:31 -05:00
Bryan Housel
cd74e4e063
Fix broken member role dropdown for members that are not downloaded
...
(closes #5592 )
2018-12-12 16:53:20 -05:00
Bryan Housel
f45e97d727
Variable cleanups
2018-12-12 16:13:32 -05:00
Bryan Housel
d28b269b4c
Speed up the scrolling on Firefox Linux too
...
(re: #5512 )
This just changes
`detected.os === 'win'` to `detected.os !== 'mac'`
2018-12-12 15:45:55 -05:00
Bryan Housel
17615da0ea
Listen to both change and blur for role switcher, compare old v new
...
(closes #5449 )
2018-12-12 15:27:14 -05:00
Bryan Housel
e08bfb2add
Simplify accept/cancel event dispatchers, store datum in _choice
2018-12-12 15:26:18 -05:00
Bryan Housel
84f96574d7
Add index property to cloned object, not actual member object
...
(closes #5458 )
This code was adding an `index` property to each member in the relation.
Although the `index` property is ignored by the code that saves to OSM,
the extra property would make the member changed when compared by
`coreDifference`.
2018-12-12 02:07:03 -05:00
Bryan Housel
c635389c1a
Fix handling of semicolon delimited values in numeric field
...
(closes #5438 )
2018-12-12 01:11:34 -05:00
Bryan Housel
fc1f7e4d46
Trigger a change event when accepting combo option with return, tab
...
(closes #4900 , closes #5449 )
Some browsers need an explicit `change` event triggered on the input field
when a value has been changed by the combo and accepted by pressing return
or tab. This was only an issue on combos that aren't part of uiFields,
since the uiFields are all setup to respond to `change`,`input`,`blur` etc.
2018-12-11 23:25:47 -05:00