Commit Graph

147 Commits

Author SHA1 Message Date
John Firebaugh
2e4207f99b Cache geometry 2013-05-17 15:31:27 -07:00
John Firebaugh
d238e4eaeb Convert Tail to a behavior
This avoids an extra mousemove listener in base modes.
2013-05-14 17:51:24 -07:00
John Firebaugh
271ddace64 Revert "prevent accidental drags"
Not sure this helps a whole lot, and it requires a mousemove listener.

This reverts commit b7760e8747.
2013-05-14 09:33:27 -07:00
John Firebaugh
1a6a9b5b9e Better way of doing hover suppression 2013-05-13 12:53:03 -07:00
John Firebaugh
fcafce7517 Really fix area drawing 2013-05-13 12:19:51 -07:00
John Firebaugh
a7bc5d367b Fix area drawing 2013-05-13 10:29:31 -07:00
John Firebaugh
578224bd63 Optimize hover behavior
Add entity IDs to the element class list, so that specific
elements can be selected by ID rather than needing `filter`.
2013-05-12 09:40:34 -07:00
John Firebaugh
1641f38632 Use context.mouse() 2013-05-09 21:55:05 -07:00
John Firebaugh
08949d2fe9 Redo iD.geo.chooseIndex
It now calculates proper orthogonal projections and finds
the minimal one. Rename it iD.geo.chooseEdge and minimize
its coupling to context.

This version also copes with 0- and 1-node ways.

Fixes #1428.
2013-05-07 18:35:45 -07:00
John Firebaugh
24ecf2a697 Don't show radial menu after dragging node (fixes #1385) 2013-04-26 11:45:01 -07:00
Ansis Brammanis
a147496cc7 No dangler prevention for areas
They don't need it -- they already can't be self-intersected.
2013-04-26 13:14:07 -04:00
Ansis Brammanis
6c6a312c62 fix dangler avoidance for areas 2013-04-25 19:25:43 -04:00
Ansis Brammanis
b95529d5ec prevent way danglers, issue #1373 2013-04-25 11:48:03 -04:00
John Firebaugh
c50c3121d8 Make Graph#entity strict
Use Graph#hasEntity for the previous behavior.
2013-04-24 09:27:37 -07:00
John Firebaugh
2d62a78ac9 Semicolons 2013-04-23 14:31:24 -07:00
John Firebaugh
c8dcba31ad Auto-zoom to entity specified by id param 2013-04-18 14:24:10 -07:00
Ansis Brammanis
63f2df89b3 Fix drawing areas
the way that the vertex is being added to is the original one,
not the one with the 'end' node, so there is no need to remove it.

The new node de-dupe code was making this break area drawing.

Fixes #1322
2013-04-16 22:25:48 -04:00
John Firebaugh
5dda54ea52 Refine focus behavior for inspector (fixes #1277)
Auto-focus the search field only right after finishing drawing.
At that point, the radial menu isn't shown anyway. So then the
flow for correcting geometry before assigning a preset is:

 1. Draw.
 2. Finish drawing. The search field is focused, and no
    radial menu is open.
 3. Click again to reselect the feature and show menu.
    Now the search field is blurred.

In other words: when the menu is shown, search should not be
focused. When search is focused, the menu should not be shown.
2013-04-12 10:08:44 -04:00
Ansis Brammanis
a8f41b8c57 Prevent creation of ways with duplicate nodes
Related to #1249
2013-04-05 16:35:51 -04:00
Ansis Brammanis
d7cc24b935 shadows for multipolygons 2013-04-05 12:11:23 -04:00
Ansis Brammanis
acdc1b3824 add nodes to all of a segment's ways
when
- dragging a node to a way
- starting a line from a way
- starting an area from a way
- drawing a way
2013-04-04 17:58:53 -04:00
Ansis Brammanis
7e85fed027 add .id-container class to container
fixes #1228
2013-04-02 14:03:46 -04:00
Ansis Brammanis
3e75943405 block quick second click when drawing
- doubleclicking to add point doesn't zoom
- doubleclicking on last node selects way, not node

fixes #1233
2013-04-02 13:21:32 -04:00
Tom MacWright
52dd7bf869 Merge pull request #1079 from systemed/prevent-drag
prevent accidental drags
2013-03-29 11:16:34 -07:00
John Firebaugh
f7fb12be76 Fix #1120, inconsistent undo for line/area drawing
Gulp!
2013-03-27 16:25:10 -07:00
Ansis Brammanis
dcf2c1e7f4 lasso works if shift is released before mouseup
fixes #1156
2013-03-26 18:20:48 -04:00
Ansis Brammanis
b7760e8747 prevent accidental drags 2013-03-18 20:56:29 -04:00
Ansis Brammanis
63edc30922 Revert "Use a temporary area tag for drawing. Fixes #1014"
This reverts commit 4184b503f9.
2013-03-18 14:02:21 -04:00
Tom MacWright
4184b503f9 Use a temporary area tag for drawing. Fixes #1014 2013-03-15 18:27:06 -04:00
Tom MacWright
b21f863312 The one true coordinate order. Fixes #1025 2013-03-13 17:48:40 -04:00
John Firebaugh
9f5ba8342d Convert DragNode to a mode
This makes the CSS more consistent and makes fixing #953
easier. Also, dragging now clears the selection and closes
any operations menu, which is good.

There's still a minor Chrome bug: it doesn't refresh the
cursor when the .behavior-hover class is removed.
2013-03-11 15:45:27 -07:00
Ansis Brammanis
6129fbf4f5 prevent creation of ways with duplicate segments or repeated nodes 2013-03-11 16:00:24 -04:00
John Firebaugh
ab561ff198 Better way to prevent snapping to area fill
This also prevents are hover behavior during node dragging,
while allowing snapping to vertex fill.
2013-03-11 12:29:00 -07:00
John Firebaugh
27861ca6b2 Implement multiselect cursors (fixes #296) 2013-03-07 11:57:43 -08:00
John Firebaugh
a6ce12efb6 Add shadow on area strokes (fixes #674) 2013-03-07 10:33:11 -08:00
John Firebaugh
417e21ab05 Remove unused 2013-03-05 16:02:27 -08:00
Ansis Brammanis
c74615fa83 Only re-enable dblclick after done drawing way 2013-03-05 16:54:33 -05:00
Tom MacWright
e071c15579 Remove unused variables and arguments 2013-03-05 16:29:23 -05:00
Tom MacWright
d8e7936d8a Fix CORS error catching on save. Fixes #788. Fixes #451 2013-03-05 14:44:27 -05:00
Ansis Brammanis
d351f74a94 Undos during drag now redoable 2013-02-27 14:57:07 -05:00
Ansis Brammanis
00dfa8cd08 Fix shift-click to select 2013-02-22 14:59:32 -05:00
Ansis Brammanis
3bdae821c0 Select areas and lines after finishing them 2013-02-21 13:37:10 -05:00
John Firebaugh
88949d6624 Fix altKey behavior with multi-step drawing (fixes #803) 2013-02-18 21:14:41 -08:00
Ansis Brammanis
6a1ef84546 Usecapture when blocking click 2013-02-15 15:45:24 -05:00
Ansis Brammanis
147fce1f49 Merge branch 'tree-intersects'
Conflicts:
	js/id/behavior/lasso.js
2013-02-15 13:40:01 -05:00
John Firebaugh
d7d3f174ae Lasso only nodes for now (fixes #734)
Given the (lack of) operations available on mixed node/way
selections, this seems just as good as selecting contained
ways as well.
2013-02-13 16:53:40 -08:00
John Firebaugh
c0b8cd74de Reopen radial menu when clicking on selected entity (fixes #758) 2013-02-13 16:23:58 -08:00
Ansis Brammanis
7102fea04d add history.intersects to context 2013-02-13 18:12:53 -05:00
Ansis Brammanis
fd423f4db7 Don't drag when shiftKey 2013-02-13 15:39:22 -05:00
John Firebaugh
65fbc808a1 Map#pan redraws 2013-02-13 10:39:48 -08:00