Commit Graph

2424 Commits

Author SHA1 Message Date
Quincy Morgan
bfeb374510 Don't allow favoriting fallback presets 2019-02-27 14:31:23 -05:00
Quincy Morgan
dd74a18206 Tweak favorite mode spacing
Don't show area midpoint dots on small preset icons
2019-02-27 14:27:03 -05:00
Quincy Morgan
04247eb985 Merge branch 'master' into squash-favorite-preset 2019-02-27 14:08:55 -05:00
Quincy Morgan
d613714137 Draw area preset icon frame parametrically in code rather than with external SVG resource 2019-02-27 14:06:35 -05:00
Quincy Morgan
b302d853ac Fix issue where the favorite preset button could be stale
Use first in, first out favoriting order
2019-02-27 13:13:15 -05:00
Quincy Morgan
0fe4513e2a Tweak CSS class 2019-02-27 12:30:38 -05:00
Quincy Morgan
1058a2cb27 Fix instances where adding favorite preset would not add tags 2019-02-27 12:27:54 -05:00
Quincy Morgan
2da011c3ca Remove unused string
Don't show preset browser when adding a favorite point
Don't automatically open the sidebar when selecting a non-new feature
2019-02-27 12:20:23 -05:00
Quincy Morgan
4fabb4aac8 Nicen favorite preset mode button tooltips 2019-02-27 12:03:10 -05:00
Quincy Morgan
af5012107f Fix crash when drawing a favorite highway 2019-02-27 11:44:47 -05:00
Quincy Morgan
1c1c3b2823 Disallow favoriting vertices and relations 2019-02-27 11:34:47 -05:00
Quincy Morgan
0a0e4890ca Nicer favorite preset icon rendering in the top bar 2019-02-27 11:28:24 -05:00
Quincy Morgan
8f4f929401 Merge branch 'master' into squash-favorite-preset 2019-02-27 10:51:59 -05:00
Quincy Morgan
b409f260f7 Render preset icons fills as SVG rather than HTML elements 2019-02-27 10:51:24 -05:00
Quincy Morgan
5faa999071 Use preset icon for favorite buttons 2019-02-26 18:00:33 -05:00
Quincy Morgan
ad66e00354 Merge branch 'master' into squash-favorite-preset 2019-02-26 17:28:58 -05:00
Quincy Morgan
9a5101dbcb Convert preset icon to use percentages for size and position rather than explicit pixel values 2019-02-26 17:21:11 -05:00
Quincy Morgan
dead97e321 Reduce parameters for add modes
Tweak CSS classes
2019-02-26 15:17:04 -05:00
Quincy Morgan
a3424aa4b1 Merge branch 'master' into squash-favorite-preset 2019-02-26 14:25:34 -05:00
Quincy Morgan
0fa7e757b1 v2.14.3 2019-02-26 13:45:53 -05:00
Quincy Morgan
1f21b029fd Move tag upgrade fix to an action and add unit tests 2019-02-26 10:42:12 -05:00
Quincy Morgan
5262358d81 Fix an issue where added nodes would highlight momentarily while drawing an area 2019-02-26 09:34:45 -05:00
Quincy Morgan
a4e0bcb29c Make misplaced multipolygon tags check more consistent 2019-02-26 08:53:00 -05:00
Quincy Morgan
7d8453b1fb Remove service road exception for adding highway=crossing during crossing way fix (re: #5976) 2019-02-26 08:12:42 -05:00
Quincy Morgan
87e48bc543 Run missing role validation before missing tag 2019-02-25 18:01:34 -05:00
Quincy Morgan
6aa1f86dfb Add warning for multipolygon members with no set role (close #5851) 2019-02-25 17:46:50 -05:00
Quincy Morgan
b8ac9a7de3 Add toggle-able list of rules to the Issues pane (close #5979)
Toggling a rule off prevents the validation from running
2019-02-25 15:31:05 -05:00
Quincy Morgan
66301864c1 Fix false positive of tags suggesting area on features where other tags define the preset (close #5945, re: #5933) 2019-02-25 13:10:55 -05:00
Quincy Morgan
12b1af7002 Don't say tags imply area for tags that iD doesn't have a preset for (close #5933) 2019-02-25 12:42:39 -05:00
Quincy Morgan
0e71ae7032 Fix lint warning 2019-02-25 11:40:26 -05:00
Quincy Morgan
7f58454958 Don't tag connection nodes of paths crossing service or track roads as highway=crossing in crossing ways quick fix (re: #5976) 2019-02-25 11:39:03 -05:00
Quincy Morgan
07fe7a1107 Fix an issue where pressing enter in the preset search bar wouldn't select the first preset (close #5921) 2019-02-25 10:42:10 -05:00
Quincy Morgan
2d974caed1 Fix an issue where preset buttons would always be disabled if Other Features were hidden (close #5934) 2019-02-25 10:27:06 -05:00
Quincy Morgan
ced652806b Fix an issue where some tagged nodes or existing vertices could not be snapped to (close #5942) 2019-02-25 08:54:30 -05:00
J Guthrie
249046614c Add exception to isInvalidGeometry algorithm
- An area with just 1 placed node (2 nodes including active, to-be-placed node,
    returns as valid and is picked up by later way.isDegenerate() check
2019-02-24 13:58:16 +00:00
Quincy Morgan
70e88ee9af v2.14.2 2019-02-21 17:01:00 -05:00
Quincy Morgan
ee6c06d1d5 Fix an issue where the commit sidebar would not show all warning and errors
Remove use of lodash from commit_warnings.js
2019-02-21 15:33:14 -05:00
Quincy Morgan
10e73fc15c Explicitly include certain railways for crossing validation instead of excluding some
Don't flag abandoned or razed railway crossings
2019-02-21 15:09:13 -05:00
Quincy Morgan
02d3097d8d Fix a cacheing issue 2019-02-21 13:34:51 -05:00
Quincy Morgan
7936266a7a Improve validation performance by avoiding uniqueWith lodash function
Replace map lodash function with JavaScript array map in validator.js
2019-02-21 12:13:27 -05:00
Quincy Morgan
51972ea78f Cache issues in crossing ways validation to avoid checking the same pairs twice 2019-02-21 11:49:31 -05:00
Quincy Morgan
aa992ed981 Improve validation performance by cacheing the issue id 2019-02-21 10:47:57 -05:00
Quincy Morgan
2d6c49b92b Ignore proposed features for crossings ways, almost junction, and disconnected way validations (close #5922) 2019-02-21 10:14:25 -05:00
Quincy Morgan
7da37384f1 Fix an issue where stale missing tag errors could persist when canceling drawing a new way (close #5918)
Don't show missing tags error for a feature that is still being drawn (re: #5898)
2019-02-21 09:48:46 -05:00
Quincy Morgan
be71554f61 Fix a bug where all data would disappear when switching modes while drawing a way (close #5917) 2019-02-21 09:22:03 -05:00
Quincy Morgan
1bde3ba63f v2.14.1 2019-02-20 18:23:47 -05:00
SilentSpike
5bd13dc590 Use https for ImproveOSM requests 2019-02-20 23:11:09 +00:00
Quincy Morgan
1f1e88314d v2.14.0 2019-02-20 16:19:36 -05:00
Brian Hatchl
d8531c88bb fix lint complaints 2019-02-20 15:44:16 -05:00
Brian Hatchl
1faa6ad839 Favorite preset 2019-02-20 15:23:58 -05:00