Commit Graph

9883 Commits

Author SHA1 Message Date
Quincy Morgan d58867df7c Add entity display label util function
Condense message and tooltip text for for the untagged feature issue
Use lighter border color for error issues
2018-12-20 14:04:15 -05:00
Quincy Morgan 373be68294 Merge branch 'master' into validation 2018-12-20 13:58:09 -05:00
Quincy Morgan 7c192a2e36 Fixed bug where the entity ID could not be found for the field 2018-12-20 12:25:35 -05:00
Quincy Morgan d7ef2de073 Re-organizes issue messages and tooltips 2018-12-20 12:16:54 -05:00
Quincy Morgan 7416fc7ac3 Fixed typo in crossing ways issue label 2018-12-20 10:40:48 -05:00
Quincy Morgan f0fa59874f Merge branch 'master' into validation 2018-12-20 10:31:25 -05:00
Quincy Morgan 97c2361f43 Changed initial sidebar screen for highway intersection vertices from preset list to editor 2018-12-20 10:17:16 -05:00
Bryan Housel 62547e3459 Merge pull request #5638 from openstreetmap/5612
remove highlight from relation member after it is deleted from relation
2018-12-20 10:10:46 -05:00
Bryan Housel e2c0f5edcd Merge pull request #5636 from openstreetmap/5596
open combobox if anywhere on box clicked...
2018-12-20 10:09:24 -05:00
Max Grossman 9a5a77f96c remove unneccessary space
ref #5612
2018-12-20 09:24:46 -05:00
Max Grossman 18c32511a2 remove member's highlight when removed from relation
ref #5612
2018-12-20 09:23:58 -05:00
Max Grossman e3407d4168 do not use mouseover, use mousedown!
ref #5596
2018-12-20 09:05:23 -05:00
Max Grossman 5a1dfeec72 open combobox if anywhere on box clicked...
ref #5596
2018-12-20 08:47:37 -05:00
Xiaoming Gao a4e1012c91 add crossing_way validation
Tests are also added and passed.

One thing to note: I had to add the tree() function to history so that I can
use the tree in the test; hope that's fine.
2018-12-19 19:23:35 -05:00
Quincy Morgan 2207a6c3a4 Added severity tooltip to issue icon 2018-12-19 18:35:17 -05:00
Quincy Morgan ac539dddaa Merge branch 'master' into validation 2018-12-19 18:13:44 -05:00
Quincy Morgan 90e3cd8e87 Merge pull request #5632 from quincylvania/sidebar-behavior-on-feature-selection
Change the initial inspector of the sidebar upon feature selection
2018-12-19 18:07:42 -05:00
Quincy Morgan 3cab39f590 Merge pull request #5631 from wonga00/continuous_validation
listening to user generated history changes for validation
2018-12-19 17:51:44 -05:00
Quincy Morgan cfbb86f88c Change the initial view of the sidebar on selection 2018-12-19 17:44:41 -05:00
Andrew Wong 6e749c70ef listening to user generated history changes for validation 2018-12-19 17:28:34 -05:00
Quincy Morgan 490143d1a8 Added Issues section to the entity sidebar
Fixed bug where stale issues would stick around in the issues pane
2018-12-19 16:12:33 -05:00
Xiaoming Gao efc64f3cf6 Merge pull request #5630 from wonga00/wonga_validation_tests
fixed maprules test and added missing_tag test
2018-12-19 14:03:53 -05:00
Quincy Morgan 9948a7729d Darkened the error item hover color somewhat 2018-12-19 13:41:33 -05:00
Quincy Morgan 92cc7eae15 Added hover background colors to the issue list items 2018-12-19 13:38:36 -05:00
Andrew Wong 0e34313d1d fixed maprules test 2018-12-19 13:38:21 -05:00
Andrew Wong 6ae25eada7 fixing tests around issues 2018-12-19 13:34:16 -05:00
Andrew Wong c11ac6ed89 added missing_tag test 2018-12-19 13:33:02 -05:00
Quincy Morgan 14f62ec3b9 Merge branch 'master' into validation 2018-12-19 13:23:54 -05:00
Quincy Morgan 59b0252b0e Fixed several linting errors 2018-12-19 13:22:48 -05:00
Quincy Morgan fb182dca37 Removed unneeded code in the issues pane 2018-12-19 13:10:03 -05:00
Quincy Morgan 6a931f9be6 Added colors to issue list icons
Corrected icon for warnings
Made disconnected_highway issue a warning instead of an error
2018-12-19 13:07:47 -05:00
Quincy Morgan a95af00b1d Added icons to issues list 2018-12-19 12:40:42 -05:00
Bryan Housel 81b5fc788e Merge pull request #5629 from openstreetmap/5587
5587 - make geolocation show geolocation
2018-12-19 12:14:36 -05:00
Quincy Morgan c4fb38603e Merge branch 'master' into validation 2018-12-19 12:14:32 -05:00
Bryan Housel e1f26b5692 Merge pull request #5624 from ockendenjo/hat-route
Add more tests for splitting ways in relations containing loops
2018-12-19 12:10:12 -05:00
Bryan Housel 7db6133666 Merge pull request #5583 from quincylvania/field-prerequisite-tags
Mechanism for displaying fields conditionally based on tags
2018-12-19 12:08:15 -05:00
Xiaoming Gao c1e3a7396f filter validations early in history
Follow @wonga00's comment in https://github.com/openstreetmap/iD/pull/5627
2018-12-19 12:05:06 -05:00
Max Grossman 399e7781c1 remove dispatched changes and re-order layers
ref #5587
2018-12-19 11:54:39 -05:00
Quincy Morgan a05e259628 Added some initial styling for issues list 2018-12-19 11:28:29 -05:00
Max Grossman 3755951009 remove unused vars
ref #5587
2018-12-19 11:24:26 -05:00
Max Grossman 83c0843e57 just call accuracy function when setting r attr
ref #5587
2018-12-19 11:23:19 -05:00
Max Grossman b010f42125 update layers test for new geolocate svg layer
ref #5587
2018-12-19 11:14:03 -05:00
Max Grossman b9ddfca152 implement point/puck geolocation
ref #5587
2018-12-19 11:06:41 -05:00
Quincy Morgan ff95e6a337 Merge branch 'validationIssueDataModel' into validation 2018-12-19 10:59:45 -05:00
Bryan Housel f478fdbfbd Add preset for Enforcement relation type
(closes #5610)
2018-12-19 10:45:54 -05:00
Quincy Morgan 903cb63efe Renamed validations to issues in relevant places
Made the issue pane get the issues from the issue manager rather than validating itself
2018-12-19 10:41:58 -05:00
Xiaoming Gao 07a53fe6ea Extend data model for validation issues
Add the Issues pane

1. Add a class to represent the validation issue
2. Extend the data model for an validation issue to
  (1) add a severity level field (useful for identify save-blocking issues later)
  (2) replace single entity with an array of entities (useful for issues involving multiple entities)
  (3) add a coordinates field for highlighting the location of the issue on the map
  (4) add a fixes field for possible automatic fixes

3. Update existing validation modules to use the new data model
2018-12-19 10:37:32 -05:00
Quincy Morgan 0d0521c936 Moved feature applicability into the issue manager class 2018-12-19 10:32:14 -05:00
Quincy Morgan 161311faa5 Merge pull request #5626 from wonga00/wonga_issue_manager
added IssueManager
2018-12-18 18:05:40 -05:00
Quincy Morgan 858a9606d5 Added entity display name or preset name to the disconnected highway message 2018-12-18 18:05:27 -05:00