Commit Graph

1151 Commits

Author SHA1 Message Date
Quincy Morgan ee6c06d1d5 Fix an issue where the commit sidebar would not show all warning and errors
Remove use of lodash from commit_warnings.js
2019-02-21 15:33:14 -05:00
Quincy Morgan aff86979a6 Better pane display at narrow window widths (close #5890) 2019-02-20 13:47:11 -05:00
Quincy Morgan 95f8ed9416 Fix issue where clicking the combobox caret would not open the dropdown 2019-02-19 09:46:39 -05:00
Quincy Morgan 31eb837596 Fix issue where fixes would not expand when clicking an issue
Rename issue label class to messages
Remove fix list animation
2019-02-15 13:40:45 -05:00
Quincy Morgan 6cb4359d13 Fix issue where entity issues UI could show stale issues 2019-02-15 12:52:09 -05:00
Quincy Morgan b57e5a75b8 Tweak issue pane icon badge 2019-02-15 12:19:48 -05:00
Quincy Morgan 058a8ee8ff Merge branch 'master' into validation 2019-02-15 12:03:57 -05:00
Bryan Housel 08d4c3268e pacify eslint 2019-02-14 17:26:57 -05:00
Quincy Morgan 75c7fd770d Fix entity not found error 2019-02-14 16:21:29 -05:00
Quincy Morgan 1821c3e955 Update fixes UI for icons, link styling, and non-actionable fixes
Fix several bugs
2019-02-14 15:56:04 -05:00
Quincy Morgan 4c9ec3e9e8 Merge branch 'master' into validation 2019-02-14 13:35:14 -05:00
Quincy Morgan ea3a85e88e Merge pull request #5888 from openstreetmap/dynamic-line-icon-lines
Dynamic line previews in line preset icons
2019-02-14 12:27:02 -05:00
Quincy Morgan c7e861c0ca Merge branch 'master' into validation 2019-02-14 12:16:23 -05:00
Quincy Morgan d0c29f8554 Tweak line icon display 2019-02-14 10:06:50 -05:00
Quincy Morgan d63430e66a Line preset icons:
- Render vertices with SVG
- Add viewBox to SVG
- Don't reload static parts of the SVG on every update
- Use dimensions that are friendly for low-res displays
- Use nicer-looking stroke dash patterns for ferry routes and railways
2019-02-14 09:40:17 -05:00
Bryan Housel 6525bbf154 Exclude current entity's value from address nearby values lookup
re: https://github.com/openstreetmap/iD/issues/5887#issuecomment-463385328
2019-02-14 00:27:32 -05:00
Bryan Housel 9e2acd836c Use case sensitive combos in address fields
(closes #5887)

This allows users to correct mistyped address parts
2019-02-14 00:20:38 -05:00
Bryan Housel 6a560861b2 Add notification badge to Issue pane icon 2019-02-13 16:56:17 -05:00
Quincy Morgan ed95fafac9 Add endpoint vertices to the preset icon line 2019-02-13 16:12:29 -05:00
Bryan Housel 5bca360f50 Don't show the entity_issues section if there are no issues
(I think it worked this way before)
2019-02-13 13:57:46 -05:00
Bryan Housel c292a32a66 Better message padding, remove double tooltip 2019-02-13 13:47:00 -05:00
Quincy Morgan f443144fc6 Update preset icons to use same tag classes as map SVG 2019-02-13 13:11:27 -05:00
Quincy Morgan 041e05ec90 Make the line component of the line preset icons dynamic and match the line styling in the map 2019-02-13 12:01:40 -05:00
Bryan Housel 448fe498bd Only recenter view if necessary, select after delay, fix maprules type 2019-02-12 17:25:54 -05:00
Quincy Morgan 393bb7f5e3 Fix several bugs with arrow key navigation in preset list 2019-02-12 17:17:13 -05:00
Quincy Morgan 5e586419fa Remove unnecessary float styles and cleanup CSS in the preset list 2019-02-12 16:29:52 -05:00
Quincy Morgan 9007ccb8fd Disable preset buttons for hidden layers 2019-02-12 14:43:04 -05:00
Bryan Housel 9ebc9a22e9 perf: use Object instead of Array for lookup, cache on osmEntity.key 2019-02-12 14:23:50 -05:00
Bryan Housel 4e6ade08b1 Comment out cache in getIssuesForEntityWithID
It seems like entity editor draws before the validator runs so the
rendered list is often one history change behind.
2019-02-12 00:22:24 -05:00
Bryan Housel 6cb1656cac Animate expand fix menus 2019-02-12 00:00:12 -05:00
Bryan Housel 81bd734849 WIP uiEntityIssues cleanups, simplify
fixes are still not being applied properly
2019-02-11 20:44:02 -05:00
Bryan Housel f4ccd8a3dc Update issue text/icon on update selection 2019-02-11 16:22:24 -05:00
Bryan Housel a5ffec5665 utilHighlightEntities accept an array instead of calling it in a loop 2019-02-11 12:40:23 -05:00
Quincy Morgan 0826050b55 Only zoom to the clicked issue in the entity sidebar if it isn't visible 2019-02-11 12:10:57 -05:00
Quincy Morgan 99e1203d46 Zoom to entity when opening an issue without a specific location in the entity editor 2019-02-11 11:48:21 -05:00
Quincy Morgan 149e1b3e4d Removed unused string 2019-02-11 11:41:18 -05:00
Quincy Morgan 47ec58e5fc Don't zoom to the end vertex when continuing a disconnected highway if it is already visible
Add separate fixes for continuing a disconnected highway from the start and end vertices
Highlight the vertex that will be continued
2019-02-11 11:29:34 -05:00
Quincy Morgan 01b0c618d1 Don't highlight the selected entity when hovering over issues in the entity editor 2019-02-11 10:58:47 -05:00
Quincy Morgan 83f8cd97f6 Add feature highlighting when hovering over their corresponding issues 2019-02-11 09:45:33 -05:00
Quincy Morgan db319e8ff5 Merge branch 'master' into validation 2019-02-11 07:59:29 -05:00
Bryan Housel ba44c80076 Force visible any entities related to a selected error
(closes #5880)
2019-02-10 23:29:49 -05:00
Bryan Housel 26368522c9 Batch changes from raw tag editor so blur/remove tag don't conflict
(closes #5878)
2019-02-10 22:08:13 -05:00
Bryan Housel d64a4c5654 Don't pan map when resizing sidebar on right-to-left layout
(closes #5881)
2019-02-09 15:48:55 -05:00
Bryan Housel 29ce6cb30c Use proper errbacks
(re: #5823)
2019-02-09 14:51:37 -05:00
SilentSpike 24022416cb Fix negative number of trips in ImproveOSM issues
See https://github.com/openstreetmap/iD/pull/5739#issuecomment-460786055
2019-02-09 16:31:37 +00:00
Bryan Housel fbe584c7ec Lookup docs for some presets on wikidata, not wikibase
(re: #5823)

Now `uiTagReference` can accept a `qid` param for presets where we want this
(such as brands)
2019-02-08 16:27:33 -05:00
Bryan Housel b050c2f442 Avoid keeping focus on the documentation lookup button 2019-02-08 13:34:29 -05:00
Quincy Morgan ff6860693a Merge branch 'master' into validation 2019-02-08 13:21:46 -05:00
Bryan Housel e0459279bb Move implementation details from uiTagReference to wikibase service 2019-02-08 12:08:36 -05:00
Bryan Housel 71f2bd5900 Fix key sorting between hover/select
(this is a better fix for #5857)
2019-02-08 09:37:51 -05:00