Commit Graph

156 Commits

Author SHA1 Message Date
Quincy Morgan
78590466ba Merge branch 'master' into add-feature-search-bar 2019-03-06 15:50:31 -05:00
Bryan Housel
e216d5be3e Avoid dispatching extra change events, don't mutate childNodes
(closes #5996, related #5941)
2019-03-06 15:41:12 -05:00
Quincy Morgan
6e0f5c6823 Allow adding vertex-only features from the serach-to-add field
Allow favoriting vertex presets
Don't allow adding vertex-only presets as points
Rename Other preset to Vertex
2019-03-04 17:38:08 -05:00
Quincy Morgan
b828ada0e2 Don't allow adding point-only features as vertices 2019-03-04 17:04:35 -05:00
Quincy Morgan
5ed5a7536b Show preset browser when adding generic point, line, or area 2019-03-01 09:07:41 -05:00
Quincy Morgan
a3424aa4b1 Merge branch 'master' into squash-favorite-preset 2019-02-26 14:25:34 -05:00
Quincy Morgan
5262358d81 Fix an issue where added nodes would highlight momentarily while drawing an area 2019-02-26 09:34:45 -05:00
Quincy Morgan
0e71ae7032 Fix lint warning 2019-02-25 11:40:26 -05:00
Quincy Morgan
ced652806b Fix an issue where some tagged nodes or existing vertices could not be snapped to (close #5942) 2019-02-25 08:54:30 -05:00
J Guthrie
249046614c Add exception to isInvalidGeometry algorithm
- An area with just 1 placed node (2 nodes including active, to-be-placed node,
    returns as valid and is picked up by later way.isDegenerate() check
2019-02-24 13:58:16 +00:00
Quincy Morgan
7da37384f1 Fix an issue where stale missing tag errors could persist when canceling drawing a new way (close #5918)
Don't show missing tags error for a feature that is still being drawn (re: #5898)
2019-02-21 09:48:46 -05:00
Quincy Morgan
be71554f61 Fix a bug where all data would disappear when switching modes while drawing a way (close #5917) 2019-02-21 09:22:03 -05:00
Brian Hatchl
1faa6ad839 Favorite preset 2019-02-20 15:23:58 -05:00
Quincy Morgan
708c5e8155 Fix crash when undoing an added line past the first node 2019-02-19 12:10:05 -05:00
Quincy Morgan
31eb837596 Fix issue where fixes would not expand when clicking an issue
Rename issue label class to messages
Remove fix list animation
2019-02-15 13:40:45 -05:00
Quincy Morgan
058a8ee8ff Merge branch 'master' into validation 2019-02-15 12:03:57 -05:00
Quincy Morgan
0b86be7bcb Fix bug where highlight would not appear on the first target node when continuing drawing a way 2019-02-15 11:56:31 -05:00
Quincy Morgan
96a1ec92c7 Fix prior commit
Apply same node snap suppression behavior to dragging vertices as to drawing ways
2019-02-15 10:28:43 -05:00
Quincy Morgan
55c10d2183 Only check to suppress vertex-snap highlighting for nodes (re: #5875) 2019-02-15 09:09:35 -05:00
Bryan Housel
078b19c828 Better handle undo/interruption during behaviorDrawWay 2019-02-14 17:24:09 -05:00
Quincy Morgan
db319e8ff5 Merge branch 'master' into validation 2019-02-11 07:59:29 -05:00
Bryan Housel
6e45796be7 Merge pull request #5875 from openstreetmap/dont-snap-non-vertices
Dont snap to non-vertices
2019-02-10 22:13:09 -05:00
Quincy Morgan
a80aaf65db Improve performance when checking way for self-intersection when drawing 2019-02-05 11:42:45 -05:00
SilentSpike
781558e56b Remove redundant source property 2019-02-04 18:40:06 +00:00
SilentSpike
3ed13e9a4a Convert KeepRight to use generic error type 2019-02-04 16:54:07 +00:00
SilentSpike
20ed8b50c9 Add generic QA error
I've converted the improveOSM errors to use this new generic QA error
structure which should allow for more general code to be used in
behaviour and UI.

Sidebar preview is currently broken, but will be fixed shortly.
2019-02-04 16:53:59 +00:00
SilentSpike
ee5f9f3bf2 Use consistent short service name 2019-02-01 22:51:02 +00:00
SilentSpike
214cf41019 Use more generic classes for errors 2019-02-01 22:50:57 +00:00
SilentSpike
4f2646d567 Add basic title + description UI 2019-02-01 22:50:54 +00:00
Max Grossman
58e31bc45a initial update to draw modes and hover behavior
ref #5811
2019-02-01 17:34:40 -05:00
Quincy Morgan
1066f8f788 Fix issue where preset browser would show after continuing a line (close #5770) 2019-01-28 08:52:20 -05:00
Bryan Housel
fadd8e2e8a Switch KeepRight markers to use touch targets
This makes it easier to select the KeepRight issue and avoid selecting
the OSM geometry underneath them
2019-01-04 21:17:38 -05:00
Bryan Housel
cd9203975d Use touch targets for notes, fix a few bugs with note dragging
(closes #5213)
2019-01-04 15:48:39 -05:00
Thomas Hervey
31f35b0389 added basics to sidebar 2018-12-19 13:35:26 -05:00
Bryan Housel
152022aec4 Use context.keybinding for keybindings that don't change
(closes #5487)
2018-11-13 20:57:21 -05:00
Bryan Housel
bb30cbf555 Move lib/d3.keybinding.js -> util/keybinding.js
almost none of the original d3 "plugin" code remains
2018-11-13 13:42:09 -05:00
Bryan Housel
2ffcec965a Don't snap notes to OSM elements
(closes #5191)
2018-11-12 17:23:38 -05:00
Bryan Housel
eba115803a Variable cleanups in behavior and modes 2018-09-06 09:50:26 -04:00
Bryan Housel
cc938698e8 Add ability to select custom data 2018-08-25 11:14:04 -04:00
Bryan Housel
0a82ab125e Add uiDataEditor for inspecting custom map data 2018-08-25 10:10:04 -04:00
Bryan Housel
a9aca707b6 Support hovering on data features 2018-08-25 00:04:52 -04:00
Thomas Hervey
06a410107b cleaned up merge relics and comments 2018-07-20 23:31:49 -04:00
Thomas Hervey
a6bdbcabb2 merged from 2018-07-20 23:21:24 -04:00
Thomas Hervey
fbedbb1608 select note before rendering sidebar 2018-07-20 23:17:41 -04:00
Thomas Hervey
bf9b19359a WIP drag note 2018-07-20 21:41:44 -04:00
Thomas Hervey
24579b15bc WIP testing new drag_notes mode 2018-07-20 14:26:02 -04:00
Thomas Hervey
14212b47fe WIP: drag note 2018-07-19 15:21:46 -04:00
Thomas Hervey
73ee5c2fc9 fixed select_note mode, cleaned note_editor, TODO: enable note save 2018-07-03 22:45:51 -04:00
Bryan Housel
bf499d9438 Restore modeSelect, and make a new modeSelectNote just for the notes 2018-07-03 18:11:59 -04:00
Bryan Housel
b14d1b5061 resolve conflicts, fix a few minor bugs prob caused by merging:
- don't insert multiple times into the rtree in `services/osm.js`
- use `d.id` instead of `d.key` as the key in `svg/notes.js`
2018-07-03 16:40:07 -04:00