2728 Commits

Author	SHA1	Message	Date
Bryan Housel	e4fc821eb0	Just use reduce	2019-04-22 09:49:17 -04:00
Bryan Housel	3557e3c711	Don't allow disconnecting a way if parts extend to undownloaded tiles ... (re: #2248, #4245)	2019-04-20 00:02:46 -04:00
Bryan Housel	bbf4495f5c	pacify eslint	2019-04-19 23:44:49 -04:00
Bryan Housel	7c85cc997e	Merge branch 'master' into validation_and_change_perf	2019-04-19 22:44:04 -04:00
Quincy Morgan	b566ef05b5	Add Option+W shortcut to toggle the OSM data layer (close #6104)	2019-04-19 14:51:53 -07:00
Quincy Morgan	a892114351	Fix disconnection code test (close #4245)	2019-04-19 13:26:16 -07:00
Bryan Housel	51c1088c1b	Merge branch 'master' into validation_and_change_perf	2019-04-19 15:18:23 -04:00
Quincy Morgan	130e9909f6	Allow disconnecting an entire way from other ways at once (close #4245)	2019-04-19 11:54:13 -07:00
Bryan Housel	b5c5a00abc	Get rid of the many_deletions validation 🔪 ... It just doesn't fit in with all of the other validations that work on entities, and it's not an actionable warning anyway. https://github.com/openstreetmap/iD/pull/6140#issuecomment-483014618	2019-04-19 13:33:29 -04:00
Bryan Housel	2ebbb68604	Restore tooltips on rule checkboxes, separate 'tip' and 'reference' ... Reference will show on clicking info button, and can contain more useful information than a tooltip can.	2019-04-19 13:24:55 -04:00
Bryan Housel	4d66cacb27	Nodes needs Array.length not Set.size	2019-04-19 11:04:41 -04:00
Bryan Housel	1092ddb125	Make sure to update the save count when restoring changes too	2019-04-19 10:56:00 -04:00
Bryan Housel	ae06e28f9b	Try to avoid style recalculation when typing on the comment box ... I think this doesn't completely work.. It reduces the amount of unnecessary DOM changes, but there are still some more.	2019-04-19 10:02:25 -04:00
Bryan Housel	ca02f7ed06	Must use context.graph to validate entities instead of validatedgraph ... This is because all the validators use it, and it's the right thing to do. As entites load from the OSM or are restored from history, the most updated version of them will be in context.graph, not validatedGraph	2019-04-19 10:00:38 -04:00
Bryan Housel	c4209515a5	Only consider hiding features matched to a rule ... (Fixes accidental hiding of vertices)	2019-04-18 19:26:17 -04:00
Bryan Housel	a56c1af725	pacify eslint	2019-04-18 19:26:05 -04:00
Bryan Housel	a55b4387fe	Make sure the notification badge starts out hidden	2019-04-18 19:06:23 -04:00
Bryan Housel	0eed80e1d2	Persist disabled rules in localStorage	2019-04-18 17:30:55 -04:00
Quincy Morgan	2f695a9747	Add link to the PeWu history viewer to the History panel (close #6202)	2019-04-18 14:06:48 -07:00
Bryan Housel	7c8a6eac9d	Reintroduce disabled rules ... - They still run, but results are excluded from lists - Also make sure to revalidate/dispatch/update when toggling rules	2019-04-18 17:05:33 -04:00
Quincy Morgan	a30051fd9c	Restore full screen ability	2019-04-18 10:37:22 -07:00
Bryan Housel	9c4881cade	Change autofix to accept arguments to perform, implement "fix all"	2019-04-17 17:51:29 -04:00
Bryan Housel	d6327aec56	Make reference function optional ... Now it shows the "No documentation available" message if there is not one	2019-04-17 09:05:05 -04:00
Bryan Housel	0d70f0670d	Better test for whether untagged entities can be deleted ... Now entities can always be deleted if the user created them in the first place.. We skip asking `operationDelete.disabled()` because there are reasons why this may return true. A thing that could happen before: - User creates an untagged entity - Quits browser and restarts iD - Restores history - The entity happens to be in a part of the map that hasn't been loaded yet, so `operationDelete.disabled()` returns true, and the issue ends up as a 'warning' instead of an 'error'	2019-04-16 22:56:43 -04:00
Quincy Morgan	2967d2d020	Add support for icons from the noun project (close #5691)	2019-04-16 18:06:05 -07:00
Quincy Morgan	84b7e08bf8	Don't select the previously-edited node when undoing/redoing (re: #5831)	2019-04-16 14:21:15 -07:00
Bryan Housel	01d2e3eaf3	Replace validator tooltip with reference function, add tag diff	2019-04-16 17:07:53 -04:00
Quincy Morgan	3a2757576b	Add Monorail Route, Turnstile, and Transit Stop Area Group presets (close #5757)	2019-04-16 11:41:56 -07:00
Quincy Morgan	72266af1e5	Show case-sensitive taginfo results for Manufacturer field	2019-04-16 09:59:00 -07:00
Bryan Housel	8afd8887cf	Restyle much of the issues and entity issues - avoid tooltips	2019-04-16 12:33:48 -04:00
Bryan Housel	294ce00211	substitute 'info' for 'data' (so I can use 'info' for an info drawer)	2019-04-15 16:56:21 -04:00
Quincy Morgan	80a6e1806f	Don't remove wikidata tag when clearing the wikipedia field value (close #4322)	2019-04-15 13:39:30 -07:00
Quincy Morgan	6bdf6c5127	Fix minimap position (close #6167) ... Flexbox panes and info panels to prevent overlap (close #4733)	2019-04-15 11:50:54 -07:00
Bryan Housel	f6708fd84c	Hide feature if _all_ rules hidden (was: if _any_ rule hidden) ... This matters as we start to match more rules for hybrid features like rail platforms, which now match both path and rail. We want to show them unless the user has hidden all the rules that they match. Also this changes the test code slightly to actually test rule matching. Before it was really just testing hiding.	2019-04-15 10:20:58 -04:00
Bryan Housel	15e73d2836	Trying out simpler outdated_tags code, with tag diff	2019-04-14 17:25:51 -04:00
Bryan Housel	5a0f21fa7a	Add ability for a fix to be auto, and add auto fix buttons ... This also changes some of the list items that were previously buttons to divs, since we can't nest buttons.	2019-04-13 10:50:47 -04:00
Bryan Housel	ce89d7359b	Sort issues list by dist from the map center, cutoff at 1000 items	2019-04-12 14:26:05 -04:00
Bryan Housel	da1fe8343a	Remove mode checking code from missing_tag, as these validate anytime ... This was causing it to not immediately flag "area with no tags" as an error. (until the user edited the area some other way)	2019-04-12 12:49:47 -04:00
Bryan Housel	0ec9cd91dc	Warm up the feature matching cache upon merging fetched data ... Also rename `_features` to `_rules`, since we use the word features too much	2019-04-12 12:25:37 -04:00
Bryan Housel	efcd6b6bc2	Consolidate idle functions into idle.js, defer validation after merge	2019-04-12 10:49:21 -04:00
Bryan Housel	0dd262d1dd	Don't dispatch 'change' on history.merged, dispatch 'merge' only ... Change performs an expensive immediate redraw, and merge can schedule a redraw for later.	2019-04-12 09:56:18 -04:00
Bryan Housel	dda810683e	Adjust matchscore, feature filters to boost physical tags over boundary ... (closes #6162)	2019-04-11 21:26:53 -04:00
Bryan Housel	2b050549eb	Avoid reflow in minimap by hardcoding its dimensions	2019-04-11 21:05:04 -04:00
Bryan Housel	31b64f253c	Rerun validation when assigning a preset	2019-04-11 15:11:29 -04:00
Bryan Housel	96c277f46d	Simplify issue-options css	2019-04-11 14:59:32 -04:00
Bryan Housel	35049ab40a	Replace getErrors/getWarnings with getIssues/getIssuesBySeverity ... The idea here is that the validator will now hold onto lots of issues, but the calling code will only want some small subset of them (edited/everything) (inview/everywhere) and can pass these as options so that we don't need filtering code spread throughtout the app.	2019-04-11 14:48:23 -04:00
Bryan Housel	569cbd1a92	entity.v can be 0, so check for === undefined instead	2019-04-11 14:40:34 -04:00
Bryan Housel	4c563f4edf	Add validation options ... Check: [] My Edits [] Everything Where: [] In View [] Everywhere	2019-04-11 11:55:17 -04:00
Bryan Housel	0a77a494aa	Merge branch 'master' into validation_and_change_perf	2019-04-10 14:22:20 -04:00
Bryan Housel	9100ce3ee4	Don't validate vertices which extend beyond the downloaded map ... (closes #5938)	2019-04-10 13:40:06 -04:00