Commit Graph

4809 Commits

Author SHA1 Message Date
Bryan Housel
ebaaa4ba5a Initialize radialMenu earlier
This prevents it from being undefined when exiting back to browse mode:
  in selectElements() (re 2024e233 crash if element id passed in url hash)
  in update() (possible re #2151?)
2014-11-19 00:18:39 -05:00
Bryan Housel
3974bcf41b Move editable() to be with the other map things 2014-11-19 00:17:50 -05:00
Bryan Housel
81ea0276f8 Don't show "0 Hidden Features" warning after editOff
(regressed in 916a901)
2014-11-18 22:05:20 -05:00
Bryan Housel
dfe8fd1e90 features performance enhancements
1. reusue entity.geometry where possible
2. cache entity parents
2014-11-18 22:05:08 -05:00
John Firebaugh
d444c907e8 Style 2014-11-11 15:12:08 -08:00
Sajjad Anwar
17fb2f64e5 Configurable minimum editable zoom 2014-11-11 14:37:11 -08:00
John Firebaugh
9e9a4b3cc0 Fix tests 2014-11-11 14:32:50 -08:00
John Firebaugh
916a901b8f Show all features as auto-hidden when map is not editable 2014-11-11 14:16:16 -08:00
John Firebaugh
c66091c00c Merge pull request #2357 from bhousel/feature-filtering
Feature filtering
2014-11-11 12:16:42 -08:00
Bryan Housel
2024e2333d Exit select mode if selected DOM elements have disappeared 2014-11-10 23:23:28 -05:00
Bryan Housel
af3c307b17 cache invalidation and naming things 2014-11-10 22:47:07 -05:00
Bryan Housel
c6ca68ce80 create feature _cache to store matches per entity
also remove old commented code
2014-11-08 00:19:36 -05:00
jgpacker
977949292d Fix a typo: Confectionary → Confectionery 2014-11-07 22:23:30 -02:00
Bryan Housel
30dde37e02 fix partial fill mode - pointer events visible stroke only
also, fix wireframe mode - pedestrian style
2014-11-06 23:47:54 -05:00
Bryan Housel
d5879fa855 reuse _stats, don't count vertices and relations 2014-11-06 23:04:25 -05:00
Bryan Housel
55e6f9ec93 faster tests for certain geometry (vertex, point) 2014-11-06 12:54:58 -05:00
Bryan Housel
0d6d4b3d24 remove footer "features hidden" warning in editOff 2014-11-06 00:33:45 -05:00
Bryan Housel
ace44d2e7d fix highway-pedestrian line width to work in wireframe 2014-11-06 00:22:19 -05:00
Bryan Housel
788dedc595 more performance improvements for feature filters
* use named filter functions for easier profiling
* remove some unnecessary line/area geometry checks
* replace some lodash code with for loops
* reorder some tests to put cheap condition early
2014-11-06 00:18:45 -05:00
Bryan Housel
2f6004fcfa performance tuning work-in-progress
* store entity's matched features in a graph transient
* replace fn calls to get commonly used _keys and _hidden arrays
* replace lodash calls with faster for loops (in some places)
* always pass graph/resolver as a param
2014-11-05 00:27:14 -05:00
John Firebaugh
59c39b5d17 Exclude name suggestions from areaKeys (fixes #2435) 2014-11-01 11:42:53 -04:00
samanpwbb
8ca46516e4 more straightforward preset form insertion 2014-10-31 17:15:59 -04:00
samanpwbb
140b56a68a style adjustments + clean out unused code 2014-10-31 17:09:49 -04:00
Bryan Housel
c941bd5a4b 2 things related to gatherStats auto-hiding..
* skip gatherStats on differenced redraws..
* force full redraw when gatherStats autohides/unhides features
  (before: extent redraws would happen, counts would update,
   but buildings/points would stay on the screen)
2014-10-31 11:58:02 -04:00
Bryan Housel
224db06ca4 design enhancements..
* replace full width bottom bar with subtle list item
* move hidden feature details to list item tooltip
* simplify some of the text labels on the Map Data panel
* progressively hide some footer elements with media queries
2014-10-31 10:55:00 -04:00
Aaron Lidman
ced0158327 Fix .more-fields string 2014-10-30 16:07:38 -04:00
Bryan Housel
6b31eab5a7 Deselect features that are hidden.. 2014-10-30 15:01:03 -04:00
Aaron Lidman
554dc77cef Dropdown fixes 2014-10-29 18:24:32 -04:00
Aaron Lidman
5c5649f3d8 Replace buttons with dropdown 2014-10-29 17:13:05 -04:00
Bryan Housel
9c32b89e6a When showing mapdata, background, or help panel, hide others 2014-10-29 16:14:43 -04:00
Bryan Housel
7c50c01bd3 mapdata checkboxes should use features.enabled() 2014-10-29 16:06:41 -04:00
Bryan Housel
b20f1495de restore toggle function and add test 2014-10-29 15:06:43 -04:00
Bryan Housel
a2703f10c8 fix tests affected by change in equality testing re #2388 2014-10-28 21:49:31 -04:00
Bryan Housel
927c533bb4 add feature tests for auto-hiding 2014-10-28 21:37:04 -04:00
Bryan Housel
43f1cdd3eb decoupled graph from context for better testing
fixed feature matching tests for vertices and relations
2014-10-28 21:37:04 -04:00
Bryan Housel
2b260f9a6c added tests for feature filtering
(some tests failing because I need to decouple graph from context)
2014-10-28 21:37:04 -04:00
Bryan Housel
6b6ca8d523 initial checkin of features unit tests 2014-10-28 21:37:04 -04:00
Bryan Housel
1f544e883b bump chai to 1.9.2 and fix tests affected by change in equality testing
re #2388
2014-10-28 21:37:04 -04:00
Bryan Housel
d5ecd5d52d add deep equals to extent 2014-10-28 21:37:03 -04:00
Bryan Housel
7d9b267858 Show auto-hidden features as disabled checkboxes with tooltip
also rearrange map data panel to put features last
2014-10-28 21:37:03 -04:00
Bryan Housel
094db692ea Don't include hidden vertices in drawHover 2014-10-28 21:37:03 -04:00
Bryan Housel
a085ce6dc8 Don't hide features that the user just created 2014-10-28 21:37:03 -04:00
Bryan Housel
9666af30c6 better point/building culling based on viewport size 2014-10-28 21:37:03 -04:00
Bryan Housel
c9426531d5 Remove footer opacity dimming
re: https://github.com/openstreetmap/iD/pull/2357#issuecomment-60106754
2014-10-28 21:37:03 -04:00
Bryan Housel
8c423651b2 Update help text because GPS tracks are purple now 2014-10-28 21:37:03 -04:00
samanpwbb
794a4bcb30 new icon 2014-10-28 21:37:02 -04:00
samanpwbb
70e7987943 add data icon, fix button style 2014-10-28 21:37:02 -04:00
Bryan Housel
da32150c4a Revert some of 2832041 because of Firefox pattern fill issues
Looks like styling the element is the only way to achieve this after all..
2014-10-28 21:37:02 -04:00
Bryan Housel
e761414a15 'Rail' feature filter should not match if it is also a highway. 2014-10-28 21:37:02 -04:00
Bryan Housel
59918431f2 Fix the source switcher 2014-10-28 21:37:02 -04:00