Commit Graph

2386 Commits

Author SHA1 Message Date
Quincy Morgan ee6c06d1d5 Fix an issue where the commit sidebar would not show all warning and errors
Remove use of lodash from commit_warnings.js
2019-02-21 15:33:14 -05:00
Quincy Morgan 10e73fc15c Explicitly include certain railways for crossing validation instead of excluding some
Don't flag abandoned or razed railway crossings
2019-02-21 15:09:13 -05:00
Quincy Morgan 02d3097d8d Fix a cacheing issue 2019-02-21 13:34:51 -05:00
Quincy Morgan 7936266a7a Improve validation performance by avoiding uniqueWith lodash function
Replace map lodash function with JavaScript array map in validator.js
2019-02-21 12:13:27 -05:00
Quincy Morgan 51972ea78f Cache issues in crossing ways validation to avoid checking the same pairs twice 2019-02-21 11:49:31 -05:00
Quincy Morgan aa992ed981 Improve validation performance by cacheing the issue id 2019-02-21 10:47:57 -05:00
Quincy Morgan 2d6c49b92b Ignore proposed features for crossings ways, almost junction, and disconnected way validations (close #5922) 2019-02-21 10:14:25 -05:00
Quincy Morgan 7da37384f1 Fix an issue where stale missing tag errors could persist when canceling drawing a new way (close #5918)
Don't show missing tags error for a feature that is still being drawn (re: #5898)
2019-02-21 09:48:46 -05:00
Quincy Morgan be71554f61 Fix a bug where all data would disappear when switching modes while drawing a way (close #5917) 2019-02-21 09:22:03 -05:00
Quincy Morgan 1bde3ba63f v2.14.1 2019-02-20 18:23:47 -05:00
SilentSpike 5bd13dc590 Use https for ImproveOSM requests 2019-02-20 23:11:09 +00:00
Quincy Morgan 1f1e88314d v2.14.0 2019-02-20 16:19:36 -05:00
Quincy Morgan affdb8c860 Fix waterway relation icon color 2019-02-20 15:22:24 -05:00
Quincy Morgan aff86979a6 Better pane display at narrow window widths (close #5890) 2019-02-20 13:47:11 -05:00
Quincy Morgan a928621681 Fix issue where mapillary sign colors were not shown 2019-02-20 11:09:57 -05:00
Quincy Morgan 6342235a6b Use warning instead of error for missing tags issue for non-deletable relations 2019-02-20 10:27:49 -05:00
Quincy Morgan e102c3fdc6 Don't allow actionable deletion of relations if not all members are downloaded 2019-02-20 10:20:26 -05:00
Quincy Morgan 598827db87 Add quick fix to remove deprecated tags 2019-02-20 10:06:44 -05:00
Quincy Morgan cdc4557da5 Minor performance improvement in crossing ways by removing use of lodash and avoiding a concat within a reduce 2019-02-20 09:50:53 -05:00
Quincy Morgan e161db0301 Remove unused deprecate_tags action 2019-02-20 09:05:34 -05:00
Quincy Morgan ba68d921fe Add icons for crossing ways fixes and almost junction connection fix 2019-02-20 09:02:05 -05:00
Quincy Morgan 63caa02cea Allow presets to inherit multiCombo and semiCombo fields even if they define the preset 2019-02-19 15:48:50 -05:00
Quincy Morgan 6d397e89c6 Account for waterway bridges and implicit layers in crossing ways validation 2019-02-19 15:28:27 -05:00
Quincy Morgan f536706763 Refactor crossing ways validation for performance 2019-02-19 14:40:54 -05:00
Quincy Morgan b766f82cbd Improve crossing ways performance slightly by avoiding clone 2019-02-19 13:25:02 -05:00
Quincy Morgan 708c5e8155 Fix crash when undoing an added line past the first node 2019-02-19 12:10:05 -05:00
Quincy Morgan 12a44421c3 Account for indoor features in crossing ways validation
Recommend using an appropriate structure/layer/level for crossing ways validation
Flag crossing highways on different levels but without bridges or tunnels
2019-02-19 11:43:05 -05:00
Quincy Morgan 95f8ed9416 Fix issue where clicking the combobox caret would not open the dropdown 2019-02-19 09:46:39 -05:00
Quincy Morgan b43796a4c7 Don't flag almost junctions for points endpoints that also occur earlier in the way 2019-02-19 09:16:32 -05:00
Quincy Morgan 794e953d43 Don't suggest continuing a disconnected highway from endpoints that have noexit=yes 2019-02-19 08:40:49 -05:00
Quincy Morgan b483832a80 Remove unused parameter 2019-02-18 14:14:36 -05:00
Quincy Morgan 7307beff21 Don't make connect endpoints fix for tag suggest area actionable if there aren't more than two nodes 2019-02-18 12:51:50 -05:00
Quincy Morgan 10d9f05739 Show the actual deprecated tag value in the issue message rather than the * placeholder 2019-02-18 12:17:52 -05:00
Quincy Morgan 66db6f3f2c Make building crossing validation only create one issue per feature pair (re: #5891) 2019-02-18 10:43:19 -05:00
Quincy Morgan 94cb9faaa2 Don't check for self-intersection in the crossing ways validation 2019-02-18 10:16:22 -05:00
Quincy Morgan 7021985aec Don't suggest connection fix for highway-building crossings (re: #5891) 2019-02-18 10:12:47 -05:00
Quincy Morgan e48f8cfc48 Fix generic name issue message 2019-02-18 10:11:01 -05:00
Quincy Morgan 2c1955d630 Improve performance and scope of the generic name validation 2019-02-18 10:02:49 -05:00
Quincy Morgan 397097ac1f Tweak issue and fix strings
Different strings for one vs. a combination of deprecated tags
2019-02-15 14:24:11 -05:00
Quincy Morgan 31eb837596 Fix issue where fixes would not expand when clicking an issue
Rename issue label class to messages
Remove fix list animation
2019-02-15 13:40:45 -05:00
Quincy Morgan 6cb4359d13 Fix issue where entity issues UI could show stale issues 2019-02-15 12:52:09 -05:00
Quincy Morgan b57e5a75b8 Tweak issue pane icon badge 2019-02-15 12:19:48 -05:00
Quincy Morgan 058a8ee8ff Merge branch 'master' into validation 2019-02-15 12:03:57 -05:00
Quincy Morgan 0b86be7bcb Fix bug where highlight would not appear on the first target node when continuing drawing a way 2019-02-15 11:56:31 -05:00
Quincy Morgan 96a1ec92c7 Fix prior commit
Apply same node snap suppression behavior to dragging vertices as to drawing ways
2019-02-15 10:28:43 -05:00
Quincy Morgan 55c10d2183 Only check to suppress vertex-snap highlighting for nodes (re: #5875) 2019-02-15 09:09:35 -05:00
Bryan Housel 08d4c3268e pacify eslint 2019-02-14 17:26:57 -05:00
Bryan Housel 078b19c828 Better handle undo/interruption during behaviorDrawWay 2019-02-14 17:24:09 -05:00
Quincy Morgan 75c7fd770d Fix entity not found error 2019-02-14 16:21:29 -05:00
Quincy Morgan 1821c3e955 Update fixes UI for icons, link styling, and non-actionable fixes
Fix several bugs
2019-02-14 15:56:04 -05:00