Quincy Morgan
1f21b029fd
Move tag upgrade fix to an action and add unit tests
2019-02-26 10:42:12 -05:00
Quincy Morgan
5262358d81
Fix an issue where added nodes would highlight momentarily while drawing an area
2019-02-26 09:34:45 -05:00
Quincy Morgan
a4e0bcb29c
Make misplaced multipolygon tags check more consistent
2019-02-26 08:53:00 -05:00
Quincy Morgan
7d8453b1fb
Remove service road exception for adding highway=crossing during crossing way fix (re: #5976 )
2019-02-26 08:12:42 -05:00
Quincy Morgan
87e48bc543
Run missing role validation before missing tag
2019-02-25 18:01:34 -05:00
Quincy Morgan
6aa1f86dfb
Add warning for multipolygon members with no set role ( close #5851 )
2019-02-25 17:46:50 -05:00
Quincy Morgan
b8ac9a7de3
Add toggle-able list of rules to the Issues pane ( close #5979 )
...
Toggling a rule off prevents the validation from running
2019-02-25 15:31:05 -05:00
Quincy Morgan
66301864c1
Fix false positive of tags suggesting area on features where other tags define the preset ( close #5945 , re: #5933 )
2019-02-25 13:10:55 -05:00
Quincy Morgan
12b1af7002
Don't say tags imply area for tags that iD doesn't have a preset for ( close #5933 )
2019-02-25 12:42:39 -05:00
Quincy Morgan
0e71ae7032
Fix lint warning
2019-02-25 11:40:26 -05:00
Quincy Morgan
7f58454958
Don't tag connection nodes of paths crossing service or track roads as highway=crossing in crossing ways quick fix (re: #5976 )
2019-02-25 11:39:03 -05:00
Quincy Morgan
07fe7a1107
Fix an issue where pressing enter in the preset search bar wouldn't select the first preset ( close #5921 )
2019-02-25 10:42:10 -05:00
Quincy Morgan
2d974caed1
Fix an issue where preset buttons would always be disabled if Other Features were hidden ( close #5934 )
2019-02-25 10:27:06 -05:00
Quincy Morgan
ced652806b
Fix an issue where some tagged nodes or existing vertices could not be snapped to ( close #5942 )
2019-02-25 08:54:30 -05:00
J Guthrie
249046614c
Add exception to isInvalidGeometry algorithm
...
- An area with just 1 placed node (2 nodes including active, to-be-placed node,
returns as valid and is picked up by later way.isDegenerate() check
2019-02-24 13:58:16 +00:00
Quincy Morgan
70e88ee9af
v2.14.2
2019-02-21 17:01:00 -05:00
Quincy Morgan
ee6c06d1d5
Fix an issue where the commit sidebar would not show all warning and errors
...
Remove use of lodash from commit_warnings.js
2019-02-21 15:33:14 -05:00
Quincy Morgan
10e73fc15c
Explicitly include certain railways for crossing validation instead of excluding some
...
Don't flag abandoned or razed railway crossings
2019-02-21 15:09:13 -05:00
Quincy Morgan
02d3097d8d
Fix a cacheing issue
2019-02-21 13:34:51 -05:00
Quincy Morgan
7936266a7a
Improve validation performance by avoiding uniqueWith lodash function
...
Replace map lodash function with JavaScript array map in validator.js
2019-02-21 12:13:27 -05:00
Quincy Morgan
51972ea78f
Cache issues in crossing ways validation to avoid checking the same pairs twice
2019-02-21 11:49:31 -05:00
Quincy Morgan
aa992ed981
Improve validation performance by cacheing the issue id
2019-02-21 10:47:57 -05:00
Quincy Morgan
2d6c49b92b
Ignore proposed features for crossings ways, almost junction, and disconnected way validations ( close #5922 )
2019-02-21 10:14:25 -05:00
Quincy Morgan
7da37384f1
Fix an issue where stale missing tag errors could persist when canceling drawing a new way ( close #5918 )
...
Don't show missing tags error for a feature that is still being drawn (re: #5898 )
2019-02-21 09:48:46 -05:00
Quincy Morgan
be71554f61
Fix a bug where all data would disappear when switching modes while drawing a way ( close #5917 )
2019-02-21 09:22:03 -05:00
Quincy Morgan
1bde3ba63f
v2.14.1
2019-02-20 18:23:47 -05:00
SilentSpike
5bd13dc590
Use https for ImproveOSM requests
2019-02-20 23:11:09 +00:00
Quincy Morgan
1f1e88314d
v2.14.0
2019-02-20 16:19:36 -05:00
Quincy Morgan
affdb8c860
Fix waterway relation icon color
2019-02-20 15:22:24 -05:00
Quincy Morgan
aff86979a6
Better pane display at narrow window widths ( close #5890 )
2019-02-20 13:47:11 -05:00
Quincy Morgan
a928621681
Fix issue where mapillary sign colors were not shown
2019-02-20 11:09:57 -05:00
Quincy Morgan
6342235a6b
Use warning instead of error for missing tags issue for non-deletable relations
2019-02-20 10:27:49 -05:00
Quincy Morgan
e102c3fdc6
Don't allow actionable deletion of relations if not all members are downloaded
2019-02-20 10:20:26 -05:00
Quincy Morgan
598827db87
Add quick fix to remove deprecated tags
2019-02-20 10:06:44 -05:00
Quincy Morgan
cdc4557da5
Minor performance improvement in crossing ways by removing use of lodash and avoiding a concat within a reduce
2019-02-20 09:50:53 -05:00
Quincy Morgan
e161db0301
Remove unused deprecate_tags action
2019-02-20 09:05:34 -05:00
Quincy Morgan
ba68d921fe
Add icons for crossing ways fixes and almost junction connection fix
2019-02-20 09:02:05 -05:00
Quincy Morgan
63caa02cea
Allow presets to inherit multiCombo and semiCombo fields even if they define the preset
2019-02-19 15:48:50 -05:00
Quincy Morgan
6d397e89c6
Account for waterway bridges and implicit layers in crossing ways validation
2019-02-19 15:28:27 -05:00
Quincy Morgan
f536706763
Refactor crossing ways validation for performance
2019-02-19 14:40:54 -05:00
Quincy Morgan
b766f82cbd
Improve crossing ways performance slightly by avoiding clone
2019-02-19 13:25:02 -05:00
Quincy Morgan
708c5e8155
Fix crash when undoing an added line past the first node
2019-02-19 12:10:05 -05:00
Quincy Morgan
12a44421c3
Account for indoor features in crossing ways validation
...
Recommend using an appropriate structure/layer/level for crossing ways validation
Flag crossing highways on different levels but without bridges or tunnels
2019-02-19 11:43:05 -05:00
Quincy Morgan
95f8ed9416
Fix issue where clicking the combobox caret would not open the dropdown
2019-02-19 09:46:39 -05:00
Quincy Morgan
b43796a4c7
Don't flag almost junctions for points endpoints that also occur earlier in the way
2019-02-19 09:16:32 -05:00
Quincy Morgan
794e953d43
Don't suggest continuing a disconnected highway from endpoints that have noexit=yes
2019-02-19 08:40:49 -05:00
Quincy Morgan
b483832a80
Remove unused parameter
2019-02-18 14:14:36 -05:00
Quincy Morgan
7307beff21
Don't make connect endpoints fix for tag suggest area actionable if there aren't more than two nodes
2019-02-18 12:51:50 -05:00
Quincy Morgan
10d9f05739
Show the actual deprecated tag value in the issue message rather than the * placeholder
2019-02-18 12:17:52 -05:00
Quincy Morgan
66db6f3f2c
Make building crossing validation only create one issue per feature pair (re: #5891 )
2019-02-18 10:43:19 -05:00
