f4b9abe474
Merge pull request #5867 from SilentSpike/iOSM-comments
...
Add comments to ImproveOSM issues
2019-02-07 09:46:57 -05:00
a702281fb6
Add "remove" tooltip to raw tag editor remove button
2019-02-06 15:56:12 -05:00
e0a41656a1
Allow value to be entered before key in raw tag editor
...
(closes #5872 )
This commit also hardens the 'key=value' splitting behavior to actually
check the split result length and avoid overwriting a readonly key
(re: #5024 )
2019-02-06 15:03:03 -05:00
640730d38b
Change focus to existing key instead of suffixing it with _1
...
(re: #3625 , re: #2896 )
2019-02-06 10:29:09 -05:00
a566d58f81
Fix error on ImproveOSM issues with no comments
2019-02-05 21:48:06 +00:00
b87ae4e98b
Exclude existing keys from auto-completion in raw tag editor
...
(closes #3625 )
2019-02-05 16:14:18 -05:00
78111955dd
Fix user URL on ImproveOSM comments
2019-02-05 21:06:19 +00:00
c095600635
Use more appropriate new comment header string
2019-02-05 20:44:04 +00:00
5fc87fb0a4
Pacify eslint
...
(I really need to start running npm test more often before pushing)
2019-02-05 20:23:02 +00:00
f7bef29b92
Fix date conversion on ImproveOSM comments
2019-02-05 20:03:55 +00:00
2c7b689b47
Add comments display to ImproveOSM issues
2019-02-05 19:52:44 +00:00
51af1f3b13
Don't re-sort the keys in the raw tag editor when tabbing
...
(closes #5857 )
2019-02-05 14:52:13 -05:00
448119324f
Add ability to comment on ImproveOSM issues
2019-02-05 17:11:37 +00:00
e71eddd138
Merge branch 'unify' of https://github.com/SilentSpike/iD into SilentSpike-unify
2019-02-05 10:41:08 -05:00
781558e56b
Remove redundant source property
2019-02-04 18:40:06 +00:00
7fe0380d7d
Make sure icon fill colors can be overridden
2019-02-04 13:01:35 -05:00
d7147996ed
Merge remote-tracking branch 'upstream/master' into unify
2019-02-04 17:17:17 +00:00
40af841d53
Fix sidebar preview for new generic errors
2019-02-04 16:54:07 +00:00
3ed13e9a4a
Convert KeepRight to use generic error type
2019-02-04 16:54:07 +00:00
20ed8b50c9
Add generic QA error
...
I've converted the improveOSM errors to use this new generic QA error
structure which should allow for more general code to be used in
behaviour and UI.
Sidebar preview is currently broken, but will be fixed shortly.
2019-02-04 16:53:59 +00:00
82ea58d943
Add default value to number field
2019-02-04 15:59:08 +01:00
9403f71140
Track closed ImproveOSM errors via coordinates
2019-02-01 23:31:08 +00:00
183dda5999
Pacify eslint
2019-02-01 22:51:04 +00:00
ee5f9f3bf2
Use consistent short service name
2019-02-01 22:51:02 +00:00
54e02ec28d
Introduce new container icon for errors
...
As per my last commit, this icon differentiates errors from points and
still allows us to specifiy icons for errors to differentiate them amongst
eachother.
I learned quite a bit about SVGs and using them in HTML while
implementing this 😝 Had some issues getting the icon to center in the
header so resorted to using a flexbox instead of absolute positioning
being used elsewhere.
2019-02-01 22:51:02 +00:00
9d2792836f
Add ImproveOSM error resolution
2019-02-01 22:50:58 +00:00
ac4cec1429
Add sidebar preview for ImproveOSM errors
2019-02-01 22:50:57 +00:00
214cf41019
Use more generic classes for errors
2019-02-01 22:50:57 +00:00
9600d67fc6
Differentiate missing geometry errors by colour
2019-02-01 22:50:56 +00:00
ca290b5101
Add details to error messages
2019-02-01 22:50:55 +00:00
23a4d71410
Handle turn restriction errors
2019-02-01 22:50:55 +00:00
4f2646d567
Add basic title + description UI
2019-02-01 22:50:54 +00:00
4d89810721
Add ImproveOSM service
...
Only processing one-way errors for now
2019-02-01 22:50:54 +00:00
d1fca87d79
Replace Edit Documentation link with pencil icon
...
(closes #5753 )
2019-02-01 11:49:03 -05:00
af8fb1d758
Show combobox if we are moving from a different active combobox
...
(closes #5752 )
Previously it would go down the `hide()` branch anytime an existing combobox
was active.
2019-01-28 16:22:37 -05:00
49442afe0c
In raw member editor, cancel combobox on blur if it hasn't been accepted
2019-01-28 15:41:50 -05:00
d0021f77ca
Handle possibility of combobox blurring without dispatching accept
2019-01-28 13:43:40 -05:00
87ddfa68dc
Revert 55715a482 - caused raw_tag_editor combos to not blur in Safari
2019-01-28 11:20:32 -05:00
b9444ab991
Restore hand cursor on dropdown carat
...
(closes #5769 )
This change allows pointer events to flow to the caret, and forwards
them back to the combo input. Also renames several event handlers
for clarity, and increases the double-click detection threshold.
2019-01-26 13:22:31 -05:00
18d71448be
pacify eslint
2019-01-25 16:23:46 -05:00
5d6e331635
Don't erase name field when tabbing from it
...
(closes #5760 )
2019-01-25 16:16:07 -05:00
55715a4827
Try to dispatch an accept event on blur
...
(re: #5752 - but does not close it)
2019-01-25 14:47:17 -05:00
f2f4c2d9c7
Make optional multiCombo fields appear if a value exists ( closes #5764 )
2019-01-25 09:43:07 -05:00
decba8f215
Fix cycleway field to appear if "cycleway" tag present but not "cycleway:left" nor "cycleway:right" ( close #5756 )
2019-01-25 08:39:15 -05:00
fa1edc86a1
Another place where we should delimit name suggestion on en-dash
...
see 20bcfc573
2019-01-23 09:57:43 -05:00
20bcfc5730
Delimit name-suggestion-preset names on en-dash, not hyphen
...
To avoid conflicts with hyphenated names, or bilingual names
with hyphens in them (like used in Brussels)
2019-01-23 09:44:24 -05:00
4583e2d4d7
Make sure all combo event listeners can handle accept/cancel w/o datum
...
(re: #5637 , re: #5618 )
This can happen if the user enters a value that is not matched to
one of the combo suggestions.
Also make sure to set `this` to the input field. It might not be
already if the event was triggered from a keypress instead of a click.
2019-01-22 23:14:34 -05:00
0c7b9a631e
Improve combobox event handling and avoid overwriting typed data
...
(closes #5722 , re: #5637 , re: #5618 )
dispatched with a value() string instead of a datum, which
causes issues for code expecting a datum always.
(such as localized.js brand picker or "Add Field" combo)
Fix for this coming in next commit.
2019-01-22 22:26:27 -05:00
1323ec3d5a
Map Data and Background panes no longer reload hidden sections
2019-01-21 15:52:58 -05:00
35ac247ff0
Fixes an issue where panel sections wouldn't render when toggled if hidden on page load ( closes #5743 )
2019-01-21 15:22:50 -05:00
Bryan Housel